From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] time: tick-sched: use bool for tick_stopped Date: Tue, 10 Apr 2018 14:26:04 +0200 Message-ID: <20180410122604.GE4082@hirez.programming.kicks-ass.net> References: <891d4f632fbff5052e11f2d0b6fac35d@codeaurora.org> <20180410112637.GD4082@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: yuankuiz@codeaurora.org, "Rafael J. Wysocki" , Linux PM , "Rafael J. Wysocki" , Frederic Weisbecker , Ingo Molnar , Len Brown , Linux Kernel Mailing List , linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Tue, Apr 10, 2018 at 02:07:32PM +0200, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, Peter Zijlstra wrote: > > Do you have any actual evidence for that? Is there a compiler stupid > > enough to generate code to convert a bool to a 1bit value? > > Sure, if you do: > > > > > > > > + bool tick_stopped : 1; > > which is stupidly allowed by the standard.... The code-gen changes are because of the layout change, not because of the type change.