From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions Date: Tue, 10 Apr 2018 15:00:11 -0700 Message-ID: <20180410150011.df9e036f57b5bcac7ac19686@linux-foundation.org> References: <891d4f632fbff5052e11f2d0b6fac35d@codeaurora.org> <20180410123305.GF4082@hirez.programming.kicks-ass.net> <95477c93db187bab6da8a8ba7c57836868446179.camel@perches.com> <20180410143950.4b8526073b4e3e34689f68cb@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Peter Zijlstra , "Rafael J. Wysocki" , Andy Whitcroft , yuankuiz@codeaurora.org, Linux PM , "Rafael J. Wysocki" , Frederic Weisbecker , Thomas Gleixner , paulmck@linux.vnet.ibm.com, Ingo Molnar , Len Brown , Linux Kernel Mailing List List-Id: linux-pm@vger.kernel.org On Tue, 10 Apr 2018 14:53:51 -0700 Joe Perches wrote: > On Tue, 2018-04-10 at 14:39 -0700, Andrew Morton wrote: > > On Tue, 10 Apr 2018 11:19:54 -0700 Joe Perches wrote: > > > > > A struct with a bool member can have different sizes on various > > > architectures because neither bool size nor alignment is standardized. > > > > What's wrong with bools in structs? > > See above. Yeah, but so what? `long' has different sizes on different architectures too.