From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS Date: Mon, 23 Apr 2018 13:28:18 +0200 Message-ID: <20180423112818.GA22932@kroah.com> References: <20180422140508.GA21446@kroah.com> <2E89032DDAA8B9408CB92943514A0337014C1E6AAD@SW-EX-MBX01.diasemi.com> <2E89032DDAA8B9408CB92943514A0337014C1E6B41@SW-EX-MBX01.diasemi.com> <20180423082528.GA20868@kroah.com> <2E89032DDAA8B9408CB92943514A0337014C1E6D67@SW-EX-MBX01.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1E6D67@SW-EX-MBX01.diasemi.com> Sender: linux-kernel-owner@vger.kernel.org To: Adam Thomson Cc: Heikki Krogerus , Guenter Roeck , Sebastian Reichel , Hans de Goede , Jun Li , "linux-usb@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource List-Id: linux-pm@vger.kernel.org On Mon, Apr 23, 2018 at 11:06:25AM +0000, Adam Thomson wrote: > On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > > > On Mon, Apr 23, 2018 at 07:49:38AM +0000, Adam Thomson wrote: > > > On 22 April 2018 21:58, Adam Thomson wrote: > > > > > > > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > > > > > > > On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote: > > > > > > This commit adds code to handle requesting of PPS APDOs. Switching > > > > > > between standard PDOs and APDOs, and re-requesting an APDO to > > > > > > modify operating voltage/current will be triggered by an > > > > > > external call into TCPM. > > > > > > > > > > > > Signed-off-by: Adam Thomson > > > > > > Acked-by: Heikki Krogerus > > > > > > Reviewed-by: Guenter Roeck > > > > > > --- > > > > > > drivers/usb/typec/tcpm.c | 517 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++- > > > > > > include/linux/usb/pd.h | 4 +- > > > > > > include/linux/usb/tcpm.h | 1 + > > > > > > 3 files changed, 509 insertions(+), 13 deletions(-) > > > > > > > > > > This patch adds build warnings to the tree, so I can't take it, sorry. > > > > > Please fix up and resend. > > > > > > > > No problem. Sorry for that. Will take a look and resolve the warnings. > > > > > > Sadly this is going to be a bit more than 'resolve the warnings' task now as Jun > > > Li's patch set has now made it in before me which means I need to rebase PDO > > > Selection because of his changes. :( > > > > Someone was going to have to do that, sorry :( > > Just as an FYI, this patch will produce warnings until the associated > power_supply interface patch (number 5 in the series previously sent) is > included as that makes use of the new API. Not sure how I can get around that > so I guess we have to wait on Sebastian to give the nod for the rest of the > power_supply patches before this can make it through. That's not good. There has to be a way to prevent a build warning from happening... thanks, greg k-h