From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 3/3] scsi: ufs: Use freq table with devfreq Date: Tue, 24 Apr 2018 15:14:09 -0700 Message-ID: <20180424221409.GE18510@minitux> References: <20180424002016.9205-1-bjorn.andersson@linaro.org> <20180424002016.9205-4-bjorn.andersson@linaro.org> <5e59150bf025e2caa1deadfec7293ecd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5e59150bf025e2caa1deadfec7293ecd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Subhash Jadavani Cc: Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam , linux-scsi-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Tue 24 Apr 15:08 PDT 2018, Subhash Jadavani wrote: > On 2018-04-23 17:20, Bjorn Andersson wrote: > > devfreq requires that the client operates on actual frequencies, not > > only 0 and UMAX_INT and as such UFS brok with the introduction of > > f1d981eaecf8 ("PM / devfreq: Use the available min/max frequency"). > > > > This patch registers the frequencies of the first clock with devfreq and > > use these to determine if we're trying to step up or down. > > [..] > > Looks good to me. > Reviewed-by: Subhash Jadavani > Thanks Subhash. Unfortunately I need to respin this to register the opp table based on our freq table, so there will be a v2 of this soon. Regards, Bjorn