From: Yu Chen <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>,
Artem Bityutskiy <artem.bityutskiy@intel.com>,
Doug Smythies <dsmythies@telus.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][v5] tools/power turbostat: if --iterations, print for specific count of iterations
Date: Thu, 26 Apr 2018 08:08:48 +0800 [thread overview]
Message-ID: <20180426000847.GA20079@sandybridge-desktop> (raw)
In-Reply-To: <1840879.edVvmFFlsp@aspire.rjw.lan>
On Mon, Apr 23, 2018 at 10:48:39AM +0200, Rafael J. Wysocki wrote:
> On Saturday, April 14, 2018 6:10:55 AM CEST Yu Chen wrote:
> > From: Chen Yu <yu.c.chen@intel.com>
> >
> > There's a use case during test to only print specific round of iterations
> > if --iterations is specified, for example, with this patch applied:
> >
> > turbostat -i 5 -r 4
> > will capture 4 samples with 5 seconds interval.
> >
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Rafael J Wysocki <rjw@rjwysocki.net>
> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
> > Cc: Doug Smythies <dsmythies@telus.net>
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
[cut]...
> > + if (iterations && (++done_iters >= iterations))
>
> The inner parens are not needed here (and similarly below).
>
> If you fix this little one, please feel free to add
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> to the patch (FWIW).
>
OK, will do, thanks!
Yu
prev parent reply other threads:[~2018-04-26 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 4:10 [PATCH][v5] tools/power turbostat: if --iterations, print for specific count of iterations Yu Chen
2018-04-23 8:48 ` Rafael J. Wysocki
2018-04-26 0:08 ` Yu Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426000847.GA20079@sandybridge-desktop \
--to=yu.c.chen@intel.com \
--cc=artem.bityutskiy@intel.com \
--cc=dsmythies@telus.net \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox