From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg() Date: Tue, 1 May 2018 11:39:14 +0200 Message-ID: <20180501093914.GG27619@mai> References: <1524743493-28113-1-git-send-email-b.zolnierkie@samsung.com> <1524743493-28113-7-git-send-email-b.zolnierkie@samsung.com> <20180430153431.GB27619@mai> <26762578.lZtk787caq@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <26762578.lZtk787caq@amdc3058> Sender: linux-kernel-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Eduardo Valentin , Zhang Rui , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Mon, Apr 30, 2018 at 05:48:29PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, April 30, 2018 05:34:31 PM Daniel Lezcano wrote: > > On Thu, Apr 26, 2018 at 01:51:21PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > of_thermal_get_ntrips() may return value bigger than supported > > > by a given SoC (i.e. on Exynos5422/5800) > > > > Can you elaborate a bit ? > > Odroid-XU3 DTS file [1] define 6 thermal trip points (2 passive ones) > while data->ntrip is 4, the current code works fine by accident as > the threshold values for trip points 5 & 6 don't fit into 32-bits > threshold value (however since they are passive ones this is okay). Ah, I see. data->ntrip is the SoC specific tmu max value capping what is defined in the DT, right ? > Of course the code for handling passive trip points still needs to > be fixed to properly handle all odd cases (which are not present in > current DTS files). > > [1] arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi Yeah, it is definitively a good idea of cleaning up this driver :/ Reviewed-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog