From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 14/18] thermal: exynos: move trips setting to exynos_tmu_initialize() Date: Tue, 1 May 2018 12:31:26 +0200 Message-ID: <20180501103126.GK27619@mai> References: <1524743493-28113-1-git-send-email-b.zolnierkie@samsung.com> <1524743493-28113-15-git-send-email-b.zolnierkie@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1524743493-28113-15-git-send-email-b.zolnierkie@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Eduardo Valentin , Zhang Rui , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Thu, Apr 26, 2018 at 01:51:29PM +0200, Bartlomiej Zolnierkiewicz wrote: > * Add dummy exynos4210_tmu_set_trip_hyst() helper. > > * Add ->tmu_set_trip_temp and ->tmu_set_trip_hyst methods to struct > exynos_tmu_data and set them in exynos_map_dt_data(). > > * Move trips setting to exynos_tmu_initialize(). > > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- [ ... ] > +/* failing thresholds are not supported on Exynos4210 */ > +static void exynos4210_tmu_set_trip_hyst(struct exynos_tmu_data *data, > + int trip, u8 temp, u8 hyst) > +{ > +} > + May be you can get rid of this empty function and check against a NULL pointer in exynos_tmu_initialize ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog