From: Eduardo Valentin <edubezval@gmail.com>
To: srplinux2008 <srplinux2008@gmail.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, rui.zhang@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops
Date: Sun, 6 May 2018 15:50:45 -0700 [thread overview]
Message-ID: <20180506225044.GA25956@localhost.localdomain> (raw)
In-Reply-To: <1523188905-3066-1-git-send-email-srplinux2008@gmail.com>
On Sun, Apr 08, 2018 at 05:31:45PM +0530, srplinux2008 wrote:
> From: srp linux <srplinux2008@gmail.com>
>
> Correct the typecast with const to struct thermal_cooling_device_ops.
> It is the last argument to the function thermal_of_cooling_device_register
> and this argument is of type const. So, declare this structure
> thermal_cooling_device_ops as constant.
>
> Signed-off-by: srp linux <srplinux2008@gmail.com>
Please resend with your real name.
Thanks
> ---
> drivers/thermal/tegra/soctherm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
> index 455b58c..72da745 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -926,7 +926,7 @@ static int throt_set_cdev_state(struct thermal_cooling_device *cdev,
> return 0;
> }
>
> -static struct thermal_cooling_device_ops throt_cooling_ops = {
> +static const struct thermal_cooling_device_ops throt_cooling_ops = {
> .get_max_state = throt_get_cdev_max_state,
> .get_cur_state = throt_get_cdev_cur_state,
> .set_cur_state = throt_set_cdev_state,
> --
> 2.7.4
>
prev parent reply other threads:[~2018-05-06 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 12:01 [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops srplinux2008
2018-04-09 11:56 ` Thierry Reding
2018-05-06 22:50 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180506225044.GA25956@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srplinux2008@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).