From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [RFC/RFT] [PATCH 10/10] cpufreq: intel_pstate: enable boost for SKX Date: Wed, 16 May 2018 17:54:24 +0200 Message-ID: <20180516155424.GG12198@hirez.programming.kicks-ass.net> References: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com> <20180516044911.28797-11-srinivas.pandruvada@linux.intel.com> <20180516074948.GZ12217@hirez.programming.kicks-ass.net> <1526485584.61700.19.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1526485584.61700.19.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Srinivas Pandruvada Cc: tglx@linutronix.de, mingo@redhat.com, bp@suse.de, lenb@kernel.org, rjw@rjwysocki.net, mgorman@techsingularity.net, x86@kernel.org, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, juri.lelli@arm.com, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Wed, May 16, 2018 at 08:46:24AM -0700, Srinivas Pandruvada wrote: > On Wed, 2018-05-16 at 09:49 +0200, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 09:49:11PM -0700, Srinivas Pandruvada wrote: > > > Enable HWP boost on Skylake server platform. > > > > Why not unconditionally enable it on everything HWP ? > Never noticed in any difference performance in clients with HWP nor > anybody complained. Since clients uses single power domain, some other > CPUs always gives boost. Can't the hardware tell us about per-core stuff? Do we really have to use tables for that?