From mboxrd@z Thu Jan 1 00:00:00 1970 From: ilia.lin@gmail.com Subject: [PATCH] cpufreq: kryo: Fix possible error code dereference Date: Thu, 14 Jun 2018 22:29:21 +0200 Message-ID: <20180614202921.32535-1-ilia.lin@gmail.com> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Ilia Lin , Ilia Lin , "Rafael J . Wysocki" , Viresh Kumar Cc: Dan Carpenter , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org From: Ilia Lin In event of error returned by the nvmem_cell_read() non-pointer value may be dereferenced. Fix this with error handling. Signed-off-by: Ilia Lin --- drivers/cpufreq/qcom-cpufreq-kryo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c index d049fe4b80c4..5e9511223ce9 100644 --- a/drivers/cpufreq/qcom-cpufreq-kryo.c +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c @@ -115,6 +115,8 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev) speedbin = nvmem_cell_read(speedbin_nvmem, &len); nvmem_cell_put(speedbin_nvmem); + if (IS_ERR(speedbin)) + return PTR_ERR(speedbin); switch (msm8996_version) { case MSM8996_V3: -- 2.11.0