* [PATCH 04/12] cpufreq: use for_each_if
[not found] <20180709083650.23549-1-daniel.vetter@ffwll.ch>
@ 2018-07-09 8:36 ` Daniel Vetter
2018-07-09 9:28 ` Eric Engestrom
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-07-09 8:36 UTC (permalink / raw)
To: LKML
Cc: DRI Development, Intel Graphics Development, Daniel Vetter,
Daniel Vetter, Rafael J. Wysocki, Viresh Kumar, linux-pm
Avoids the inverted condition compared to the open coded version.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
---
include/linux/cpufreq.h | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 882a9b9e34bc..f2028c229b96 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
#define cpufreq_for_each_valid_entry(pos, table) \
for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \
- if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
- continue; \
- else
+ for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
/*
* cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq
@@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
#define cpufreq_for_each_valid_entry_idx(pos, table, idx) \
cpufreq_for_each_entry_idx(pos, table, idx) \
- if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
- continue; \
- else
+ for_each_if (pos->frequency == CPUFREQ_ENTRY_INVALID)
int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 04/12] cpufreq: use for_each_if
2018-07-09 8:36 ` [PATCH 04/12] cpufreq: use for_each_if Daniel Vetter
@ 2018-07-09 9:28 ` Eric Engestrom
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
1 sibling, 0 replies; 4+ messages in thread
From: Eric Engestrom @ 2018-07-09 9:28 UTC (permalink / raw)
To: Daniel Vetter
Cc: linux-pm, Viresh Kumar, Intel Graphics Development,
Rafael J. Wysocki, LKML, DRI Development, Daniel Vetter
On Monday, 2018-07-09 10:36:42 +0200, Daniel Vetter wrote:
> Avoids the inverted condition compared to the open coded version.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> ---
> include/linux/cpufreq.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 882a9b9e34bc..f2028c229b96 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry(pos, table) \
> for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
>
> /*
> * cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq
> @@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry_idx(pos, table, idx) \
> cpufreq_for_each_entry_idx(pos, table, idx) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency == CPUFREQ_ENTRY_INVALID)
Should be `!=` there ^
>
>
> int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
> --
> 2.18.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cpufreq: use for_each_if
2018-07-09 8:36 ` [PATCH 04/12] cpufreq: use for_each_if Daniel Vetter
2018-07-09 9:28 ` Eric Engestrom
@ 2018-07-09 16:11 ` Daniel Vetter
2018-07-09 21:36 ` Rafael J. Wysocki
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2018-07-09 16:11 UTC (permalink / raw)
To: LKML
Cc: linux-pm, Daniel Vetter, Intel Graphics Development,
Rafael J. Wysocki, DRI Development, Eric Engestrom, Viresh Kumar,
Daniel Vetter
Avoids the inverted condition compared to the open coded version.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
Cc: Eric Engestrom <eric.engestrom@intel.com>
--
v2: Fix the logic fumble in the 2nd hunk, spotted by Eric.
---
include/linux/cpufreq.h | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 882a9b9e34bc..3a774f523d00 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
#define cpufreq_for_each_valid_entry(pos, table) \
for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \
- if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
- continue; \
- else
+ for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
/*
* cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq
@@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
#define cpufreq_for_each_valid_entry_idx(pos, table, idx) \
cpufreq_for_each_entry_idx(pos, table, idx) \
- if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
- continue; \
- else
+ for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: use for_each_if
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
@ 2018-07-09 21:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-07-09 21:36 UTC (permalink / raw)
To: Daniel Vetter
Cc: Linux PM, Viresh Kumar, Intel Graphics Development,
Rafael J. Wysocki, LKML, DRI Development, Eric Engestrom,
Daniel Vetter
On Mon, Jul 9, 2018 at 6:11 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Avoids the inverted condition compared to the open coded version.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> Cc: Eric Engestrom <eric.engestrom@intel.com>
> --
> v2: Fix the logic fumble in the 2nd hunk, spotted by Eric.
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Or do you want me to apply it?
> ---
> include/linux/cpufreq.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 882a9b9e34bc..3a774f523d00 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry(pos, table) \
> for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
>
> /*
> * cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq
> @@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry_idx(pos, table, idx) \
> cpufreq_for_each_entry_idx(pos, table, idx) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
>
>
> int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
> --
> 2.18.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-09 21:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180709083650.23549-1-daniel.vetter@ffwll.ch>
2018-07-09 8:36 ` [PATCH 04/12] cpufreq: use for_each_if Daniel Vetter
2018-07-09 9:28 ` Eric Engestrom
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
2018-07-09 21:36 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).