From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH v5 09/14] sched: Add over-utilization/tipping point indicator Date: Mon, 6 Aug 2018 12:02:13 +0100 Message-ID: <20180806110211.kvibet576unwaowl@queper01-lin> References: <20180802161027.v2ctgscuc4uxbb7u@queper01-lin> <20180802165924.7ywgoxj2jwftxycz@queper01-lin> <20180803081850.hj7bp5ognuywapmd@queper01-lin> <20180803155547.sxlhxpmhwcoappit@queper01-lin> <20180806094342.lonjz4g3lspcatcy@queper01-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Vincent Guittot Cc: Peter Zijlstra , "Rafael J. Wysocki" , linux-kernel , "open list:THERMAL" , "gregkh@linuxfoundation.org" , Ingo Molnar , Dietmar Eggemann , Morten Rasmussen , Chris Redpath , Patrick Bellasi , Valentin Schneider , Thara Gopinath , viresh kumar , Todd Kjos , Joel Fernandes , "Cc: Steve Muckle" , adharmap@quicinc.com, "Kannan, Saravana" , pkondeti@codeaurora.org List-Id: linux-pm@vger.kernel.org On Monday 06 Aug 2018 at 12:45:44 (+0200), Vincent Guittot wrote: > On Mon, 6 Aug 2018 at 11:43, Quentin Perret wrote: > I would have preferred to have a full power policy for all task when > EAS is in used by default and then see if there is any performance > problem instead of letting some UC unclear but that's a personal > opinion. Understood. I'd say let's keep things simple for now unless there is a consensus that this is must-have form the start. > so IMO, the minimum is to add a comment in the code that describes > this behavior for fork tasks so people will understand why EAS puts > newly created task on not "EAS friendly" cpus when they will look at > the code trying to understand the behavior Agreed, that really needs to be documented. I'll add a comment somewhere in v6. Thanks, Quentin