From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: David Dai <daidavid1@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
georgi.djakov@linaro.org, vincent.guittot@linaro.org,
amit.kucheria@linaro.org, ilina@codeaurora.org,
seansw@qti.qualcomm.com, grahamr@qti.qualcomm.com
Subject: Re: [RFC PATCH v2 1/2] interconnect: qcom: Add sdm845 interconnect provider driver
Date: Mon, 6 Aug 2018 15:52:52 -0700 [thread overview]
Message-ID: <20180806225252.GQ30024@minitux> (raw)
In-Reply-To: <1531967820-27483-2-git-send-email-daidavid1@codeaurora.org>
On Wed 18 Jul 19:36 PDT 2018, David Dai wrote:
> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
[..]
> +DEFINE_QNODE(ipa_core_master, MASTER_IPA_CORE, 1, 8, 1, SLAVE_IPA_CORE);
[..]
> +DEFINE_QNODE(ipa_core_slave, SLAVE_IPA_CORE, 1, 8, 0);
As discussed before; while the two sides of IPA_CORE are controlled
through the "bus mechanism", they do represent the clock of the IPA
block.
I think it would make sense to make this interconnect provider also
register a clock provider and expose this as a clock, for the IPA driver
to consume.
Regards,
Bjorn
next prev parent reply other threads:[~2018-08-06 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 2:36 [RFC PATCH v1 0/2] Add QCOM SDM845 interconnect provider driver David Dai
2018-07-19 2:36 ` [RFC PATCH v2 1/2] interconnect: qcom: Add sdm845 " David Dai
2018-07-27 21:12 ` Evan Green
2018-08-01 1:00 ` David Dai
2018-08-06 22:52 ` Bjorn Andersson [this message]
2018-07-19 2:37 ` [RFC PATCH v2 2/2] arm64: dts: sdm845: Add interconnect provider DT nodes David Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806225252.GQ30024@minitux \
--to=bjorn.andersson@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=grahamr@qti.qualcomm.com \
--cc=ilina@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox