From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH v3 03/14] sched/core: uclamp: add CPU's clamp groups accounting Date: Thu, 16 Aug 2018 14:37:40 +0100 Message-ID: <20180816133737.xfwfoenbhb5wnndi@queper01-lin> References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-4-patrick.bellasi@arm.com> <20180814164905.GG2605@e110439-lin> <7c45c1a8-24cb-6798-5b6f-3b5dfc9b490d@arm.com> <20180815105428.GA7388@e110439-lin> <20180816133249.GA2964@e110439-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180816133249.GA2964@e110439-lin> Sender: linux-kernel-owner@vger.kernel.org To: Patrick Bellasi Cc: Dietmar Eggemann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan List-Id: linux-pm@vger.kernel.org > > IMHO, if this is something which should not happen at all, a BUG_ON() is the > > right thing to do here. > > I don't agree on that. I agree it should not happen but since it's a > recoverable error it think we should not panic. FWIW, if this is a recoverable error, I think Linus will agree with Patrick on this one :-) https://lkml.org/lkml/2016/10/4/1