From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH v3 01/14] sched/core: uclamp: extend sched_setattr to support utilization clamping Date: Fri, 17 Aug 2018 11:34:38 +0100 Message-ID: <20180817103406.gmve4clcxmhwlmtc@queper01-lin> References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-2-patrick.bellasi@arm.com> <20180807123550.GA3062@localhost.localdomain> <20180809091427.4p2c4fbxocpkjaby@darkstar> <20180809095043.GC22465@localhost.localdomain> <20180809152313.lewfhufidhxb2qrk@darkstar> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180809152313.lewfhufidhxb2qrk@darkstar> Sender: linux-kernel-owner@vger.kernel.org To: Patrick Bellasi Cc: Juri Lelli , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Dietmar Eggemann , Morten Rasmussen , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan List-Id: linux-pm@vger.kernel.org Hi Patrick, On Thursday 09 Aug 2018 at 16:23:13 (+0100), Patrick Bellasi wrote: > On 09-Aug 11:50, Juri Lelli wrote: > > On 09/08/18 10:14, Patrick Bellasi wrote: > > > On 07-Aug 14:35, Juri Lelli wrote: > > > > On 06/08/18 17:39, Patrick Bellasi wrote: > > [...] > > > > 1) make CAP_SYS_NICE protected the clamp groups, with an optional boot > > > time parameter to relax this check > > > > It seems to me that this might work well with that the intended usage of > > the interface that you depict above. SMS only (or any privileged user) > > will be in control of how groups are configured, so no problem for > > normal users. > > Yes, well... apart normal users still getting a -ENOSPC is they are > requesting one of the not pre-configured clamp values. Which is why > the following bits can be helpful. So IIUC, normal users would still be free of choosing their clamp values as long as they choose one in the list of pre-allocated ones ? Is that correct ? If yes, that would still let normal users make they tasks look bigger no ? They could just choose the clamp group with the highest min_clamp or something. Isn't this a problem too ? I mean, if that can be abused easily, I'm pretty sure people _will_ abuse it ... Or maybe I misunderstood something ? Thanks, Quentin