From: leo.yan@linaro.org
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] cpuidle: menu: Retain tick when shallow state is selected
Date: Wed, 22 Aug 2018 20:03:30 +0800 [thread overview]
Message-ID: <20180822120330.GB8949@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20180822120200.GA8949@leoy-ThinkPad-X240s>
On Wed, Aug 22, 2018 at 08:02:00PM +0800, Leo Yan wrote:
[...]
> > + if (!tick_nohz_tick_stopped()) {
> > + /*
> > + * If the state selected so far is shallow,
> > + * waking up early won't hurt, so retain the
> > + * tick in that case and let the governor run
> > + * again in the next iteration of the loop.
> > + */
> > + expected_interval = drv->states[idx].target_residency;
> > + break;
> > + }
> > +
>
> This is reliable, how we can rely on a shallow idle state target
> residency to decide if need to stop a tick or not?
s/This is reliable/This isn't reliable
>
> > /*
> > * If the state selected so far is shallow and this
> > * state's target residency matches the time till the
> >
next prev parent reply other threads:[~2018-08-22 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 8:44 [PATCH] cpuidle: menu: Retain tick when shallow state is selected Rafael J. Wysocki
2018-08-22 12:02 ` leo.yan
2018-08-22 12:03 ` leo.yan [this message]
2018-08-22 21:01 ` Rafael J. Wysocki
2018-08-24 9:44 ` Rafael J. Wysocki
2018-08-24 15:44 ` Doug Smythies
2018-08-25 11:21 ` Rafael J. Wysocki
2018-08-26 19:37 ` Doug Smythies
2018-08-29 4:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822120330.GB8949@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox