* [PATCH] power_supply: sysfs: ratelimit property read error message
@ 2018-09-13 0:48 David Lechner
2018-09-13 0:51 ` David Lechner
2018-09-16 9:34 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: David Lechner @ 2018-09-13 0:48 UTC (permalink / raw)
To: Sebastian Reichel, linux-pm; +Cc: linux-kernel, David Lechner
This adds ratelimiting to the message that is printed when reading a
power supply property via sysfs returns an error. This will prevent
userspace applications from unintentionally dDOSing the system by
continuosuly reading a property that returns an error.
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/power/supply/power_supply_sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index 6170ed8b6854..dce24f596160 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
dev_dbg(dev, "driver has no data for `%s' property\n",
attr->attr.name);
else if (ret != -ENODEV && ret != -EAGAIN)
- dev_err(dev, "driver failed to report `%s' property: %zd\n",
+ dev_err_ratelimited(dev,
+ "driver failed to report `%s' property: %zd\n",
attr->attr.name, ret);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power_supply: sysfs: ratelimit property read error message
2018-09-13 0:48 [PATCH] power_supply: sysfs: ratelimit property read error message David Lechner
@ 2018-09-13 0:51 ` David Lechner
2018-09-16 9:34 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: David Lechner @ 2018-09-13 0:51 UTC (permalink / raw)
To: Sebastian Reichel, linux-pm; +Cc: linux-kernel
On 09/12/2018 07:48 PM, David Lechner wrote:
> This adds ratelimiting to the message that is printed when reading a
> power supply property via sysfs returns an error. This will prevent
> userspace applications from unintentionally dDOSing the system by
> continuosuly reading a property that returns an error.
s/continuosuly/continuously/
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
> drivers/power/supply/power_supply_sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 6170ed8b6854..dce24f596160 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
> dev_dbg(dev, "driver has no data for `%s' property\n",
> attr->attr.name);
> else if (ret != -ENODEV && ret != -EAGAIN)
> - dev_err(dev, "driver failed to report `%s' property: %zd\n",
> + dev_err_ratelimited(dev,
> + "driver failed to report `%s' property: %zd\n",
> attr->attr.name, ret);
> return ret;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power_supply: sysfs: ratelimit property read error message
2018-09-13 0:48 [PATCH] power_supply: sysfs: ratelimit property read error message David Lechner
2018-09-13 0:51 ` David Lechner
@ 2018-09-16 9:34 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2018-09-16 9:34 UTC (permalink / raw)
To: David Lechner; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
Hi,
On Wed, Sep 12, 2018 at 07:48:30PM -0500, David Lechner wrote:
> This adds ratelimiting to the message that is printed when reading a
> power supply property via sysfs returns an error. This will prevent
> userspace applications from unintentionally dDOSing the system by
> continuosuly reading a property that returns an error.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/power_supply_sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 6170ed8b6854..dce24f596160 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
> dev_dbg(dev, "driver has no data for `%s' property\n",
> attr->attr.name);
> else if (ret != -ENODEV && ret != -EAGAIN)
> - dev_err(dev, "driver failed to report `%s' property: %zd\n",
> + dev_err_ratelimited(dev,
> + "driver failed to report `%s' property: %zd\n",
> attr->attr.name, ret);
> return ret;
> }
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-16 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-13 0:48 [PATCH] power_supply: sysfs: ratelimit property read error message David Lechner
2018-09-13 0:51 ` David Lechner
2018-09-16 9:34 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).