From: Yu Chen <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>,
Rui Zhang <rui.zhang@intel.com>, Chen Yu <yu.chen.surf@gmail.com>,
Zhimin Gu <kookoo.gu@intel.com>, Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/4][v2] x86, hibernate: Extract the common code of 64/32 bit system
Date: Tue, 18 Sep 2018 21:36:44 +0800 [thread overview]
Message-ID: <20180918133643.GA3120@chenyu-desktop> (raw)
In-Reply-To: <3135968.eiNgRHp3gn@aspire.rjw.lan>
Hi,
On Fri, Sep 14, 2018 at 11:21:17AM +0200, Rafael J. Wysocki wrote:
> On Tuesday, September 11, 2018 7:20:46 PM CEST Chen Yu wrote:
> > From: Zhimin Gu <kookoo.gu@intel.com>
> >
> > Reduce the hibernation code duplication between x86-32 and x86-64
> > by extracting the common code into hibernate.c.
> >
> > No functional change.
> >
> > +#include "hibernate.c"
>
> I don't particularly like this.
>
> Why excatly do you need to include the C file here?
>
OK, I've removed this in a new version.
> Also, the way this change is made makes it quite hard to review, as the
> new code is not exactly the same as the code being removed, so it is
> hard to say whether or not there really are no functional changes
> as claimed.
I've splitted the patch into several sub-patches and reorganized the
code to make it more readable on a new version.
>
> This is sensitive code, mind you, and really hard to debug if anything goes
> wrong. Please be super-careful about changing it.
>
Ok, will test on several platforms and send out the modification.
Best,
Yu
> Thanks,
> Rafael
>
next prev parent reply other threads:[~2018-09-18 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:19 [PATCH 0/4][v2] Fixes hibernation bugs on x86-32 system Chen Yu
2018-09-11 17:20 ` [PATCH 1/4][v2] x86, hibernate: Fix nosave_regions setup for hibernation Chen Yu
2018-09-11 17:20 ` [PATCH 2/4][v2] PM / hibernate: Check the success of generating md5 digest before hibernation Chen Yu
2018-09-13 8:26 ` Thomas Gleixner
2018-09-13 14:00 ` Yu Chen
2018-09-11 17:20 ` [PATCH 3/4][v2] x86, hibernate: Extract the common code of 64/32 bit system Chen Yu
2018-09-14 9:21 ` Rafael J. Wysocki
2018-09-18 13:36 ` Yu Chen [this message]
2018-09-11 17:21 ` [PATCH 4/4][v2] x86, hibernate: Backport several fixes from 64bits to 32bits hibernation Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918133643.GA3120@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=kookoo.gu@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).