From: Yu Chen <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
kookoo.gu@intel.com
Subject: Re: [PATCH 03/12][RFC v3] x86-32/asm/power: Create stack frames in hibernate_asm_32.S
Date: Wed, 19 Sep 2018 16:54:41 +0800 [thread overview]
Message-ID: <20180919085441.GA2335@chenyu-desktop> (raw)
In-Reply-To: <CAJZ5v0jrodgg_j_dEUDsfPibaSDouXVpt-++UQ3-k_7M41dpTA@mail.gmail.com>
On Wed, Sep 19, 2018 at 10:41:16AM +0200, Rafael J. Wysocki wrote:
> On Wed, Sep 19, 2018 at 9:31 AM Chen Yu <yu.c.chen@intel.com> wrote:
> >
> > From: Zhimin Gu <kookoo.gu@intel.com>
> >
> > Backport
> > Commit ef0f3ed5a4ac (x86/asm/power: Create stack frames
> > in hibernate_asm_64.S)
> > and
> > Commit 4ce827b4cc58 (x86/power/64: Fix hibernation return
> > address corruption)
> >
> > And also prepare for relocated code and jump address
> > mapping.
>
> I don't like the changelog.
>
> It should explain the technical reasons for making the changes in the
> first place and then mention that analogous changes were made for
> 64-bit before and by which commits.
>
Ok, will change it in next version.
Thanks,
Yu
> Thanks,
> Rafael
next prev parent reply other threads:[~2018-09-19 8:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 7:37 [PATCH 00/12][RFC v3] Backport several fixes from 64bits to 32bits hibernation Chen Yu
2018-09-19 7:37 ` [PATCH 01/12][RFC v3] x86, hibernate: Fix nosave_regions setup for hibernation Chen Yu
2018-09-19 8:34 ` Rafael J. Wysocki
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:38 ` [PATCH 02/12][RFC v3] PM / hibernate: Check the success of generating md5 digest before hibernation Chen Yu
2018-09-19 8:36 ` Rafael J. Wysocki
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:38 ` [PATCH 03/12][RFC v3] x86-32/asm/power: Create stack frames in hibernate_asm_32.S Chen Yu
2018-09-19 8:41 ` Rafael J. Wysocki
2018-09-19 8:54 ` Yu Chen [this message]
2018-09-19 7:38 ` [PATCH 04/12][RFC v3] x86, hibernate: Extract the common code of 64/32 bit system Chen Yu
2018-09-19 9:03 ` Rafael J. Wysocki
2018-09-19 10:15 ` Rafael J. Wysocki
2018-09-19 10:34 ` Ingo Molnar
2018-09-19 10:36 ` Rafael J. Wysocki
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:38 ` [PATCH 05/12][RFC v3] x86-32, hibernate: Enable CONFIG_ARCH_HIBERNATION_HEADER set on 32bit system Chen Yu
2018-09-19 10:31 ` Rafael J. Wysocki
2018-09-19 7:42 ` [PATCH 06/12][RFC v3] x86, hibernate: Rename temp_level4_pgt to temp_pgt Chen Yu
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:42 ` [PATCH 07/12][RFC v3] x86-32, hibernate: Use temp_pgt as the temporary page table Chen Yu
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:42 ` [PATCH 08/12][RFC v3] x86-32, hibernate: Use the page size macro instead of constant value Chen Yu
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:43 ` [PATCH 09/12][RFC v3] x86-32, hibernate: Switch to original page table after resumed Chen Yu
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:43 ` [PATCH 10/12][RFC v3] x86-32, hibernate: Switch to relocated restore code during resume on 32bit system Chen Yu
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:43 ` [PATCH 11/12][RFC v3] x86-32, hibernate: Set up temporary text mapping for " Chen Yu
2018-09-20 22:05 ` Pavel Machek
2018-09-19 7:43 ` [PATCH 12/12][RFC v3] x86-32, hibernate: Adjust in_suspend after resumed on " Chen Yu
2018-09-20 22:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919085441.GA2335@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=kookoo.gu@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).