From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 04/12][RFC v3] x86, hibernate: Extract the common code of 64/32 bit system Date: Wed, 19 Sep 2018 12:34:05 +0200 Message-ID: <20180919103405.GA19621@gmail.com> References: <020db877db6a8d39808dfaef2a5162f541f0853b.1537275915.git.yu.c.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: "Chen, Yu C" , Thomas Gleixner , "Rafael J. Wysocki" , the arch/x86 maintainers , Linux Kernel Mailing List , Linux PM , Pavel Machek , Len Brown , kookoo.gu@intel.com List-Id: linux-pm@vger.kernel.org * Rafael J. Wysocki wrote: > > index 000000000000..fbde8f0e8fe0 > > --- /dev/null > > +++ b/arch/x86/power/hibernate.c > > @@ -0,0 +1,249 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Hibernation support for x86 > > + * > > + * Copyright (c) 2007 Rafael J. Wysocki > > + * Copyright (c) 2002 Pavel Machek > > + * Copyright (c) 2001 Patrick Mochel > > I don't think this "copyright" information has any legal bearing any > more at this point. I think that's wrong in general, and it's routine for corporate legal departments to insist on specific boilerplate copyright notices when OSS code is contributed. Copying code and then removing copyright notices is frowned upon independently as well. While you can probably talk for your own copyright notice, I'm not sure it's true of the two other historic copyright notices that were copied. So I think it's best practice to preserve all copyright notices as-is. Thanks, Ingo