From: Eduardo Valentin <edubezval@gmail.com>
To: Willy Wolff <willy.mh.wolff.ml@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: power_allocator: remove early break
Date: Mon, 24 Sep 2018 09:45:32 -0700 [thread overview]
Message-ID: <20180924164531.GB4988@localhost.localdomain> (raw)
In-Reply-To: <20180921130609.j3esni6xwhi2ew7d@inc028000032.lancs.ac.uk>
Hey,
On Fri, Sep 21, 2018 at 02:06:09PM +0100, Willy Wolff wrote:
> If a trip of type critical is defined before any trip of passive
> or active type, power_allocator governor will not switch on.
But, if a critical trip is reached, the expectation is to perform a
thermal shutdown. Why would you expect to have power allocator
to be activated during the process of a shutdown?
>
> Signed-off-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
> ---
> drivers/thermal/power_allocator.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c
> index 3055f9a12a17..6544b68e3ebf 100644
> --- a/drivers/thermal/power_allocator.c
> +++ b/drivers/thermal/power_allocator.c
> @@ -496,8 +496,6 @@ static void get_governor_trips(struct thermal_zone_device *tz,
> }
> } else if (type == THERMAL_TRIP_ACTIVE) {
> last_active = i;
> - } else {
> - break;
> }
> }
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2018-09-24 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 13:06 [PATCH] thermal: power_allocator: remove early break Willy Wolff
2018-09-24 16:45 ` Eduardo Valentin [this message]
2018-09-26 22:24 ` Willy Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924164531.GB4988@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).