From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juri Lelli Subject: Re: [PATCH v8 10/15] sched: Introduce a sysctl for Energy Aware Scheduling Date: Tue, 16 Oct 2018 14:50:58 +0200 Message-ID: <20181016125058.GD9130@localhost.localdomain> References: <20181016101513.26919-1-quentin.perret@arm.com> <20181016101513.26919-11-quentin.perret@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181016101513.26919-11-quentin.perret@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Quentin Perret Cc: peterz@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, mingo@redhat.com, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, chris.redpath@arm.com, patrick.bellasi@arm.com, valentin.schneider@arm.com, vincent.guittot@linaro.org, thara.gopinath@linaro.org, viresh.kumar@linaro.org, tkjos@google.com, joel@joelfernandes.org, smuckle@google.com, adharmap@codeaurora.org, skannan@codeaurora.org, pkondeti@codeaurora.org, edubezval@gmail.com, srinivas.pandruvada@linux.intel.com, currojerez@riseup.net, javi.merino@kernel.org List-Id: linux-pm@vger.kernel.org Hi, On 16/10/18 11:15, Quentin Perret wrote: [...] > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index cc02050fd0c4..481309a11174 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -466,6 +466,17 @@ static struct ctl_table kern_table[] = { > .extra1 = &one, > }, > #endif > +#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) > + { > + .procname = "sched_energy_aware", > + .data = &sysctl_sched_energy_aware, > + .maxlen = sizeof(unsigned int), > + .mode = 0644, > + .proc_handler = sched_energy_aware_handler, > + .extra1 = &zero, > + .extra2 = &one, > + }, > +#endif Doesn't this need to be documented in Documentation/sysctl/kernel.txt? Also, do we want a kernel parameter as well to be able to disable this at boot? Best, - Juri