From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ross Zwisler <zwisler@google.com>
Cc: linux-kernel@vger.kernel.org, Ricky Liang <jcliang@chromium.org>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, Stephen Barber <smbarber@chromium.org>
Subject: Re: [PATCH] thermal: add ratelimited thermal and power logging
Date: Wed, 24 Oct 2018 12:52:27 +0530 [thread overview]
Message-ID: <20181024072227.achkbix2ndef2ule@vireshk-i7> (raw)
In-Reply-To: <20181022202901.1654-1-zwisler@google.com>
On 22-10-18, 14:29, Ross Zwisler wrote:
> From: Ricky Liang <jcliang@chromium.org>
>
> Add thermal logs in devfreq_cooling and cpu_cooling.
Why should we add them ?
> Also add logging to
> power_allocator when it starts to control power.
>
> These changes can lead to excessive log spam when running up against
> thermal limits, so have this logging ratelimited to allow only 1 log each
> 30 seconds from each of those subsystems.
What's the use of these logs when we are going to print them only once every 30
seconds ?
I recently extended thermal sysfs support to share more stats.
commit 8ea229511e06 ("thermal: Add cooling device's statistics in sysfs")
Will that be helpful in your case ?
Otherwise we should probably add trace points instead.
--
viresh
next prev parent reply other threads:[~2018-10-24 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 20:29 [PATCH] thermal: add ratelimited thermal and power logging Ross Zwisler
2018-10-24 7:22 ` Viresh Kumar [this message]
2018-10-29 13:21 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024072227.achkbix2ndef2ule@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=jcliang@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=smbarber@chromium.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox