From: Baoquan He <bhe@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-pm@vger.kernel.org, pv-drivers@vmware.com,
linux-doc@vger.kernel.org, kexec-ml <kexec@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Kazuhito Hagio <k-hagio@ab.jp.nec.com>,
Borislav Petkov <bp@alien8.de>,
devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org,
xen-devel@lists.xenproject.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Young <dyoung@redhat.com>, Omar Sandoval <osandov@fb.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Lianbo Jiang <lijiang@redhat.com>
Subject: Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO
Date: Wed, 21 Nov 2018 14:04:58 +0800 [thread overview]
Message-ID: <20181121060458.GC7386@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20181119101616.8901-4-david@redhat.com>
On 11/19/18 at 11:16am, David Hildenbrand wrote:
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 933cb3e45b98..093c9f917ed0 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -464,6 +464,8 @@ static int __init crash_save_vmcoreinfo_init(void)
> VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
> #ifdef CONFIG_HUGETLB_PAGE
> VMCOREINFO_NUMBER(HUGETLB_PAGE_DTOR);
> +#define PAGE_OFFLINE_MAPCOUNT_VALUE (~PG_offline)
> + VMCOREINFO_NUMBER(PAGE_OFFLINE_MAPCOUNT_VALUE);
> #endif
This solution looks good to me. One small concern is why we don't
export PG_offline to vmcoreinfo directly, then define
PAGE_OFFLINE_MAPCOUNT_VALUE in makedumpfile. We have been exporting
kernel data/MACRO directly, why this one is exceptional.
Thanks
Baoquan
next prev parent reply other threads:[~2018-11-21 6:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:16 [PATCH v1 0/8] mm/kdump: allow to exclude pages that are logically offline David Hildenbrand
2018-11-19 10:16 ` [PATCH v1 1/8] mm: balloon: update comment about isolation/migration/compaction David Hildenbrand
2018-11-21 1:56 ` Michael S. Tsirkin
2018-11-19 10:16 ` [PATCH v1 2/8] mm: convert PG_balloon to PG_offline David Hildenbrand
2018-11-19 11:56 ` Konstantin Khlebnikov
2018-11-19 16:06 ` David Hildenbrand
2018-11-21 1:58 ` Michael S. Tsirkin
2018-11-21 2:44 ` Pankaj Gupta
2018-11-19 10:16 ` [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO David Hildenbrand
2018-11-21 1:59 ` Michael S. Tsirkin
2018-11-21 2:58 ` Dave Young
2018-11-21 6:04 ` Baoquan He [this message]
2018-11-21 8:50 ` David Hildenbrand
2018-11-19 10:16 ` [PATCH v1 4/8] xen/balloon: mark inflated pages PG_offline David Hildenbrand
2018-11-19 12:22 ` Juergen Gross
2018-11-19 13:07 ` David Hildenbrand
2018-11-19 10:16 ` [PATCH v1 5/8] hv_balloon: " David Hildenbrand
2018-11-20 8:45 ` Pankaj Gupta
2018-11-20 8:49 ` David Hildenbrand
2018-11-20 9:37 ` Pankaj Gupta
2018-11-21 1:04 ` Pankaj Gupta
2018-11-19 10:16 ` [PATCH v1 6/8] vmw_balloon: " David Hildenbrand
2018-11-21 3:22 ` Nadav Amit
2018-11-21 8:54 ` David Hildenbrand
2018-11-19 10:16 ` [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page() David Hildenbrand
2018-11-19 12:13 ` Michal Hocko
2018-11-19 13:16 ` Pavel Machek
2018-11-20 21:23 ` Rafael J. Wysocki
2018-11-19 10:16 ` [PATCH v1 8/8] PM / Hibernate: exclude all PageOffline() pages David Hildenbrand
2018-11-20 21:22 ` Rafael J. Wysocki
2018-11-21 11:35 ` William Kucharski
2018-11-21 12:21 ` David Hildenbrand
2018-11-19 10:18 ` [PATCH v1] makedumpfile: exclude pages that are logically offline David Hildenbrand
[not found] ` <20181119101835.9140-1-david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-21 14:58 ` Kazuhito Hagio
2018-11-21 15:35 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121060458.GC7386@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=david@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=dyoung@redhat.com \
--cc=k-hagio@ab.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=lijiang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=osandov@fb.com \
--cc=pv-drivers@vmware.com \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).