* [PATCH] power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro
@ 2018-11-22 14:25 Yangtao Li
2018-12-26 16:03 ` Frank Lee
2019-01-20 21:23 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2018-11-22 14:25 UTC (permalink / raw)
To: sre, hdegoede, wens; +Cc: linux-pm, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/power/supply/axp288_fuel_gauge.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index 084c8ba9749d..9ff2461820d8 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -307,22 +307,12 @@ static int fuel_gauge_debug_show(struct seq_file *s, void *data)
return 0;
}
-static int debug_open(struct inode *inode, struct file *file)
-{
- return single_open(file, fuel_gauge_debug_show, inode->i_private);
-}
-
-static const struct file_operations fg_debug_fops = {
- .open = debug_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(fuel_gauge_debug);
static void fuel_gauge_create_debugfs(struct axp288_fg_info *info)
{
info->debug_file = debugfs_create_file("fuelgauge", 0666, NULL,
- info, &fg_debug_fops);
+ info, &fuel_gauge_debug_fops);
}
static void fuel_gauge_remove_debugfs(struct axp288_fg_info *info)
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-22 14:25 [PATCH] power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
@ 2018-12-26 16:03 ` Frank Lee
2019-01-20 21:23 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Frank Lee @ 2018-12-26 16:03 UTC (permalink / raw)
To: sre, hdegoede, Chen-Yu Tsai; +Cc: Linux PM, Linux Kernel Mailing List
ping...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-22 14:25 [PATCH] power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-12-26 16:03 ` Frank Lee
@ 2019-01-20 21:23 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2019-01-20 21:23 UTC (permalink / raw)
To: Yangtao Li; +Cc: hdegoede, wens, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
Hi,
On Thu, Nov 22, 2018 at 09:25:51AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
Thanks, queued to power-supply-next. Sorry for the delay, I missed
this when I collected patches for the 5.0 kernel.
-- Sebastian
> drivers/power/supply/axp288_fuel_gauge.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 084c8ba9749d..9ff2461820d8 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -307,22 +307,12 @@ static int fuel_gauge_debug_show(struct seq_file *s, void *data)
> return 0;
> }
>
> -static int debug_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, fuel_gauge_debug_show, inode->i_private);
> -}
> -
> -static const struct file_operations fg_debug_fops = {
> - .open = debug_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(fuel_gauge_debug);
>
> static void fuel_gauge_create_debugfs(struct axp288_fg_info *info)
> {
> info->debug_file = debugfs_create_file("fuelgauge", 0666, NULL,
> - info, &fg_debug_fops);
> + info, &fuel_gauge_debug_fops);
> }
>
> static void fuel_gauge_remove_debugfs(struct axp288_fg_info *info)
> --
> 2.17.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-20 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-22 14:25 [PATCH] power: supply: axp288_fuel_gauge: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-12-26 16:03 ` Frank Lee
2019-01-20 21:23 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).