Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1

Eduardo Valentin
2019-01-02T00:51:25Z

On Tue, Jan 01, 2019 at 03:32:50PM -0800, Linus Torvalds wrote:
> On Tue, Jan 1, 2019 at 3:16 PM Eduardo Valentin <edubezval@gmail.com> wrote:
> >
> > > It doesn't even build cleanly.
> > >
> >
> > Do you still have have a copy of the build error?
>
> A plain "make allmodconfig" shows a warning.

I see. I am afraid I really did not catch this. I supposed you are
referring to the warning like this:

thermal_hwmon.h:29:1: warning: ‘thermal_remove_hwmon_sysfs’ defined but not used [-Wunused-function]

I am sending out a patch for this on thermal_hwmon.h and will be resending the pull request
once the CIs report back.

>
> And I refuse to add new warnings.

Fair enough. I would not expect anything different. Thanks for reporting.

>
> Linus