* [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
1 sibling, 1 reply; 5+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Need CONFIG_PCI to be set in order to be able to use
this driver.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..fba1976d5f8d 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -31,7 +31,7 @@ if INT340X_THERMAL
config INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends on ACPI_VIDEO
+ depends on ACPI_VIDEO && PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v6 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
1 sibling, 0 replies; 5+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. IOSF_CORE depends on PCI. For this reason, add a
direct dependency on CONFIG_PCI.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index fba1976d5f8d..2acddf8fb314 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit Sinan Kaya
@ 2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-08 11:58 ` Zhang Rui
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 11:19 UTC (permalink / raw)
To: Sinan Kaya, Zhang Rui
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. Need CONFIG_PCI to be set in order to be able to use
> this driver.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
> index 0582bd12a239..fba1976d5f8d 100644
> --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> @@ -31,7 +31,7 @@ if INT340X_THERMAL
>
> config INT3406_THERMAL
> tristate "ACPI INT3406 display thermal driver"
> - depends on ACPI_VIDEO
> + depends on ACPI_VIDEO && PCI
> help
> The display thermal device represents the LED/LCD display panel
> that may or may not include touch support. The main function of
> --
Rui, any objections here? And for the [11/11]?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
2019-01-07 11:19 ` Rafael J. Wysocki
@ 2019-01-08 11:58 ` Zhang Rui
2019-01-08 13:03 ` Sinan Kaya
0 siblings, 1 reply; 5+ messages in thread
From: Zhang Rui @ 2019-01-08 11:58 UTC (permalink / raw)
To: Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
On 一, 2019-01-07 at 12:19 +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> >
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built
> > without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. Need CONFIG_PCI to be set in order to be able
> > to use
> > this driver.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
> > b/drivers/thermal/intel/int340x_thermal/Kconfig
> > index 0582bd12a239..fba1976d5f8d 100644
> > --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> > +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> > @@ -31,7 +31,7 @@ if INT340X_THERMAL
> >
> > config INT3406_THERMAL
> > tristate "ACPI INT3406 display thermal driver"
> > - depends on ACPI_VIDEO
> > + depends on ACPI_VIDEO && PCI
> > help
> > The display thermal device represents the LED/LCD display
> > panel
> > that may or may not include touch support. The main
> > function of
> > --
> Rui, any objections here? And for the [11/11]?
CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch
11 is sufficient.
thanks,
rui
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
2019-01-08 11:58 ` Zhang Rui
@ 2019-01-08 13:03 ` Sinan Kaya
0 siblings, 0 replies; 5+ messages in thread
From: Sinan Kaya @ 2019-01-08 13:03 UTC (permalink / raw)
To: Zhang Rui
Cc: Rafael J. Wysocki, Linux-Next Mailing List,
ACPI Devel Maling List, Eduardo Valentin, Daniel Lezcano,
Amit Kucheria, open list:THERMAL, open list
On Tue, Jan 8, 2019 at 6:58 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> On 一, 2019-01-07 at 12:19 +0100, Rafael J. Wysocki wrote:
> > On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> > >
> > >
> > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built
> > > without
> > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > > specified directly. Need CONFIG_PCI to be set in order to be able
> > > to use
> > > this driver.
> > >
> > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
> > > CONFIG_PCI set")
> > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > > ---
> > > drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
> > > b/drivers/thermal/intel/int340x_thermal/Kconfig
> > > index 0582bd12a239..fba1976d5f8d 100644
> > > --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> > > +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> > > @@ -31,7 +31,7 @@ if INT340X_THERMAL
> > >
> > > config INT3406_THERMAL
> > > tristate "ACPI INT3406 display thermal driver"
> > > - depends on ACPI_VIDEO
> > > + depends on ACPI_VIDEO && PCI
> > > help
> > > The display thermal device represents the LED/LCD display
> > > panel
> > > that may or may not include touch support. The main
> > > function of
> > > --
> > Rui, any objections here? And for the [11/11]?
>
> CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch
> 11 is sufficient.
Yes, we can drop this patch. I found the issues in reverse order. Can
we get an ACK for 11/11?
>
> thanks,
> rui
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-08 13:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit Sinan Kaya
2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-08 11:58 ` Zhang Rui
2019-01-08 13:03 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).