From: Tony Lindgren <tony@atomide.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org
Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers
Date: Tue, 8 Jan 2019 17:51:24 -0800 [thread overview]
Message-ID: <20190109015124.GO5544@atomide.com> (raw)
In-Reply-To: <20190109014218.GA8363@linaro.org>
* Vincent Guittot <vincent.guittot@linaro.org> [190109 01:42]:
> Le Tuesday 08 Jan 2019 à 13:37:43 (-0800), Tony Lindgren a écrit :
> > Lowering the autosuspend_delay_ms to 2100 ms makes things work again.
> > Anything higher than 2200 ms seems to somehow time out immediately
> > now :)
>
> This is quite close to the max ns of an int on arm 32bits
>
> Could you try the patch below ?
Yup great thanks, that's it:
Tested-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/base/power/runtime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 7062469..44c5c76 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -141,7 +141,7 @@ u64 pm_runtime_autosuspend_expiration(struct device *dev)
>
> last_busy = READ_ONCE(dev->power.last_busy);
>
> - expires = last_busy + autosuspend_delay * NSEC_PER_MSEC;
> + expires = last_busy + (u64)(autosuspend_delay) * NSEC_PER_MSEC;
> if (expires <= now)
> expires = 0; /* Already expired. */
>
> --
> 2.7.4
>
>
> >
> > Regards,
> >
> > Tony
next prev parent reply other threads:[~2019-01-09 1:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:38 Regression in v5.0-rc1 with autosuspend hrtimers Tony Lindgren
2019-01-08 7:59 ` Vincent Guittot
2019-01-08 15:53 ` Tony Lindgren
2019-01-08 16:42 ` Vincent Guittot
2019-01-08 21:37 ` Tony Lindgren
2019-01-09 1:42 ` Vincent Guittot
2019-01-09 1:51 ` Tony Lindgren [this message]
2019-01-09 9:43 ` Rafael J. Wysocki
2019-01-09 16:28 ` Tony Lindgren
2019-01-09 16:48 ` Vincent Guittot
2019-01-09 16:50 ` Tony Lindgren
2019-01-09 16:55 ` Vincent Guittot
2019-01-09 17:02 ` Tony Lindgren
2019-01-09 11:17 ` Ladislav Michl
2019-01-09 11:27 ` Vincent Guittot
[not found] ` <20190109115824.GA1353@lenoch>
2019-01-09 13:24 ` Vincent Guittot
[not found] ` <20190109133337.GA13579@lenoch>
2019-01-09 14:12 ` Vincent Guittot
2019-01-09 16:07 ` Ladislav Michl
2019-01-09 16:32 ` Vincent Guittot
2019-01-09 17:26 ` Ladislav Michl
2019-01-09 18:04 ` Vincent Guittot
2019-01-09 22:06 ` Rafael J. Wysocki
2019-01-10 7:45 ` Ladislav Michl
2019-01-10 7:50 ` Vincent Guittot
2019-01-10 7:54 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109015124.GO5544@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).