From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path Date: Wed, 9 Jan 2019 10:59:45 +0000 Message-ID: <20190109105945.GA18034@e107155-lin> References: <20190109104236.6532-1-quentin.perret@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190109104236.6532-1-quentin.perret@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Quentin Perret Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, qais.yousef@arm.com List-Id: linux-pm@vger.kernel.org On Wed, Jan 09, 2019 at 10:42:36AM +0000, Quentin Perret wrote: > The scmi-cpufreq driver calls the arch_set_freq_scale() callback on > frequency changes to provide scale-invariant load-tracking signals to > the scheduler. However, in the slow path, it does so while specifying > the current and max frequencies in different units, hence resulting in a > broken freq_scale factor. > > Fix this by passing all frequencies in KHz, as stored in the CPUFreq > frequency table. > > Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI > message protocol") Good find. Acked-by: Sudeep Holla -- Regards, Sudeep