From: Ladislav Michl <ladis@linux-mips.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Tony Lindgren <tony@atomide.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers
Date: Thu, 10 Jan 2019 08:54:44 +0100 [thread overview]
Message-ID: <20190110075444.GA26920@lenoch> (raw)
In-Reply-To: <CAKfTPtA53BS0MTW7SaiC7B+KsGmWCiUJW+PzT57CUN5YpGN5vA@mail.gmail.com>
On Thu, Jan 10, 2019 at 08:50:14AM +0100, Vincent Guittot wrote:
> On Thu, 10 Jan 2019 at 08:46, Ladislav Michl <ladis@linux-mips.org> wrote:
> >
> > On Wed, Jan 09, 2019 at 11:06:34PM +0100, Rafael J. Wysocki wrote:
> > > On Wed, Jan 9, 2019 at 7:05 PM Vincent Guittot
> > > <vincent.guittot@linaro.org> wrote:
> > > >
> > > > On Wed, 9 Jan 2019 at 18:26, Ladislav Michl <ladis@linux-mips.org> wrote:
> > > > >
> > > > > On Wed, Jan 09, 2019 at 05:32:31PM +0100, Vincent Guittot wrote:
> > > > > > On Wed, 9 Jan 2019 at 17:07, Ladislav Michl <ladis@linux-mips.org> wrote:
> > > > > > >
> > > > > > > On Wed, Jan 09, 2019 at 03:12:25PM +0100, Vincent Guittot wrote:
> > > > > > > > Please keep all thread list when replying :-)
> > > > > > >
> > > > > > > Ahh, sorry for that...
> > > > > > > [snip]
> > > > > > > > On Wed, 9 Jan 2019 at 14:33, Ladislav Michl <ladis@linux-mips.org> wrote:
> > > > > > > > > I agree, but it doea all the magic correctly, so you won't need
> > > > > > > > > to touch that code is ktime_t changes (I know, unlikely..)
> > > > > > > >
> > > > > > > > But the current implementation doesn't care of any changes in ktime_t
> > > > > > > > as it uses raw ns
> > > > > > >
> > > > > > > Fair enough, so let's go back to:
> > > > > >
> > > > > > This one looks good for me
> > > > >
> > > > > Lets split is for 'comments fix' patch, which was just send and 'the rest'.
> > > > > Now, 'the rest' can either be v2 of your "PM/runtime: Fix autosuspend_delay on
> > > > > 32bits arch" or will wait for 5.1. You decide :)
> > > >
> > > > I don't really mind.
> > > >
> > > > Rafael,
> > > > Do you prefer to only take the fix for u64 casting problem or do you
> > > > prefer to also take the optimization below in one single patch ?
> > >
> > > The casting problem is a bug and the optimization is next release
> > > material in my view. Please send the optimization separately.
> >
> > Ok, will send that separately in a few moments...
> > Btw, u64 casting problem seems to be still present in rpm_suspend while
> > computing slack for autosuspend delay greater than 25% of 2^31 (2^33) ns.
>
> Good point. I will add it to the fix as well
Another nit then, for (u64)(autosuspend_delay) is (u64)autosuspend_delay
enough :)
I'll wait for your v2 before sending optimization patch.
> > Not sure if that triggers any real bug.
prev parent reply other threads:[~2019-01-10 7:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:38 Regression in v5.0-rc1 with autosuspend hrtimers Tony Lindgren
2019-01-08 7:59 ` Vincent Guittot
2019-01-08 15:53 ` Tony Lindgren
2019-01-08 16:42 ` Vincent Guittot
2019-01-08 21:37 ` Tony Lindgren
2019-01-09 1:42 ` Vincent Guittot
2019-01-09 1:51 ` Tony Lindgren
2019-01-09 9:43 ` Rafael J. Wysocki
2019-01-09 16:28 ` Tony Lindgren
2019-01-09 16:48 ` Vincent Guittot
2019-01-09 16:50 ` Tony Lindgren
2019-01-09 16:55 ` Vincent Guittot
2019-01-09 17:02 ` Tony Lindgren
2019-01-09 11:17 ` Ladislav Michl
2019-01-09 11:27 ` Vincent Guittot
[not found] ` <20190109115824.GA1353@lenoch>
2019-01-09 13:24 ` Vincent Guittot
[not found] ` <20190109133337.GA13579@lenoch>
2019-01-09 14:12 ` Vincent Guittot
2019-01-09 16:07 ` Ladislav Michl
2019-01-09 16:32 ` Vincent Guittot
2019-01-09 17:26 ` Ladislav Michl
2019-01-09 18:04 ` Vincent Guittot
2019-01-09 22:06 ` Rafael J. Wysocki
2019-01-10 7:45 ` Ladislav Michl
2019-01-10 7:50 ` Vincent Guittot
2019-01-10 7:54 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110075444.GA26920@lenoch \
--to=ladis@linux-mips.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).