From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v4] cpufreq: s5pv210: Defer probe if getting regulators fail Date: Fri, 18 Jan 2019 10:40:10 +0530 Message-ID: <20190118051010.4ed2ntv2mxfeaoot@vireshk-i7> References: <20190113195754.30525-1-pawel.mikolaj.chmiel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: =?utf-8?B?UGF3ZcWC?= Chmiel , kgene@kernel.org, rjw@rjwysocki.net, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On 14-01-19, 08:51, Krzysztof Kozlowski wrote: > On Sun, 13 Jan 2019 at 20:58, Paweł Chmiel > wrote: > > > > There is possibility, that when probing driver, regulators are not yet > > initialized. In this case we should return EPROBE_DEFER and wait till > > they're initialized, since they're required currently for cpufreq driver > > to work. Also move regulator initialization code at beginning of probe, > > so we can defer as fast as posibble. > > > > Signed-off-by: Paweł Chmiel > > --- > > Changes from v3: > > - Zero dmc_base pointers after unmapping them > > - If getting vddarm regulator fails just return, no need to do goto > > jump which would do the same > > > > Changes from v2: > > - Handle all error paths in probe > > > > Changes from v1: > > - Fix compilation error > > - Reorganize code so it's smaller > > Reviewed-by: Krzysztof Kozlowski Applied, thanks. -- viresh