Re: [PATCH v7 03/28] x86/asm/suspend: use SYM_DATA for data

Jiri Slaby
2019-02-05T07:34:09Z

On 04. 02. 19, 21:18, Borislav Petkov wrote:
>> --- a/arch/x86/kernel/acpi/wakeup_64.S
>> +++ b/arch/x86/kernel/acpi/wakeup_64.S
>> @@ -133,4 +133,4 @@ saved_rbx: .quad 0
>> saved_rip: .quad 0
>> saved_rsp: .quad 0
>>
>> -ENTRY(saved_magic) .quad 0
>> +SYM_DATA(saved_magic, .quad 0)
>
> Ok, I like the proper ELF symbol typing with this: NOTYPE goes away.
>
> 74408: ffffffff82021920 0 NOTYPE GLOBAL DEFAULT 11 saved_magic
>
> ->
>
> 74366: ffffffff820218f0 8 OBJECT GLOBAL DEFAULT 11 saved_magic

I also suggest noticing the size 0 -> 8 change ;).

thanks,
--
js
suse labs