From: Sudeep Holla <sudeep.holla@arm.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Jisheng Zhang <jszhang@marvell.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Joshua Frkuska <joshua_frkuska@mentor.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH] drivers: base: add support to skip power management in device/driver model
Date: Thu, 7 Feb 2019 15:06:38 +0000 [thread overview]
Message-ID: <20190207150638.GB14464@e107155-lin> (raw)
In-Reply-To: <CAPDyKFpkiaP0J_LJxP6tRUOyz3QKtDgA+PuhL-9vew7-RfKyNA@mail.gmail.com>
On Thu, Feb 07, 2019 at 03:29:07PM +0100, Ulf Hansson wrote:
> On Thu, 7 Feb 2019 at 11:36, Sudeep Holla <sudeep.holla@arm.com> wrote:
[..]
> >
> > May be, but as mentioned above we can't really. Also this change will
> > help to avoid creating unnecessary power sysfs which is mainly runtime
> > pm related for some of the devices created. CPU/caches was just one
> > example which triggered this, but this can be more useful. We can avoid
> > adding them to dpm list.
>
> Well, to me the approach you suggest sounds prone to errors and I am
> afraid people may abuse it. Moreover, I don't know if there is other
> problems with it, let's see what Rafael thinks about it.
>
Sorry, I should have put reference to earlier discussion that led to this
patch. For your reference: [1]
> Instead I think we should make the PM core to deal with this scenario,
> as all it boils down to, is to allow a device to be unregistered and
> registered during system suspend/resume, with a parent device that is
> "persistent" during the sequence.
>
OK
> Perhaps we could even just drop the corresponding printed warning,
> "cache: parent cpu1 should not be sleeping", in device_pm_add() as I
> wonder if it's really a necessary print.
>
Indeed, I was ignoring knowing that it's harmless. But more people
started to complain, and Rafael suggested this which I agree as we
have several pseudo devices created in the kernel that we can bypass
some of these pm handling knowing we won't need it.
--
Regards,
Sudeep
[1] https://lkml.org/lkml/2019/1/30/1078
next prev parent reply other threads:[~2019-02-07 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 15:09 [PATCH] drivers: base: add support to skip power management in device/driver model Sudeep Holla
2019-02-06 15:41 ` Sudeep Holla
2019-02-07 9:53 ` Ulf Hansson
2019-02-07 10:36 ` Sudeep Holla
2019-02-07 14:29 ` Ulf Hansson
2019-02-07 15:06 ` Sudeep Holla [this message]
2019-02-07 15:18 ` Ulf Hansson
2019-02-07 15:29 ` Sudeep Holla
2019-02-11 16:20 ` Ulf Hansson
2019-02-12 17:49 ` Sudeep Holla
2019-02-12 18:07 ` Rafael J. Wysocki
2019-02-12 18:20 ` Sudeep Holla
2019-02-12 18:59 ` Rafael J. Wysocki
2019-02-15 8:21 ` [LKP] [drivers] a0c863ed70: WARNING:at_fs/sysfs/group.c:#sysfs_remove_group kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207150638.GB14464@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=erosca@de.adit-jv.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshua_frkuska@mentor.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=slongerbeam@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox