Re: [RFC 1/6] mfd: Support for Ettus Research E31x devices PMU

Lee Jones
2019-02-14T09:23:10Z

On Mon, 11 Feb 2019, Virendra Kakade wrote:

> Document bindings for E31x device PMU MFD driver.
>
> Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
> ---
> Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/e31x-pmu.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> new file mode 100644
> index 000000000000..ebb5625f6c74
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> @@ -0,0 +1,14 @@
> +Ettus Research/National Instruments E31x PMU MFD driver

Please expand on what PMU is.

MFD is a Linuxisum and has no place in the description.

You can supplement it with "parent device" or some such.

> +Required properties:
> +- compatible : Must be "ni,e31x-pmu"
> +- regmap : Must be <&regmapnode>
> +
> +Example:
> +
> +pmu {
> + compatible = "ni,e31x-pmu";

No address?

> + regmap = <&devctrl>;
> + status = "okay";

Not required in DT documentation.

> +};
> +

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog