From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813 Date: Tue, 2 Apr 2019 04:15:48 +0100 Message-ID: <20190402031548.GF4187@dell> References: <20190321084850.20769-1-wens@kernel.org> <20190321084850.20769-8-wens@kernel.org> Reply-To: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20190321084850.20769-8-wens-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Maxime Ripard , Sebastian Reichel , Quentin Schulz , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Hans de Goede , Chen-Yu Tsai List-Id: linux-pm@vger.kernel.org On Thu, 21 Mar 2019, Chen-Yu Tsai wrote: > From: Quentin Schulz >=20 > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > supports this variant, we can add an mfd cell for it to use it. >=20 > Signed-off-by: Quentin Schulz > [wens-jdAy2FN1RRM@public.gmane.org: add commit message] > Acked-for-MFD-by: Lee Jones > Signed-off-by: Chen-Yu Tsai This patch looks orthogonal. Unless anyone screams, I'm going to apply it. > --- >=20 > Changes since v1: > - Made axp803_usb_power_supply_resources[] constant > - Added Lee's acked-by > --- > drivers/mfd/axp20x.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 3c97f2c0fdfe..902f9f27e748 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply= _resources[] =3D { > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > }; > =20 > +/* AXP803 and AXP813/AXP818 share the same interrupts */ > +static const struct resource axp803_usb_power_supply_resources[] =3D { > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"), > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > +}; > + > static const struct resource axp22x_pek_resources[] =3D { > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_PEK_RIS_EDGE, "PEK_DBR"), > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_PEK_FAL_EDGE, "PEK_DBF"), > @@ -793,6 +799,11 @@ static const struct mfd_cell axp813_cells[] =3D { > .of_compatible =3D "x-powers,axp813-ac-power-supply", > .num_resources =3D ARRAY_SIZE(axp20x_ac_power_supply_resources), > .resources =3D axp20x_ac_power_supply_resources, > + }, { > + .name =3D "axp20x-usb-power-supply", > + .num_resources =3D ARRAY_SIZE(axp803_usb_power_supply_resources), > + .resources =3D axp803_usb_power_supply_resources, > + .of_compatible =3D "x-powers,axp813-usb-power-supply", > }, > }; > =20 --=20 Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] Linaro Services Technical Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.