From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings Date: Sat, 20 Apr 2019 12:30:16 +0800 Message-ID: <20190420043016.GA4464@lkp-kbuild13> References: <20190418233838.149545-1-ncrews@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190418233838.149545-1-ncrews@chromium.org> Sender: linux-kernel-owner@vger.kernel.org Cc: kbuild-all@01.org, bleung@chromium.org, sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dlaurie@chromium.org, lamzin@google.com, bartfab@google.com, derat@google.com, dtor@google.com, sjg@chromium.org, jchwong@chromium.org, Nick Crews List-Id: linux-pm@vger.kernel.org From: kbuild test robot drivers/power/supply/wilco-charger.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 2600e89ec94e ("power_supply: platform/chrome: wilco_ec: Add charging config driver") CC: Nick Crews Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-platform-chrome-wilco_ec-Add-charging-config-driver/20190420-041913 wilco-charger.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/power/supply/wilco-charger.c +++ b/drivers/power/supply/wilco-charger.c @@ -170,10 +170,7 @@ static int wilco_charge_probe(struct pla psy_cfg.drv_data = ec; psy = devm_power_supply_register(&pdev->dev, &wilco_ps_desc, &psy_cfg); - if (IS_ERR(psy)) - return PTR_ERR(psy); - - return 0; + return PTR_ERR_OR_ZERO(psy); } static struct platform_driver wilco_charge_driver = { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DC3C282DD for ; Sat, 20 Apr 2019 04:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E25A2208C0 for ; Sat, 20 Apr 2019 04:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbfDTEak (ORCPT ); Sat, 20 Apr 2019 00:30:40 -0400 Received: from mga12.intel.com ([192.55.52.136]:31804 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfDTEak (ORCPT ); Sat, 20 Apr 2019 00:30:40 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2019 21:30:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,372,1549958400"; d="scan'208";a="144361617" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 19 Apr 2019 21:30:38 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1hHhe9-000H68-Hg; Sat, 20 Apr 2019 12:30:37 +0800 Date: Sat, 20 Apr 2019 12:30:16 +0800 From: kbuild test robot To: Nick Crews Cc: kbuild-all@01.org, bleung@chromium.org, sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dlaurie@chromium.org, lamzin@google.com, bartfab@google.com, derat@google.com, dtor@google.com, sjg@chromium.org, jchwong@chromium.org, Nick Crews Subject: [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings Message-ID: <20190420043016.GA4464@lkp-kbuild13> References: <20190418233838.149545-1-ncrews@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190418233838.149545-1-ncrews@chromium.org> X-Patchwork-Hint: ignore User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190420043016.bUX9JgXjAC2LrM-gsPHVYr5GK1uj63IbEAW0Y35FY4c@z> From: kbuild test robot drivers/power/supply/wilco-charger.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 2600e89ec94e ("power_supply: platform/chrome: wilco_ec: Add charging config driver") CC: Nick Crews Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-platform-chrome-wilco_ec-Add-charging-config-driver/20190420-041913 wilco-charger.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/power/supply/wilco-charger.c +++ b/drivers/power/supply/wilco-charger.c @@ -170,10 +170,7 @@ static int wilco_charge_probe(struct pla psy_cfg.drv_data = ec; psy = devm_power_supply_register(&pdev->dev, &wilco_ps_desc, &psy_cfg); - if (IS_ERR(psy)) - return PTR_ERR(psy); - - return 0; + return PTR_ERR_OR_ZERO(psy); } static struct platform_driver wilco_charge_driver = {