From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization Date: Tue, 23 Apr 2019 12:01:07 +0200 Message-ID: <20190423100107.p3p3jmvv6dph6uy6@verge.net.au> References: <20190411100352.15977-1-jiada_wang@mentor.com> <20190416174741.GA26470@vmlxhi-102.adit-jv.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190416174741.GA26470@vmlxhi-102.adit-jv.com> Sender: linux-kernel-owner@vger.kernel.org To: Eugeniu Rosca Cc: Jiada Wang , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Eduardo Valentin , Niklas =?utf-8?Q?S=C3=B6derlund?= , Geert Uytterhoeven , Sergei Shtylyov , Marek Vasut , Kuninori Morimoto , Hien Dang , Fabrizio Castro , Dien Pham , Daniel Lezcano , Biju Das , "George G. Davis" , Joshua Frkuska , Eugeniu Rosca List-Id: linux-pm@vger.kernel.org On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > Hi Jiada, > > Adding below people, since they've made recent contributions to the > driver and might be interested in your patch: > > git log master --since="1 year" -- drivers/thermal/rcar_gen3_thermal.c \ > | grep -o "\-by:.*" | sed 's/\-by: //' | sort | uniq -c | sort -rn > 7 Eduardo Valentin > 6 Simon Horman > 5 Niklas Söderlund > 2 Geert Uytterhoeven > 1 Sergei Shtylyov > 1 Marek Vasut > 1 Kuninori Morimoto > 1 Hien Dang > 1 Fabrizio Castro > 1 Dien Pham > 1 Daniel Lezcano > 1 Biju Das > > I confirm that loading and unloading the rcar3 thermal driver in a > loop produces soft lockup using v5.1-rc5-10-g618d919cae2f on > H3-ES2.0-Salvator-X. > > Full log and .config can be found here: > https://gist.github.com/erosca/1f76b6dd897cdc39581fca475155e363 > > I post an excerpt from the above [1] (why not including it in the > description?). Also, why not rephrasing the commit summary line in such > a way that everybody understands this patch fixes a severe issue, e.g. > "thermal: rcar_gen3_thermal: Fix soft lockup on probe" ? > > BTW, with this patch applied I left the thermal driver being > loaded/unloaded on the target for over one hour w/o seeing the issue > reproduced. So, while there might be slight variations in how the final > solution looks like, I think the patch already deserves a: > > Tested-by: Eugeniu Rosca > > [1] Soft lockup reproduced with v5.1-rc5-10-g618d919cae2f Thanks, Unfortunately I do not see the patch in my inbox. Would you care to repost it including the following recipients. linux-pm@vger.kernel.org Zhang Rui Eduardo Valentin linux-renesas-soc@vger.kernel.org Niklas Söderlund Feel free to include the suggestions made by Eugeniu above and post a v2. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482AEC10F14 for ; Tue, 23 Apr 2019 10:01:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2164B206A3 for ; Tue, 23 Apr 2019 10:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727275AbfDWKBM (ORCPT ); Tue, 23 Apr 2019 06:01:12 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:44974 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbfDWKBM (ORCPT ); Tue, 23 Apr 2019 06:01:12 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id AE5B025AE8B; Tue, 23 Apr 2019 20:01:09 +1000 (AEST) Received: by reginn.horms.nl (Postfix, from userid 7100) id 5AEA99403E4; Tue, 23 Apr 2019 12:01:07 +0200 (CEST) Date: Tue, 23 Apr 2019 12:01:07 +0200 From: Simon Horman To: Eugeniu Rosca Cc: Jiada Wang , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Eduardo Valentin , Niklas =?utf-8?Q?S=C3=B6derlund?= , Geert Uytterhoeven , Sergei Shtylyov , Marek Vasut , Kuninori Morimoto , Hien Dang , Fabrizio Castro , Dien Pham , Daniel Lezcano , Biju Das , "George G. Davis" , Joshua Frkuska , Eugeniu Rosca Subject: Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization Message-ID: <20190423100107.p3p3jmvv6dph6uy6@verge.net.au> References: <20190411100352.15977-1-jiada_wang@mentor.com> <20190416174741.GA26470@vmlxhi-102.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190416174741.GA26470@vmlxhi-102.adit-jv.com> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190423100107.L8QyNLr20T9tOrZ0Us3u7vpKXtrWH6g5lNlt5pcSUNQ@z> On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > Hi Jiada, > > Adding below people, since they've made recent contributions to the > driver and might be interested in your patch: > > git log master --since="1 year" -- drivers/thermal/rcar_gen3_thermal.c \ > | grep -o "\-by:.*" | sed 's/\-by: //' | sort | uniq -c | sort -rn > 7 Eduardo Valentin > 6 Simon Horman > 5 Niklas Söderlund > 2 Geert Uytterhoeven > 1 Sergei Shtylyov > 1 Marek Vasut > 1 Kuninori Morimoto > 1 Hien Dang > 1 Fabrizio Castro > 1 Dien Pham > 1 Daniel Lezcano > 1 Biju Das > > I confirm that loading and unloading the rcar3 thermal driver in a > loop produces soft lockup using v5.1-rc5-10-g618d919cae2f on > H3-ES2.0-Salvator-X. > > Full log and .config can be found here: > https://gist.github.com/erosca/1f76b6dd897cdc39581fca475155e363 > > I post an excerpt from the above [1] (why not including it in the > description?). Also, why not rephrasing the commit summary line in such > a way that everybody understands this patch fixes a severe issue, e.g. > "thermal: rcar_gen3_thermal: Fix soft lockup on probe" ? > > BTW, with this patch applied I left the thermal driver being > loaded/unloaded on the target for over one hour w/o seeing the issue > reproduced. So, while there might be slight variations in how the final > solution looks like, I think the patch already deserves a: > > Tested-by: Eugeniu Rosca > > [1] Soft lockup reproduced with v5.1-rc5-10-g618d919cae2f Thanks, Unfortunately I do not see the patch in my inbox. Would you care to repost it including the following recipients. linux-pm@vger.kernel.org Zhang Rui Eduardo Valentin linux-renesas-soc@vger.kernel.org Niklas Söderlund Feel free to include the suggestions made by Eugeniu above and post a v2.