From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniu Rosca Subject: Re: [PATCH v2 1/2] thermal: rcar_gen3_thermal: fix interrupt type Date: Tue, 23 Apr 2019 15:07:24 +0200 Message-ID: <20190423130724.GA10913@vmlxhi-102.adit-jv.com> References: <20190423061218.29705-2-jiada_wang@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20190423061218.29705-2-jiada_wang@mentor.com> Sender: linux-kernel-owner@vger.kernel.org To: Jiada Wang Cc: rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, joshua_frkuska@mentor.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be, sergei.shtylyov@cogentembedded.com, marek.vasut+renesas@gmail.com, kuninori.morimoto.gx@renesas.com, hien.dang.eb@renesas.com, fabrizio.castro@bp.renesas.com, dien.pham.ry@renesas.com, biju.das@bp.renesas.com, Eugeniu Rosca , Eugeniu Rosca List-Id: linux-pm@vger.kernel.org Hi Jiada, On Tue, Apr 23, 2019 at 03:12:17PM +0900, Jiada Wang wrote: > Currently IRQF_SHARED type interrupt line is allocated, but it > is not appropriate, as the interrupt line isn't shared between > different devices, instead IRQF_ONESHOT is the proper type. > > By changing interrupt type to IRQF_ONESHOT, now irq handler is > no longer needed, as clear of interrupt status can be done in > threaded interrupt context. > > Because IRQF_ONESHOT type interrupt line is kept disabled until > the threaded handler has been run, so there is no need to protect > read/write of REG_GEN3_IRQSTR with lock. > > Signed-off-by: Jiada Wang > --- > drivers/thermal/rcar_gen3_thermal.c | 40 ++++++++--------------------- > 1 file changed, 10 insertions(+), 30 deletions(-) > [..] I might be doing something wrong, but I couldn't apply this patch on top of v5.1-rc6-4-g7142eaa58b49. All below commands failed (git v2.21.0): - git am this.patch - git apply this.patch - patch -p1 < this.patch -- Best regards, Eugeniu. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=FAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F17C10F14 for ; Tue, 23 Apr 2019 13:07:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42DC6206A3 for ; Tue, 23 Apr 2019 13:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfDWNHi (ORCPT ); Tue, 23 Apr 2019 09:07:38 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:55613 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726033AbfDWNHi (ORCPT ); Tue, 23 Apr 2019 09:07:38 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id A03EC3C00C1; Tue, 23 Apr 2019 15:07:35 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YNJcIX4shQh3; Tue, 23 Apr 2019 15:07:28 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 452AD3C0034; Tue, 23 Apr 2019 15:07:28 +0200 (CEST) Received: from vmlxhi-102.adit-jv.com (10.72.93.184) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Apr 2019 15:07:27 +0200 Date: Tue, 23 Apr 2019 15:07:24 +0200 From: Eugeniu Rosca To: Jiada Wang CC: , , , , , , , , , , , , , , , , Eugeniu Rosca , Eugeniu Rosca Subject: Re: [PATCH v2 1/2] thermal: rcar_gen3_thermal: fix interrupt type Message-ID: <20190423130724.GA10913@vmlxhi-102.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190423061218.29705-2-jiada_wang@mentor.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.72.93.184] Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190423130724.7kzJjHg5RaCf5qZQuOT3lXF-vcscnhIRLR8PpSW4Gp4@z> Hi Jiada, On Tue, Apr 23, 2019 at 03:12:17PM +0900, Jiada Wang wrote: > Currently IRQF_SHARED type interrupt line is allocated, but it > is not appropriate, as the interrupt line isn't shared between > different devices, instead IRQF_ONESHOT is the proper type. > > By changing interrupt type to IRQF_ONESHOT, now irq handler is > no longer needed, as clear of interrupt status can be done in > threaded interrupt context. > > Because IRQF_ONESHOT type interrupt line is kept disabled until > the threaded handler has been run, so there is no need to protect > read/write of REG_GEN3_IRQSTR with lock. > > Signed-off-by: Jiada Wang > --- > drivers/thermal/rcar_gen3_thermal.c | 40 ++++++++--------------------- > 1 file changed, 10 insertions(+), 30 deletions(-) > [..] I might be doing something wrong, but I couldn't apply this patch on top of v5.1-rc6-4-g7142eaa58b49. All below commands failed (git v2.21.0): - git am this.patch - git apply this.patch - patch -p1 < this.patch -- Best regards, Eugeniu.