From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Date: Thu, 16 May 2019 17:02:52 +0200 Message-ID: <20190516150252.hf4u3bloo37chy6q@flea> References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190512214128.qjyys3vfpwdiacib@core.my.home> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7vj27y3kfhi2ktlo" Return-path: Content-Disposition: inline In-Reply-To: <20190512214128.qjyys3vfpwdiacib@core.my.home> Sender: linux-kernel-owner@vger.kernel.org To: Yangtao Li , mark.rutland@arm.com, daniel.lezcano@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, mchehab+samsung@kernel.org, paulmck@linux.ibm.com, stefan.wahren@i2se.com, linux-pm@vger.kernel.org, wens@csie.org, jagan@amarulasolutions.com, andy.gross@linaro.org, rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, edubezval@gmail.com, enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, olof@lixom.net, davem@davemloft.net List-Id: linux-pm@vger.kernel.org --7vj27y3kfhi2ktlo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, May 12, 2019 at 11:41:28PM +0200, Ond=C5=99ej Jirman wrote: > > > +static int tsens_get_temp(void *data, int *temp) > > > +{ > > > + struct tsensor *s =3D data; > > > + struct tsens_device *tmdev =3D s->tmdev; > > > + int val; > > > + > > > + regmap_read(tmdev->regmap, tmdev->chip->temp_data_base + > > > + 0x4 * s->id, &val); > > > + > > > + if (unlikely(val =3D=3D 0)) > > > + return -EBUSY; > > > > I'm not sure why a val equals to 0 would be associated with EBUSY? > > Thermal zone driver can (will) call get_temp before we got the > first interrupt and the thermal data. In that case val will be 0. > > Resulting in: > > (val + offset) * scale =3D (-2794) * -67 =3D 187198 > > 187=C2=B0C and immediate shutdown during boot - based on cirtical > temperature being reached. > > Busy here means, get_temp does not yet have data. Thermal zone > driver just reports any error to dmesg output. Ah, that makes sense. I guess if we're switching to an interrupt-based driver, then we can just use a waitqueue, or is get_temp supposed to be atomic? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --7vj27y3kfhi2ktlo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXN17nAAKCRDj7w1vZxhR xZVgAQDEhhE/FQspXxx58VLtzI/e0Kz9gZa92QnGGjDbVWxBTwEA1iAzA+XGbDtR 1TM7/Hc1lwDV+qLHJYnbwcFfq+6XBAg= =qzgC -----END PGP SIGNATURE----- --7vj27y3kfhi2ktlo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86859C04AAF for ; Thu, 16 May 2019 15:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 565D62087B for ; Thu, 16 May 2019 15:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbfEPPDE (ORCPT ); Thu, 16 May 2019 11:03:04 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:58399 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbfEPPDE (ORCPT ); Thu, 16 May 2019 11:03:04 -0400 Received: from localhost (unknown [80.215.79.199]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1129E200018; Thu, 16 May 2019 15:02:52 +0000 (UTC) Date: Thu, 16 May 2019 17:02:52 +0200 From: Maxime Ripard To: Yangtao Li , mark.rutland@arm.com, daniel.lezcano@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, mchehab+samsung@kernel.org, paulmck@linux.ibm.com, stefan.wahren@i2se.com, linux-pm@vger.kernel.org, wens@csie.org, jagan@amarulasolutions.com, andy.gross@linaro.org, rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, edubezval@gmail.com, enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, olof@lixom.net, davem@davemloft.net Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Message-ID: <20190516150252.hf4u3bloo37chy6q@flea> References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190512214128.qjyys3vfpwdiacib@core.my.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7vj27y3kfhi2ktlo" Content-Disposition: inline In-Reply-To: <20190512214128.qjyys3vfpwdiacib@core.my.home> User-Agent: NeoMutt/20180716 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190516150252.Hv8GOhgBATJ5Q1zOB6USG8fLlrRabNHdtrNlZPUVGko@z> --7vj27y3kfhi2ktlo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, May 12, 2019 at 11:41:28PM +0200, Ond=C5=99ej Jirman wrote: > > > +static int tsens_get_temp(void *data, int *temp) > > > +{ > > > + struct tsensor *s =3D data; > > > + struct tsens_device *tmdev =3D s->tmdev; > > > + int val; > > > + > > > + regmap_read(tmdev->regmap, tmdev->chip->temp_data_base + > > > + 0x4 * s->id, &val); > > > + > > > + if (unlikely(val =3D=3D 0)) > > > + return -EBUSY; > > > > I'm not sure why a val equals to 0 would be associated with EBUSY? > > Thermal zone driver can (will) call get_temp before we got the > first interrupt and the thermal data. In that case val will be 0. > > Resulting in: > > (val + offset) * scale =3D (-2794) * -67 =3D 187198 > > 187=C2=B0C and immediate shutdown during boot - based on cirtical > temperature being reached. > > Busy here means, get_temp does not yet have data. Thermal zone > driver just reports any error to dmesg output. Ah, that makes sense. I guess if we're switching to an interrupt-based driver, then we can just use a waitqueue, or is get_temp supposed to be atomic? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --7vj27y3kfhi2ktlo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXN17nAAKCRDj7w1vZxhR xZVgAQDEhhE/FQspXxx58VLtzI/e0Kz9gZa92QnGGjDbVWxBTwEA1iAzA+XGbDtR 1TM7/Hc1lwDV+qLHJYnbwcFfq+6XBAg= =qzgC -----END PGP SIGNATURE----- --7vj27y3kfhi2ktlo--