From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC86DC04AAF for ; Mon, 20 May 2019 09:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAC5820859 for ; Mon, 20 May 2019 09:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731900AbfETJHw (ORCPT ); Mon, 20 May 2019 05:07:52 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48070 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfETJHv (ORCPT ); Mon, 20 May 2019 05:07:51 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 8BC7080450; Mon, 20 May 2019 11:07:39 +0200 (CEST) Date: Mon, 20 May 2019 11:07:49 +0200 From: Pavel Machek To: Ran Wang Cc: Pavel Machek , Leo Li , Rob Herring , Mark Rutland , "Rafael J . Wysocki" , Len Brown , Greg Kroah-Hartman , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH V2 3/3] soc: fsl: add RCPM driver Message-ID: <20190520090748.GB9748@amd> References: <20190517033946.30763-1-ran.wang_1@nxp.com> <20190517033946.30763-3-ran.wang_1@nxp.com> <20190519213844.GH31403@amd> <20190520085647.GA9748@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8GpibOaaTibBMecb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --8GpibOaaTibBMecb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-05-20 09:03:50, Ran Wang wrote: > Hi Pavel, >=20 > On Monday, May 20, 2019 16:57, Pavel Machek wrote: > >=20 > > Hi! > >=20 > > > > > +static int rcpm_pm_prepare(struct device *dev) { > > > > > + struct device_node *np =3D dev->of_node; > > > > > + struct wakeup_source *ws; > > > > > + struct rcpm *rcpm; > > > > > + u32 value[RCPM_WAKEUP_CELL_MAX_SIZE + 1], tmp; > > > > > + int i, ret; > > > > > + > > > > > + rcpm =3D dev_get_drvdata(dev); > > > > > + if (!rcpm) > > > > > + return -EINVAL; > > > > > + > > > > > + /* Begin with first registered wakeup source */ > > > > > + ws =3D wakeup_source_get_next(NULL); > > > > > + while (ws) { > > > > > > > > while (ws =3D wakeup_source_get_next(NULL)) ? > > > > > > Actually, we only pass NULL to wakeup_source_get_next() at very first > > > call to get 1st wakeup source. Then in the while loop, we will fetch > > > next source but not 1st, that's different. I am afraid your suggestion > > > is not quite correct. > >=20 > > Sorry, I seen your next version before seeing this explanation. > >=20 > > You are right, but the current code is "interesting". What about > >=20 > > ws =3D NULL; > > while (ws =3D wakeup_source_get_next(NULL)) ... > >=20 > > then? >=20 > Did you mean: > ws =3D NULL; > while (ws =3D wakeup_source_get_next(ws)) ... >=20 > Yes, that will be the same to my original logic, do you recommend to c= hange > to this? :) Yes please. It will be less confusing to the reader. Thanks (and sorry for cross-talk), Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --8GpibOaaTibBMecb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzibmQACgkQMOfwapXb+vJOsgCgqGW6NAUYHlbtL2j5RhCyhuS2 zxMAn1WDZj1TbQDXI+hk99qNzljFSRtI =XWgf -----END PGP SIGNATURE----- --8GpibOaaTibBMecb--