From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD253C04AAF for ; Mon, 20 May 2019 09:25:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D68C206BA for ; Mon, 20 May 2019 09:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729720AbfETJZC (ORCPT ); Mon, 20 May 2019 05:25:02 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48494 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729357AbfETJZC (ORCPT ); Mon, 20 May 2019 05:25:02 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id C27EA80450; Mon, 20 May 2019 11:24:49 +0200 (CEST) Date: Mon, 20 May 2019 11:24:59 +0200 From: Pavel Machek To: Ran Wang Cc: Pavel Machek , Leo Li , Rob Herring , Mark Rutland , "Rafael J . Wysocki" , Len Brown , Greg Kroah-Hartman , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH V2 3/3] soc: fsl: add RCPM driver Message-ID: <20190520092459.GC9748@amd> References: <20190517033946.30763-1-ran.wang_1@nxp.com> <20190517033946.30763-3-ran.wang_1@nxp.com> <20190519213844.GH31403@amd> <20190520085647.GA9748@amd> <20190520090748.GB9748@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0lnxQi9hkpPO77W3" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > > You are right, but the current code is "interesting". What about > > > > > > > > ws =3D NULL; > > > > while (ws =3D wakeup_source_get_next(NULL)) ... > > > > > > > > then? > > > > > > Did you mean: > > > ws =3D NULL; > > > while (ws =3D wakeup_source_get_next(ws)) ... > > > > > > Yes, that will be the same to my original logic, do you recommend > > > to change to this? :) > >=20 > > Yes please. It will be less confusing to the reader. >=20 > OK, if no other comment, I will work out v4, fix this and extra ',' > =20 > > Thanks (and sorry for cross-talk), >=20 > That's OK, thanks for your time. You can add Acked-by: Pavel Machek to that version. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --0lnxQi9hkpPO77W3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzicmsACgkQMOfwapXb+vI/kACfXfr5zSF0QsKLaIDUnn6ldYdL 9rUAn1IvhOf/+HglBb9Ro5uZKDJsTOI+ =fAL6 -----END PGP SIGNATURE----- --0lnxQi9hkpPO77W3--