From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517CAC28CC0 for ; Thu, 30 May 2019 23:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 290C62630B for ; Thu, 30 May 2019 23:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbfE3XiM (ORCPT ); Thu, 30 May 2019 19:38:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47194 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfE3XiM (ORCPT ); Thu, 30 May 2019 19:38:12 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0818F3082A9A; Thu, 30 May 2019 23:38:12 +0000 (UTC) Received: from treble (ovpn-124-142.rdu2.redhat.com [10.10.124.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98C437A462; Thu, 30 May 2019 23:38:07 +0000 (UTC) Date: Thu, 30 May 2019 18:38:04 -0500 From: Josh Poimboeuf To: "Rafael J. Wysocki" Cc: Thomas Gleixner , Jiri Kosina , the arch/x86 maintainers , "Rafael J. Wysocki" , Pavel Machek , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Linux PM , Linux Kernel Mailing List Subject: Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume Message-ID: <20190530233804.syv4brpe3ndslyvo@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 30 May 2019 23:38:12 +0000 (UTC) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, May 30, 2019 at 11:38:51PM +0200, Rafael J. Wysocki wrote: > On Thu, May 30, 2019 at 11:27 PM Thomas Gleixner wrote: > > > > On Thu, 30 May 2019, Rafael J. Wysocki wrote: > > > > > > > > Cc: stable@vger.kernel.org # v4.19+ > > > > Debugged-by: Thomas Gleixner > > > > Fixes: 0cc3cd21657b ("cpu/hotplug: Boot HT siblings at least once") > > > > Signed-off-by: Jiri Kosina > > > > > > LGTM > > > > > > And I would prefer this one to go in through the PM tree due to the > > > hibernate core changes, > > > > Ok. > > > > > so can I get an ACK from the x86 arch side here, please? > > > > No. Is the following good enough? > > > > Reviewed-by: Thomas Gleixner > > Yes, it is, thanks! I still think changing monitor/mwait to use a fixmap address would be a much cleaner way to fix this. I can try to work up a patch tomorrow. -- Josh