From: Pavel Machek <pavel@ucw.cz>
To: Jiri Kosina <jikos@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
the arch/x86 maintainers <x86@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume
Date: Fri, 31 May 2019 14:18:20 +0200 [thread overview]
Message-ID: <20190531121820.GA3722@amd> (raw)
In-Reply-To: <nycvar.YFH.7.76.1905310139380.1962@cbobk.fhfr.pm>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Fri 2019-05-31 01:42:02, Jiri Kosina wrote:
> On Thu, 30 May 2019, Josh Poimboeuf wrote:
>
> > > > Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> > >
> > > Yes, it is, thanks!
> >
> > I still think changing monitor/mwait to use a fixmap address would be a
> > much cleaner way to fix this. I can try to work up a patch tomorrow.
>
> I disagree with that from the backwards compatibility point of view.
>
> I personally am quite frequently using differnet combinations of
> resumer/resumee kernels, and I've never been biten by it so far. I'd guess
> I am not the only one.
> Fixmap sort of breaks that invariant.
If we get less tricky code, it may be worth it...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-31 12:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 21:31 [PATCH] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume Jiri Kosina
2019-05-29 8:06 ` Rafael J. Wysocki
2019-05-29 9:03 ` Peter Zijlstra
2019-05-29 10:32 ` [PATCH v2] " Jiri Kosina
2019-05-29 12:02 ` Peter Zijlstra
2019-05-29 16:10 ` Josh Poimboeuf
2019-05-29 16:26 ` Jiri Kosina
2019-05-29 17:00 ` Peter Zijlstra
2019-05-29 17:15 ` Thomas Gleixner
2019-05-29 17:17 ` Josh Poimboeuf
2019-05-29 17:29 ` Jiri Kosina
2019-05-29 18:02 ` Jiri Kosina
2019-05-29 20:26 ` [PATCH v3] " Jiri Kosina
2019-05-29 21:25 ` Pavel Machek
2019-05-29 21:27 ` Jiri Kosina
2019-05-29 21:53 ` Pavel Machek
2019-05-29 22:09 ` [PATCH v4] " Jiri Kosina
2019-05-30 8:46 ` Rafael J. Wysocki
2019-05-30 21:27 ` Thomas Gleixner
2019-05-30 21:38 ` Rafael J. Wysocki
2019-05-30 23:38 ` Josh Poimboeuf
2019-05-30 23:42 ` Jiri Kosina
2019-05-31 5:14 ` Josh Poimboeuf
2019-05-31 8:26 ` Rafael J. Wysocki
2019-05-31 8:47 ` Jiri Kosina
2019-05-31 8:57 ` Rafael J. Wysocki
2019-05-31 14:24 ` Andy Lutomirski
2019-05-31 14:31 ` Jiri Kosina
2019-05-31 14:33 ` Jiri Kosina
2019-05-31 14:46 ` Andy Lutomirski
2019-05-31 14:54 ` Jiri Kosina
2019-05-31 15:26 ` Josh Poimboeuf
2019-05-31 15:41 ` Jiri Kosina
2019-05-31 16:19 ` Josh Poimboeuf
2019-05-31 16:51 ` Andy Lutomirski
2019-05-31 18:11 ` Josh Poimboeuf
2019-06-03 10:03 ` Rafael J. Wysocki
2019-05-31 16:23 ` Andy Lutomirski
2019-05-31 21:05 ` Jiri Kosina
2019-05-31 21:22 ` Andy Lutomirski
2019-06-03 14:23 ` Sean Christopherson
2019-06-03 15:24 ` Jiri Kosina
2019-06-03 16:18 ` Sean Christopherson
2019-05-31 12:09 ` Jiri Kosina
2019-05-31 14:51 ` Jiri Kosina
2019-05-31 12:18 ` Pavel Machek [this message]
2019-05-30 10:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531121820.GA3722@amd \
--to=pavel@ucw.cz \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).