From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF54FC04AB6 for ; Fri, 31 May 2019 12:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93B6A268AC for ; Fri, 31 May 2019 12:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfEaMSX (ORCPT ); Fri, 31 May 2019 08:18:23 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55288 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726331AbfEaMSX (ORCPT ); Fri, 31 May 2019 08:18:23 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 74D2B802E6; Fri, 31 May 2019 14:18:10 +0200 (CEST) Date: Fri, 31 May 2019 14:18:20 +0200 From: Pavel Machek To: Jiri Kosina Cc: Josh Poimboeuf , "Rafael J. Wysocki" , Thomas Gleixner , the arch/x86 maintainers , "Rafael J. Wysocki" , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Linux PM , Linux Kernel Mailing List Subject: Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume Message-ID: <20190531121820.GA3722@amd> References: <20190530233804.syv4brpe3ndslyvo@treble> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2019-05-31 01:42:02, Jiri Kosina wrote: > On Thu, 30 May 2019, Josh Poimboeuf wrote: >=20 > > > > Reviewed-by: Thomas Gleixner > > >=20 > > > Yes, it is, thanks! > >=20 > > I still think changing monitor/mwait to use a fixmap address would be a > > much cleaner way to fix this. I can try to work up a patch tomorrow. >=20 > I disagree with that from the backwards compatibility point of view. >=20 > I personally am quite frequently using differnet combinations of=20 > resumer/resumee kernels, and I've never been biten by it so far. I'd gues= s=20 > I am not the only one. > Fixmap sort of breaks that invariant. If we get less tricky code, it may be worth it... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzxG4wACgkQMOfwapXb+vL4dwCgtSpSgpdvZHaImr55/SbbOMad 9MQAoK0rb5nzJTsI242mfK7pEZ/i4Xmy =bqKz -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--