From: Andreas Kemnade <andreas@kemnade.info>
To: Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: BUG: no cpufreq on gta04 (omap dm3730) in 5.2-rc4
Date: Thu, 13 Jun 2019 18:09:58 +0200 [thread overview]
Message-ID: <20190613180958.48e04530@kemnade.info> (raw)
[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]
Hi,
On the gta04 (dm3730 cpu), cpufreq does not work properly with above-mentioned
kernel.
cpufreq-info just shows
analyzing CPU 0:
no or unknown cpufreq driver is active on this CPU
maximum transition latency: 0.00 ms.
dmesg log shows these interesting lines.
[ 3.140655] core: _opp_supported_by_regulators: OPP minuV: 1012500 maxuV: 1012500, not supported by regulator
[ 3.152709] cpu cpu0: _opp_add: OPP not supported by regulators (300000000)
[ 3.160278] core: _opp_supported_by_regulators: OPP minuV: 1200000 maxuV: 1200000, not supported by regulator
[ 3.171142] cpu cpu0: _opp_add: OPP not supported by regulators (600000000)
[ 3.178710] core: _opp_supported_by_regulators: OPP minuV: 1325000 maxuV: 1325000, not supported by regulator
[ 3.189483] cpu cpu0: _opp_add: OPP not supported by regulators
(800000000)
looking through logs shows that these lines first appeared in
next-20190506. They were not present in next-20190503. If I understand that
correcly it is about vdd1.
Analysis reveals:
in
int regulator_is_supported_voltage(struct regulator *regulator,
int min_uV, int max_uV)
the following if fails:
/* Any voltage within constrains range is fine? */
if (rdev->desc->continuous_voltage_range) {
The following hack did the trick
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 6fa15b2d6fb3..f7bfdf53701d 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -478,6 +478,7 @@ static const struct twlreg_info TWL4030_INFO_##label = { \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
.enable_time = turnon_delay, \
+ .continuous_voltage_range = true, \
.of_map_mode = twl4030reg_map_mode, \
}, \
}
not sure whether it is correct, whether these things are continuous enough.
If that all is ok, I will of course submit a formal patch.
Regards
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
reply other threads:[~2019-06-13 16:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613180958.48e04530@kemnade.info \
--to=andreas@kemnade.info \
--cc=letux-kernel@openphoenux.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox