From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2388AC06513 for ; Thu, 4 Jul 2019 07:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01C042133F for ; Thu, 4 Jul 2019 07:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbfGDHqp (ORCPT ); Thu, 4 Jul 2019 03:46:45 -0400 Received: from mga02.intel.com ([134.134.136.20]:53860 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbfGDHqp (ORCPT ); Thu, 4 Jul 2019 03:46:45 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 00:46:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,449,1557212400"; d="scan'208";a="184946903" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 04 Jul 2019 00:46:41 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 04 Jul 2019 10:46:40 +0300 Date: Thu, 4 Jul 2019 10:46:40 +0300 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Linux ACPI , Linux PM , LKML Subject: Re: [PATCH] ACPI: PM: Unexport acpi_device_get_power() Message-ID: <20190704074640.GF2640@lahna.fi.intel.com> References: <1970901.ZntFDt4DbR@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1970901.ZntFDt4DbR@kreacher> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Jul 04, 2019 at 01:02:49AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Using acpi_device_get_power() outside of ACPI device initialization > and ACPI sysfs is problematic due to the way in which power resources > are handled by it, so unexport it and add a paragraph explaining the > pitfalls to its kerneldoc comment. > > Signed-off-by: Rafael J. Wysocki > --- Makes perfect sense! Reviewed-by: Mika Westerberg