From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC003C76191 for ; Tue, 16 Jul 2019 02:13:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8723821738 for ; Tue, 16 Jul 2019 02:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563243228; bh=/wHJ0nCPXO0BilnRARhdb/iE/cpLJmGu45X/cl8c/O8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PTbjyOSQvbxe2YYWDh5qWhny3sEDfi580sASgTMJd5HUYfmAB4MyvD158YueEUw5k FFjYfnz8rmCKVd/H6VSZUdi+5AfLnmAV+ydtc4ONz/1A2ZxvZte/jpsKgxpPlihA6j izS9aAydPQuRvRPtTB1DhprCPy2CMhGAbGQSOvw0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733243AbfGPCNs (ORCPT ); Mon, 15 Jul 2019 22:13:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:44904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733236AbfGPCNr (ORCPT ); Mon, 15 Jul 2019 22:13:47 -0400 Received: from localhost (unknown [88.128.80.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2689120880; Tue, 16 Jul 2019 02:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563243227; bh=/wHJ0nCPXO0BilnRARhdb/iE/cpLJmGu45X/cl8c/O8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DZ8fUBFwHQmGnYcYxJHWoYssyCF88SMmYhSjv0LjpjnW7U5WRTe5FmP+wgnqkSUMj jyMlCH9HScwnW0XtdhbHXoRqNv0gWNLD3mD6qGDUrn81qbenTPZWwA29tV5QBqR7wj +ZtwX/18Szq4fduukhl5QsmjQjCRO7N78CMHgJpg= Date: Tue, 16 Jul 2019 04:11:02 +0200 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Tri Vo , "Rafael J. Wysocki" , Viresh Kumar , Hridya Valsaraju , sspatil@google.com, kaleshsingh@google.com, Linux Kernel Mailing List , Linux PM , "Cc: Android Kernel" Subject: Re: [PATCH v4] PM / wakeup: show wakeup sources stats in sysfs Message-ID: <20190716021102.GA8310@kroah.com> References: <20190715203651.GA7513@kroah.com> <20190715214348.81865-1-trong@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jul 15, 2019 at 11:48:27PM +0200, Rafael J. Wysocki wrote: > On Mon, Jul 15, 2019 at 11:44 PM Tri Vo wrote: > > > > Userspace can use wakeup_sources debugfs node to plot history of suspend > > blocking wakeup sources over device's boot cycle. This information can > > then be used (1) for power-specific bug reporting and (2) towards > > attributing battery consumption to specific processes over a period of > > time. > > > > However, debugfs doesn't have stable ABI. For this reason, create a > > 'struct device' to expose wakeup sources statistics in sysfs under > > /sys/class/wakeup//. > > > > Introduce CONFIG_PM_SLEEP_STATS that enables/disables showing wakeup > > source statistics in sysfs. > > I'm not sure if this is really needed, but I'll let Greg decide. You are right. Having zillions of config options is a pain, who is going to turn this off? But we can always remove the option before 5.4-rc1, so I'll take this as-is for now :) > Apart from this > > Reviewed-by: Rafael J. Wysocki thanks for the review! I'll wait for 5.3-rc1 to come out before adding this to my tree. greg k-h