From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4724AC76192 for ; Tue, 16 Jul 2019 08:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C998206C2 for ; Tue, 16 Jul 2019 08:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563266385; bh=M/lqVVPiWZwgAYL4LGiADH8CqNdvW8sCBgca7ffnYDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FjJVHtsRZ3NCvfB3SfxBCUpqTB25stQkwRY7lvdUu/gqiv6D0evL7lJzzvi8u+d6G DiySRbURrxgqeJ60J/SVkAVQHShKTFiyNXGh9C5jojIg4w76qfVGvPm2kMrORo+3eh 6Zy/Lms9f0YUzJwU/KUPsGfcP3X+/zrt+EPZDxC4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731475AbfGPIjl (ORCPT ); Tue, 16 Jul 2019 04:39:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:54324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727105AbfGPIjl (ORCPT ); Tue, 16 Jul 2019 04:39:41 -0400 Received: from localhost (unknown [113.157.217.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39F2321721; Tue, 16 Jul 2019 08:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563266380; bh=M/lqVVPiWZwgAYL4LGiADH8CqNdvW8sCBgca7ffnYDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ignF/XJSPof7phYqp5604uR5utOVu63j0eZlOTnf2OaptycLIcZ/w1bKjQnfvWS+S fD7YgyS78PNy2HYjl3JkK/oC3kGS/toRShRF9BMhp/Gmrt/hGIvSgzu1t+fxeJKKdr pXKcybiEIp6m+eJDgLi4xBTgBvti7ClNjZRNQ2vs= Date: Tue, 16 Jul 2019 17:39:26 +0900 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Tri Vo , "Rafael J. Wysocki" , Viresh Kumar , Hridya Valsaraju , sspatil@google.com, kaleshsingh@google.com, Linux Kernel Mailing List , Linux PM , "Cc: Android Kernel" Subject: Re: [PATCH v4] PM / wakeup: show wakeup sources stats in sysfs Message-ID: <20190716083926.GA2505@kroah.com> References: <20190715203651.GA7513@kroah.com> <20190715214348.81865-1-trong@android.com> <20190716021102.GA8310@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 16, 2019 at 10:30:48AM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 16, 2019 at 4:13 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Jul 15, 2019 at 11:48:27PM +0200, Rafael J. Wysocki wrote: > > > On Mon, Jul 15, 2019 at 11:44 PM Tri Vo wrote: > > > > > > > > Userspace can use wakeup_sources debugfs node to plot history of suspend > > > > blocking wakeup sources over device's boot cycle. This information can > > > > then be used (1) for power-specific bug reporting and (2) towards > > > > attributing battery consumption to specific processes over a period of > > > > time. > > > > > > > > However, debugfs doesn't have stable ABI. For this reason, create a > > > > 'struct device' to expose wakeup sources statistics in sysfs under > > > > /sys/class/wakeup//. > > > > > > > > Introduce CONFIG_PM_SLEEP_STATS that enables/disables showing wakeup > > > > source statistics in sysfs. > > > > > > I'm not sure if this is really needed, but I'll let Greg decide. > > > > You are right. Having zillions of config options is a pain, who is > > going to turn this off? > > > > But we can always remove the option before 5.4-rc1, so I'll take this > > as-is for now :) > > > > > Apart from this > > > > > > Reviewed-by: Rafael J. Wysocki > > > > thanks for the review! I'll wait for 5.3-rc1 to come out before adding > > this to my tree. > > So it occurred to me that maybe it's better if I apply it? After all, > this is PM material. :-) Heh, true, feel free to add: Signed-off-by: Greg Kroah-Hartman to the patch then. > It is fine by me either way, but then I'm not sure if you want to get > future bug reports related to this if any ... I get enough emails as it is, no need to ask for more :) thanks, greg k-h