From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB252C433FF for ; Sat, 27 Jul 2019 18:26:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD6382075E for ; Sat, 27 Jul 2019 18:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388097AbfG0S0n (ORCPT ); Sat, 27 Jul 2019 14:26:43 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:38766 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388091AbfG0S0m (ORCPT ); Sat, 27 Jul 2019 14:26:42 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 442EEFB03; Sat, 27 Jul 2019 20:26:38 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vRGa6_JKtNHm; Sat, 27 Jul 2019 20:26:37 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id DDD4B46B22; Sat, 27 Jul 2019 20:26:36 +0200 (CEST) Date: Sat, 27 Jul 2019 20:26:36 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Daniel Baluta Cc: Anson Huang , Mark Rutland , Carlo Caione , "Angus Ainslie (Purism)" , Leonard Crestez , Fabio Estevam , linux-clk@vger.kernel.org, Abel Vesa , Andrey Smirnov , daniel.lezcano@linaro.org, dl-linux-imx , rui.zhang@intel.com, Michael Turquette , Devicetree List , linux-pm@vger.kernel.org, Sascha Hauer , edubezval@gmail.com, Rob Herring , linux-arm-kernel , Stephen Boyd , Linux Kernel Mailing List , Pengutronix Kernel Team , Shawn Guo , Lucas Stach Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT Message-ID: <20190727182636.GA7170@bogon.m.sigxcpu.org> References: <20190705045612.27665-1-Anson.Huang@nxp.com> <20190705045612.27665-5-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Daniel, On Sat, Jul 27, 2019 at 01:26:50AM +0300, Daniel Baluta wrote: > Hi all, > > latest linux-next hangs at boot. > > commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag: > next-20190726, origin/master, origin/HEAD) > Author: Stephen Rothwell > Date: Fri Jul 26 15:18:02 2019 +1000 > > Add linux-next specific files for 20190726 > > Signed-off-by: Stephen Rothwell > > > I know this is crazy but reverting commit: > > commit 431bdd1df48ee2896ea9980d9153e3aeaf0c81ef (refs/bisect/bad) > Author: Anson Huang > Date: Fri Jul 5 12:56:11 2019 +0800 > > clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT > > IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver > should manage this clock, so no need to have CLK_IS_CRITICAL flag > set. > > > > makes the boot work again. I noticed a boot hang yesterday on next-20190726 when loading the qoriq_thermal which I worked around by blacklisting it. The fsl,imx8mq-tmu node specifies a clock (IMX8MQ_CLK_TMU_ROOT) but does not seem to enable, shouldn't it do so? Cheers, -- Guido