* [PATCH v3 0/9] Exynos Adaptive Supply Voltage support [not found] <CGME20190813150842eucas1p2c248537d9cd593073e12abeac2cacab5@eucas1p2.samsung.com> @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-13 15:08 ` [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support Sylwester Nawrocki ` (9 more replies) 0 siblings, 10 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki This is third iteration of my patch series adding ASV (Adaptive Supply Voltage) support for Exynos SoCs. The previous one can be found at: https://lore.kernel.org/lkml/20190718143044.25066-1-s.nawrocki@samsung.com There is no major changes in this series comparing to v2, only minor corrections addressing review comments. I was not sure it was a good idea to try to extend the OPP binding so as to include the ASV data tables in DT, so the tables are left in the driver. This patch set includes Exynos CHIPID driver posted by Pankaj Dubey and futher improved by Bartłomiej Żołnierkiewicz [1]. Tested on Odroid XU3, XU3 Lite, XU4. One of the things on TODO list is support for the Adaptive Body Bias. This will require modifications on the cpufreq driver side in order to support multiple voltage regulators and changes in the OPP framework to support adding OPPs with multiple voltages. [1] https://lkml.org/lkml/2018/11/15/908 Pankaj Dubey (3): soc: samsung: Add exynos chipid driver support ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS ARM64: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Sylwester Nawrocki (6): soc: samsung: Convert exynos-chipid driver to use the regmap API soc: samsung: Add Exynos Adaptive Supply Voltage driver ARM: EXYNOS: Enable exynos-asv driver for ARCH_EXYNOS soc: samsung: Update the CHIP ID DT binding documentation ARM: dts: Add "syscon" compatible string to chipid node ARM: dts: Add samsung,asv-bin property for odroidxu3-lite .../bindings/arm/samsung/exynos-chipid.txt | 10 +- arch/arm/boot/dts/exynos5.dtsi | 4 +- .../boot/dts/exynos5422-odroidxu3-lite.dts | 4 + arch/arm/mach-exynos/Kconfig | 2 + arch/arm64/Kconfig.platforms | 1 + drivers/soc/samsung/Kconfig | 15 + drivers/soc/samsung/Makefile | 5 + drivers/soc/samsung/exynos-asv.c | 184 +++++++ drivers/soc/samsung/exynos-asv.h | 82 +++ drivers/soc/samsung/exynos-chipid.c | 101 ++++ drivers/soc/samsung/exynos5422-asv.c | 498 ++++++++++++++++++ drivers/soc/samsung/exynos5422-asv.h | 25 + include/linux/soc/samsung/exynos-chipid.h | 52 ++ 13 files changed, 979 insertions(+), 4 deletions(-) create mode 100644 drivers/soc/samsung/exynos-asv.c create mode 100644 drivers/soc/samsung/exynos-asv.h create mode 100644 drivers/soc/samsung/exynos-chipid.c create mode 100644 drivers/soc/samsung/exynos5422-asv.c create mode 100644 drivers/soc/samsung/exynos5422-asv.h create mode 100644 include/linux/soc/samsung/exynos-chipid.h -- 2.17.1 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-15 18:18 ` Krzysztof Kozlowski 2019-08-13 15:08 ` [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API Sylwester Nawrocki ` (8 subsequent siblings) 9 siblings, 1 reply; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki From: Pankaj Dubey <pankaj.dubey@samsung.com> Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. This patch intends to provide initialization code for all these functionalities, at the same time it provides some sysfs entries for accessing these information to user-space. This driver uses existing binding for exynos-chipid. Changes by Bartlomiej: - fixed return values on errors - removed bogus kfree_const() - added missing Exynos4210 EVT0 id - converted code to use EXYNOS_MASK define - fixed np use after of_node_put() - fixed too early use of dev_info() - made driver fail for unknown SoC-s - added SPDX tag - updated Copyrights Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> [m.szyprowski: for suggestion and code snippet of product_id_to_soc_id] Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> [s.nawrocki: updated copyright date, removed uneeded headers inclusion] Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - removed uneeded headers inclusion. --- drivers/soc/samsung/Kconfig | 5 ++ drivers/soc/samsung/Makefile | 2 + drivers/soc/samsung/exynos-chipid.c | 109 ++++++++++++++++++++++++++++ 3 files changed, 116 insertions(+) create mode 100644 drivers/soc/samsung/exynos-chipid.c diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig index 2186285fda92..2905f5262197 100644 --- a/drivers/soc/samsung/Kconfig +++ b/drivers/soc/samsung/Kconfig @@ -7,6 +7,11 @@ menuconfig SOC_SAMSUNG if SOC_SAMSUNG +config EXYNOS_CHIPID + bool "Exynos Chipid controller driver" if COMPILE_TEST + depends on ARCH_EXYNOS || COMPILE_TEST + select SOC_BUS + config EXYNOS_PMU bool "Exynos PMU controller driver" if COMPILE_TEST depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST) diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile index 29f294baac6e..3b6a8797416c 100644 --- a/drivers/soc/samsung/Makefile +++ b/drivers/soc/samsung/Makefile @@ -1,4 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 + +obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o obj-$(CONFIG_EXYNOS_PMU_ARM_DRIVERS) += exynos3250-pmu.o exynos4-pmu.o \ diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c new file mode 100644 index 000000000000..bcf691f2b650 --- /dev/null +++ b/drivers/soc/samsung/exynos-chipid.c @@ -0,0 +1,109 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * + * EXYNOS - CHIP ID support + * Author: Pankaj Dubey <pankaj.dubey@samsung.com> + * Author: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + */ + +#include <linux/io.h> +#include <linux/of.h> +#include <linux/of_address.h> +#include <linux/slab.h> +#include <linux/sys_soc.h> + +#define EXYNOS_SUBREV_MASK (0xF << 4) +#define EXYNOS_MAINREV_MASK (0xF << 0) +#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) +#define EXYNOS_MASK 0xFFFFF000 + +static const struct exynos_soc_id { + const char *name; + unsigned int id; +} soc_ids[] = { + { "EXYNOS3250", 0xE3472000 }, + { "EXYNOS4210", 0x43200000 }, /* EVT0 revision */ + { "EXYNOS4210", 0x43210000 }, + { "EXYNOS4212", 0x43220000 }, + { "EXYNOS4412", 0xE4412000 }, + { "EXYNOS5250", 0x43520000 }, + { "EXYNOS5260", 0xE5260000 }, + { "EXYNOS5410", 0xE5410000 }, + { "EXYNOS5420", 0xE5420000 }, + { "EXYNOS5440", 0xE5440000 }, + { "EXYNOS5800", 0xE5422000 }, + { "EXYNOS7420", 0xE7420000 }, + { "EXYNOS5433", 0xE5433000 }, +}; + +static const char * __init product_id_to_soc_id(unsigned int product_id) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(soc_ids); i++) + if ((product_id & EXYNOS_MASK) == soc_ids[i].id) + return soc_ids[i].name; + return NULL; +} + +int __init exynos_chipid_early_init(void) +{ + struct soc_device_attribute *soc_dev_attr; + void __iomem *exynos_chipid_base; + struct soc_device *soc_dev; + struct device_node *root; + struct device_node *np; + u32 product_id; + u32 revision; + + /* look up for chipid node */ + np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); + if (!np) + return -ENODEV; + + exynos_chipid_base = of_iomap(np, 0); + of_node_put(np); + + if (!exynos_chipid_base) { + pr_err("Failed to map SoC chipid\n"); + return -ENXIO; + } + + product_id = readl_relaxed(exynos_chipid_base); + revision = product_id & EXYNOS_REV_MASK; + iounmap(exynos_chipid_base); + + soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); + if (!soc_dev_attr) + return -ENOMEM; + + soc_dev_attr->family = "Samsung Exynos"; + + root = of_find_node_by_path("/"); + of_property_read_string(root, "model", &soc_dev_attr->machine); + of_node_put(root); + + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "%x", revision); + soc_dev_attr->soc_id = product_id_to_soc_id(product_id); + if (!soc_dev_attr->soc_id) { + pr_err("Unknown SoC\n"); + return -ENODEV; + } + + /* please note that the actual registration will be deferred */ + soc_dev = soc_device_register(soc_dev_attr); + if (IS_ERR(soc_dev)) { + kfree(soc_dev_attr->revision); + kfree(soc_dev_attr); + return PTR_ERR(soc_dev); + } + + /* it is too early to use dev_info() here (soc_dev is NULL) */ + pr_info("soc soc0: Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", + soc_dev_attr->soc_id, product_id, revision); + + return 0; +} +early_initcall(exynos_chipid_early_init); -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support 2019-08-13 15:08 ` [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support Sylwester Nawrocki @ 2019-08-15 18:18 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-15 18:18 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski On Tue, Aug 13, 2019 at 05:08:19PM +0200, Sylwester Nawrocki wrote: > From: Pankaj Dubey <pankaj.dubey@samsung.com> > > Exynos SoCs have Chipid, for identification of product IDs and SoC > revisions. This patch intends to provide initialization code for all > these functionalities, at the same time it provides some sysfs entries > for accessing these information to user-space. > Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki 2019-08-13 15:08 ` [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-15 18:22 ` Krzysztof Kozlowski 2019-08-20 19:24 ` Jon Hunter 2019-08-13 15:08 ` [PATCH v3 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki ` (7 subsequent siblings) 9 siblings, 2 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki Convert the driver to use regmap API in order to allow other drivers, like ASV, to access the CHIPID registers. This patch adds definition of selected CHIPID register offsets and register bit fields for Exynos5422 SoC. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - s/_EXYNOS_ASV_H/__LINU_SOC_EXYNOS_ASV_H, - removed __func__ from error log, - removed unneeded <linux/of_address.h> header inclusion. Changes since v1 (RFC): - new patch --- drivers/soc/samsung/exynos-chipid.c | 34 ++++++--------- include/linux/soc/samsung/exynos-chipid.h | 52 +++++++++++++++++++++++ 2 files changed, 65 insertions(+), 21 deletions(-) create mode 100644 include/linux/soc/samsung/exynos-chipid.h diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index bcf691f2b650..006a95feb618 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -9,16 +9,13 @@ */ #include <linux/io.h> +#include <linux/mfd/syscon.h> #include <linux/of.h> -#include <linux/of_address.h> +#include <linux/regmap.h> #include <linux/slab.h> +#include <linux/soc/samsung/exynos-chipid.h> #include <linux/sys_soc.h> -#define EXYNOS_SUBREV_MASK (0xF << 4) -#define EXYNOS_MAINREV_MASK (0xF << 0) -#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) -#define EXYNOS_MASK 0xFFFFF000 - static const struct exynos_soc_id { const char *name; unsigned int id; @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) int __init exynos_chipid_early_init(void) { struct soc_device_attribute *soc_dev_attr; - void __iomem *exynos_chipid_base; struct soc_device *soc_dev; struct device_node *root; - struct device_node *np; + struct regmap *regmap; u32 product_id; u32 revision; + int ret; - /* look up for chipid node */ - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); - if (!np) - return -ENODEV; - - exynos_chipid_base = of_iomap(np, 0); - of_node_put(np); - - if (!exynos_chipid_base) { - pr_err("Failed to map SoC chipid\n"); - return -ENXIO; + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); + if (IS_ERR(regmap)) { + pr_err("Failed to get CHIPID regmap\n"); + return PTR_ERR(regmap); } - product_id = readl_relaxed(exynos_chipid_base); + ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id); + if (ret < 0) + return ret; + revision = product_id & EXYNOS_REV_MASK; - iounmap(exynos_chipid_base); soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); if (!soc_dev_attr) diff --git a/include/linux/soc/samsung/exynos-chipid.h b/include/linux/soc/samsung/exynos-chipid.h new file mode 100644 index 000000000000..8bca6763f99c --- /dev/null +++ b/include/linux/soc/samsung/exynos-chipid.h @@ -0,0 +1,52 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2018 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * + * Exynos - CHIPID support + */ +#ifndef __LINUX_SOC_EXYNOS_CHIPID_H +#define __LINUX_SOC_EXYNOS_CHIPID_H + +#define EXYNOS_CHIPID_REG_PRO_ID 0x00 +#define EXYNOS_SUBREV_MASK (0xf << 4) +#define EXYNOS_MAINREV_MASK (0xf << 0) +#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | \ + EXYNOS_MAINREV_MASK) +#define EXYNOS_MASK 0xfffff000 + +#define EXYNOS_CHIPID_REG_PKG_ID 0x04 +/* Bit field definitions for EXYNOS_CHIPID_REG_PKG_ID register */ +#define EXYNOS5422_IDS_OFFSET 24 +#define EXYNOS5422_IDS_MASK 0xff +#define EXYNOS5422_USESG_OFFSET 3 +#define EXYNOS5422_USESG_MASK 0x01 +#define EXYNOS5422_SG_OFFSET 0 +#define EXYNOS5422_SG_MASK 0x07 +#define EXYNOS5422_TABLE_OFFSET 8 +#define EXYNOS5422_TABLE_MASK 0x03 +#define EXYNOS5422_SG_A_OFFSET 17 +#define EXYNOS5422_SG_A_MASK 0x0f +#define EXYNOS5422_SG_B_OFFSET 21 +#define EXYNOS5422_SG_B_MASK 0x03 +#define EXYNOS5422_SG_BSIGN_OFFSET 23 +#define EXYNOS5422_SG_BSIGN_MASK 0x01 +#define EXYNOS5422_BIN2_OFFSET 12 +#define EXYNOS5422_BIN2_MASK 0x01 + +#define EXYNOS_CHIPID_REG_LOT_ID 0x14 + +#define EXYNOS_CHIPID_REG_AUX_INFO 0x1c +/* Bit field definitions for EXYNOS_CHIPID_REG_AUX_INFO register */ +#define EXYNOS5422_TMCB_OFFSET 0 +#define EXYNOS5422_TMCB_MASK 0x7f +#define EXYNOS5422_ARM_UP_OFFSET 8 +#define EXYNOS5422_ARM_UP_MASK 0x03 +#define EXYNOS5422_ARM_DN_OFFSET 10 +#define EXYNOS5422_ARM_DN_MASK 0x03 +#define EXYNOS5422_KFC_UP_OFFSET 12 +#define EXYNOS5422_KFC_UP_MASK 0x03 +#define EXYNOS5422_KFC_DN_OFFSET 14 +#define EXYNOS5422_KFC_DN_MASK 0x03 + +#endif /*__LINUX_SOC_EXYNOS_CHIPID_H */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-13 15:08 ` [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API Sylwester Nawrocki @ 2019-08-15 18:22 ` Krzysztof Kozlowski 2019-08-20 19:24 ` Jon Hunter 1 sibling, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-15 18:22 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski On Tue, Aug 13, 2019 at 05:08:20PM +0200, Sylwester Nawrocki wrote: > Convert the driver to use regmap API in order to allow other > drivers, like ASV, to access the CHIPID registers. > > This patch adds definition of selected CHIPID register offsets > and register bit fields for Exynos5422 SoC. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - s/_EXYNOS_ASV_H/__LINU_SOC_EXYNOS_ASV_H, > - removed __func__ from error log, > - removed unneeded <linux/of_address.h> header inclusion. > > Changes since v1 (RFC): > - new patch > --- > drivers/soc/samsung/exynos-chipid.c | 34 ++++++--------- > include/linux/soc/samsung/exynos-chipid.h | 52 +++++++++++++++++++++++ > 2 files changed, 65 insertions(+), 21 deletions(-) Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-13 15:08 ` [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API Sylwester Nawrocki 2019-08-15 18:22 ` Krzysztof Kozlowski @ 2019-08-20 19:24 ` Jon Hunter 2019-08-20 19:37 ` Krzysztof Kozlowski 1 sibling, 1 reply; 27+ messages in thread From: Jon Hunter @ 2019-08-20 19:24 UTC (permalink / raw) To: Sylwester Nawrocki, krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, linux-tegra On 13/08/2019 16:08, Sylwester Nawrocki wrote: > Convert the driver to use regmap API in order to allow other > drivers, like ASV, to access the CHIPID registers. > > This patch adds definition of selected CHIPID register offsets > and register bit fields for Exynos5422 SoC. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - s/_EXYNOS_ASV_H/__LINU_SOC_EXYNOS_ASV_H, > - removed __func__ from error log, > - removed unneeded <linux/of_address.h> header inclusion. > > Changes since v1 (RFC): > - new patch > --- > drivers/soc/samsung/exynos-chipid.c | 34 ++++++--------- > include/linux/soc/samsung/exynos-chipid.h | 52 +++++++++++++++++++++++ > 2 files changed, 65 insertions(+), 21 deletions(-) > create mode 100644 include/linux/soc/samsung/exynos-chipid.h > > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > index bcf691f2b650..006a95feb618 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -9,16 +9,13 @@ > */ > > #include <linux/io.h> > +#include <linux/mfd/syscon.h> > #include <linux/of.h> > -#include <linux/of_address.h> > +#include <linux/regmap.h> > #include <linux/slab.h> > +#include <linux/soc/samsung/exynos-chipid.h> > #include <linux/sys_soc.h> > > -#define EXYNOS_SUBREV_MASK (0xF << 4) > -#define EXYNOS_MAINREV_MASK (0xF << 0) > -#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) > -#define EXYNOS_MASK 0xFFFFF000 > - > static const struct exynos_soc_id { > const char *name; > unsigned int id; > @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) > int __init exynos_chipid_early_init(void) > { > struct soc_device_attribute *soc_dev_attr; > - void __iomem *exynos_chipid_base; > struct soc_device *soc_dev; > struct device_node *root; > - struct device_node *np; > + struct regmap *regmap; > u32 product_id; > u32 revision; > + int ret; > > - /* look up for chipid node */ > - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); > - if (!np) > - return -ENODEV; > - > - exynos_chipid_base = of_iomap(np, 0); > - of_node_put(np); > - > - if (!exynos_chipid_base) { > - pr_err("Failed to map SoC chipid\n"); > - return -ENXIO; > + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); > + if (IS_ERR(regmap)) { > + pr_err("Failed to get CHIPID regmap\n"); > + return PTR_ERR(regmap); > } Following this change, I am now seeing the above error on our Tegra boards where this driver is enabled. This is triggering a kernel warnings test we have to fail. Hence, I don't think that you can remove the compatible node test here, unless you have a better way to determine if this is a samsung device. Cheers Jon -- nvpublic ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-20 19:24 ` Jon Hunter @ 2019-08-20 19:37 ` Krzysztof Kozlowski 2019-08-20 21:38 ` Sylwester Nawrocki 0 siblings, 1 reply; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-20 19:37 UTC (permalink / raw) To: Jon Hunter, Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Bartłomiej Żołnierkiewicz, Marek Szyprowski, linux-tegra, Arnd Bergmann On Tue, 20 Aug 2019 at 21:24, Jon Hunter <jonathanh@nvidia.com> wrote: > > > On 13/08/2019 16:08, Sylwester Nawrocki wrote: > > Convert the driver to use regmap API in order to allow other > > drivers, like ASV, to access the CHIPID registers. > > > > This patch adds definition of selected CHIPID register offsets > > and register bit fields for Exynos5422 SoC. > > > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > > --- > > Changes since v2: > > - s/_EXYNOS_ASV_H/__LINU_SOC_EXYNOS_ASV_H, > > - removed __func__ from error log, > > - removed unneeded <linux/of_address.h> header inclusion. > > > > Changes since v1 (RFC): > > - new patch > > --- > > drivers/soc/samsung/exynos-chipid.c | 34 ++++++--------- > > include/linux/soc/samsung/exynos-chipid.h | 52 +++++++++++++++++++++++ > > 2 files changed, 65 insertions(+), 21 deletions(-) > > create mode 100644 include/linux/soc/samsung/exynos-chipid.h > > > > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > > index bcf691f2b650..006a95feb618 100644 > > --- a/drivers/soc/samsung/exynos-chipid.c > > +++ b/drivers/soc/samsung/exynos-chipid.c > > @@ -9,16 +9,13 @@ > > */ > > > > #include <linux/io.h> > > +#include <linux/mfd/syscon.h> > > #include <linux/of.h> > > -#include <linux/of_address.h> > > +#include <linux/regmap.h> > > #include <linux/slab.h> > > +#include <linux/soc/samsung/exynos-chipid.h> > > #include <linux/sys_soc.h> > > > > -#define EXYNOS_SUBREV_MASK (0xF << 4) > > -#define EXYNOS_MAINREV_MASK (0xF << 0) > > -#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) > > -#define EXYNOS_MASK 0xFFFFF000 > > - > > static const struct exynos_soc_id { > > const char *name; > > unsigned int id; > > @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) > > int __init exynos_chipid_early_init(void) > > { > > struct soc_device_attribute *soc_dev_attr; > > - void __iomem *exynos_chipid_base; > > struct soc_device *soc_dev; > > struct device_node *root; > > - struct device_node *np; > > + struct regmap *regmap; > > u32 product_id; > > u32 revision; > > + int ret; > > > > - /* look up for chipid node */ > > - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); > > - if (!np) > > - return -ENODEV; > > - > > - exynos_chipid_base = of_iomap(np, 0); > > - of_node_put(np); > > - > > - if (!exynos_chipid_base) { > > - pr_err("Failed to map SoC chipid\n"); > > - return -ENXIO; > > + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); > > + if (IS_ERR(regmap)) { > > + pr_err("Failed to get CHIPID regmap\n"); > > + return PTR_ERR(regmap); > > } > > Following this change, I am now seeing the above error on our Tegra > boards where this driver is enabled. This is triggering a kernel > warnings test we have to fail. Hence, I don't think that you can remove > the compatible node test here, unless you have a better way to determine > if this is a samsung device. Right, this is really wrong... I missed that it is not a probe but early init. And this init will be called on every board... Probably it should be converted to a regular driver. This is very old patchset, revived recently. I see that in v6 it was a platform driver: https://patchwork.kernel.org/patch/9134949/ Pankaj, apparently based on these comments, made it initcall... but why? Another point is that Arnd complained there about exposing global header and no change here - we still expose the global header, but not with soc revisions but register internals... although it has its purpose - other Exynos-specific drivers need to access through regmap. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-20 19:37 ` Krzysztof Kozlowski @ 2019-08-20 21:38 ` Sylwester Nawrocki 2019-08-21 7:49 ` Krzysztof Kozlowski 2019-08-21 11:51 ` Bartlomiej Zolnierkiewicz 0 siblings, 2 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-20 21:38 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Jon Hunter, Sylwester Nawrocki, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Bartłomiej Żołnierkiewicz, Marek Szyprowski, linux-tegra, Arnd Bergmann On 8/20/19 21:37, Krzysztof Kozlowski wrote: >>> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c >>> @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) >>> int __init exynos_chipid_early_init(void) >>> { >>> struct soc_device_attribute *soc_dev_attr; >>> - void __iomem *exynos_chipid_base; >>> struct soc_device *soc_dev; >>> struct device_node *root; >>> - struct device_node *np; >>> + struct regmap *regmap; >>> u32 product_id; >>> u32 revision; >>> + int ret; >>> >>> - /* look up for chipid node */ >>> - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); >>> - if (!np) >>> - return -ENODEV; >>> - >>> - exynos_chipid_base = of_iomap(np, 0); >>> - of_node_put(np); >>> - >>> - if (!exynos_chipid_base) { >>> - pr_err("Failed to map SoC chipid\n"); >>> - return -ENXIO; >>> + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); >>> + if (IS_ERR(regmap)) { >>> + pr_err("Failed to get CHIPID regmap\n"); >>> + return PTR_ERR(regmap); >>> } >> Following this change, I am now seeing the above error on our Tegra >> boards where this driver is enabled. This is triggering a kernel >> warnings test we have to fail. Hence, I don't think that you can remove >> the compatible node test here, unless you have a better way to determine >> if this is a samsung device. > > Right, this is really wrong... I missed that it is not a probe but > early init. And this init will be called on every board... Probably it > should be converted to a regular driver. I'm also inclined to have it converted to a regular driver. We already have "exynos-asv" driver matching on the chipid node (patch 3/9). The ASV patches will not be merged soon anyway, all this needs some more thought. Krzysztof, can we abandon the chipid patches for now? Your pull request doesn't appear to be merged to arm-soc yet. Sorry about that. -- Regards, Sylwester ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-20 21:38 ` Sylwester Nawrocki @ 2019-08-21 7:49 ` Krzysztof Kozlowski 2019-08-21 11:51 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-21 7:49 UTC (permalink / raw) To: Sylwester Nawrocki Cc: Jon Hunter, Sylwester Nawrocki, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Bartłomiej Żołnierkiewicz, Marek Szyprowski, linux-tegra, Arnd Bergmann On Tue, 20 Aug 2019 at 23:38, Sylwester Nawrocki <snawrocki@kernel.org> wrote: > > On 8/20/19 21:37, Krzysztof Kozlowski wrote: > >>> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > > >>> @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) > >>> int __init exynos_chipid_early_init(void) > >>> { > >>> struct soc_device_attribute *soc_dev_attr; > >>> - void __iomem *exynos_chipid_base; > >>> struct soc_device *soc_dev; > >>> struct device_node *root; > >>> - struct device_node *np; > >>> + struct regmap *regmap; > >>> u32 product_id; > >>> u32 revision; > >>> + int ret; > >>> > >>> - /* look up for chipid node */ > >>> - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); > >>> - if (!np) > >>> - return -ENODEV; > >>> - > >>> - exynos_chipid_base = of_iomap(np, 0); > >>> - of_node_put(np); > >>> - > >>> - if (!exynos_chipid_base) { > >>> - pr_err("Failed to map SoC chipid\n"); > >>> - return -ENXIO; > >>> + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); > >>> + if (IS_ERR(regmap)) { > >>> + pr_err("Failed to get CHIPID regmap\n"); > >>> + return PTR_ERR(regmap); > >>> } > >> Following this change, I am now seeing the above error on our Tegra > >> boards where this driver is enabled. This is triggering a kernel > >> warnings test we have to fail. Hence, I don't think that you can remove > >> the compatible node test here, unless you have a better way to determine > >> if this is a samsung device. > > > > Right, this is really wrong... I missed that it is not a probe but > > early init. And this init will be called on every board... Probably it > > should be converted to a regular driver. > > I'm also inclined to have it converted to a regular driver. We already > have "exynos-asv" driver matching on the chipid node (patch 3/9). > The ASV patches will not be merged soon anyway, all this needs some more > thought. Krzysztof, can we abandon the chipid patches for now? Your > pull request doesn't appear to be merged to arm-soc yet. Sorry about > that. Yes, let's abandon the pull request and rework the concept. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-20 21:38 ` Sylwester Nawrocki 2019-08-21 7:49 ` Krzysztof Kozlowski @ 2019-08-21 11:51 ` Bartlomiej Zolnierkiewicz 2019-08-21 12:16 ` Krzysztof Kozlowski 1 sibling, 1 reply; 27+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-08-21 11:51 UTC (permalink / raw) To: Sylwester Nawrocki, Krzysztof Kozlowski Cc: Jon Hunter, Sylwester Nawrocki, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Marek Szyprowski, linux-tegra, Arnd Bergmann Hi, On 8/20/19 11:38 PM, Sylwester Nawrocki wrote: > On 8/20/19 21:37, Krzysztof Kozlowski wrote: >>>> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > >>>> @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) >>>> int __init exynos_chipid_early_init(void) >>>> { >>>> struct soc_device_attribute *soc_dev_attr; >>>> - void __iomem *exynos_chipid_base; >>>> struct soc_device *soc_dev; >>>> struct device_node *root; >>>> - struct device_node *np; >>>> + struct regmap *regmap; >>>> u32 product_id; >>>> u32 revision; >>>> + int ret; >>>> >>>> - /* look up for chipid node */ >>>> - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); >>>> - if (!np) >>>> - return -ENODEV; >>>> - >>>> - exynos_chipid_base = of_iomap(np, 0); >>>> - of_node_put(np); >>>> - >>>> - if (!exynos_chipid_base) { >>>> - pr_err("Failed to map SoC chipid\n"); >>>> - return -ENXIO; >>>> + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); >>>> + if (IS_ERR(regmap)) { >>>> + pr_err("Failed to get CHIPID regmap\n"); >>>> + return PTR_ERR(regmap); >>>> } >>> Following this change, I am now seeing the above error on our Tegra >>> boards where this driver is enabled. This is triggering a kernel >>> warnings test we have to fail. Hence, I don't think that you can remove >>> the compatible node test here, unless you have a better way to determine >>> if this is a samsung device. >> >> Right, this is really wrong... I missed that it is not a probe but >> early init. And this init will be called on every board... Probably it >> should be converted to a regular driver. Early initialization is needed for SoC driver to be used from within arch/arm/mach-exynos/ and _initcall() usage is the usual way for SoC drivers to be initialized: drivers/soc/amlogic/meson-gx-socinfo.c drivers/soc/amlogic/meson-mx-socinfo.c drivers/soc/atmel/soc.c drivers/soc/bcm/brcmstb/common.c drivers/soc/imx/soc-imx-scu.c drivers/soc/imx/soc-imx8.c drivers/soc/renesas/renesas-soc.c drivers/soc/tegra/fuse/fuse-tegra.c drivers/soc/ux500/ux500-soc-id.c drivers/soc/versatile/soc-integrator.c drivers/soc/versatile/soc-integrator.c The only SoC drivers that are regular drivers are: drivers/soc/fsl/guts.c drivers/soc/versatile/soc-realview.c > I'm also inclined to have it converted to a regular driver. We already > have "exynos-asv" driver matching on the chipid node (patch 3/9). > The ASV patches will not be merged soon anyway, all this needs some more > thought. Krzysztof, can we abandon the chipid patches for now? Your chipid driver is good and useful on its own. The preferred solution IMHO would be to just revert "soc: samsung: Convert exynos-chipid driver to use the regmap API" commit. > pull request doesn't appear to be merged to arm-soc yet. Sorry about > that. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-21 11:51 ` Bartlomiej Zolnierkiewicz @ 2019-08-21 12:16 ` Krzysztof Kozlowski 2019-08-21 12:41 ` Sylwester Nawrocki 2019-08-21 13:31 ` Bartlomiej Zolnierkiewicz 0 siblings, 2 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-21 12:16 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Sylwester Nawrocki, Jon Hunter, Sylwester Nawrocki, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Marek Szyprowski, linux-tegra, Arnd Bergmann On Wed, 21 Aug 2019 at 13:51, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > >>> Following this change, I am now seeing the above error on our Tegra > >>> boards where this driver is enabled. This is triggering a kernel > >>> warnings test we have to fail. Hence, I don't think that you can remove > >>> the compatible node test here, unless you have a better way to determine > >>> if this is a samsung device. > >> > >> Right, this is really wrong... I missed that it is not a probe but > >> early init. And this init will be called on every board... Probably it > >> should be converted to a regular driver. > > Early initialization is needed for SoC driver to be used from within > arch/arm/mach-exynos/ and _initcall() usage is the usual way for SoC > drivers to be initialized: > > drivers/soc/amlogic/meson-gx-socinfo.c > drivers/soc/amlogic/meson-mx-socinfo.c > drivers/soc/atmel/soc.c > drivers/soc/bcm/brcmstb/common.c > drivers/soc/imx/soc-imx-scu.c > drivers/soc/imx/soc-imx8.c > drivers/soc/renesas/renesas-soc.c > drivers/soc/tegra/fuse/fuse-tegra.c > drivers/soc/ux500/ux500-soc-id.c > drivers/soc/versatile/soc-integrator.c > drivers/soc/versatile/soc-integrator.c > > The only SoC drivers that are regular drivers are: > > drivers/soc/fsl/guts.c > drivers/soc/versatile/soc-realview.c Thanks for pointing it out. Indeed, the initcall was needed in your set of patches here: https://patchwork.kernel.org/project/linux-samsung-soc/list/?series=43565&state=* but this work was not continued here. Maybe it will be later resubmitted... maybe not... who knows? Therefore I would prefer proper solution for current case (driver), unless patches for mach are being brought back to life now. > > I'm also inclined to have it converted to a regular driver. We already > > have "exynos-asv" driver matching on the chipid node (patch 3/9). > > The ASV patches will not be merged soon anyway, all this needs some more > > thought. Krzysztof, can we abandon the chipid patches for now? Your > > chipid driver is good and useful on its own. The preferred solution > IMHO would be to just revert "soc: samsung: Convert exynos-chipid > driver to use the regmap API" commit. I queued the chipid as a dependency for ASV but ASV requires the regmap. What would be left after reverting the regmap part? Simple unused printk driver? No need for such. If reverting, then let's drop entire driver and rework it offline. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-21 12:16 ` Krzysztof Kozlowski @ 2019-08-21 12:41 ` Sylwester Nawrocki 2019-08-21 13:10 ` Krzysztof Kozlowski 2019-08-21 13:31 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-21 12:41 UTC (permalink / raw) To: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz Cc: Sylwester Nawrocki, Jon Hunter, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Marek Szyprowski, linux-tegra, Arnd Bergmann On 8/21/19 14:16, Krzysztof Kozlowski wrote: >>> I'm also inclined to have it converted to a regular driver. We already >>> have "exynos-asv" driver matching on the chipid node (patch 3/9). >>> The ASV patches will not be merged soon anyway, all this needs some more >>> thought. Krzysztof, can we abandon the chipid patches for now? Your >> >> chipid driver is good and useful on its own. The preferred solution >> IMHO would be to just revert "soc: samsung: Convert exynos-chipid >> driver to use the regmap API" commit. > > I queued the chipid as a dependency for ASV but ASV requires the > regmap. What would be left after reverting the regmap part? Simple > unused printk driver? No need for such. If reverting, then let's drop > entire driver and rework it offline. In fact there is now no dependency between the chipid and the ASV driver (patch 3/9), the regmap is provided by the syscon driver/API. I should have added "depends on REGMAP && MFD_SYSCON" to Kconfig. Both drivers (chipid, ASV) share the registers region so the regmap API seemed appropriate here. Converting the chipid code to platform driver wouldn't make sense as it wouldn't be useful early in arch/arm/mach-exynos and we can't have two drivers for same device (the ASV driver matches on the chipid compatible now). -- Regards, Sylwester ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-21 12:41 ` Sylwester Nawrocki @ 2019-08-21 13:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-21 13:10 UTC (permalink / raw) To: Sylwester Nawrocki Cc: Bartlomiej Zolnierkiewicz, Sylwester Nawrocki, Jon Hunter, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Marek Szyprowski, linux-tegra, Arnd Bergmann On Wed, 21 Aug 2019 at 14:41, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > On 8/21/19 14:16, Krzysztof Kozlowski wrote: > >>> I'm also inclined to have it converted to a regular driver. We already > >>> have "exynos-asv" driver matching on the chipid node (patch 3/9). > >>> The ASV patches will not be merged soon anyway, all this needs some more > >>> thought. Krzysztof, can we abandon the chipid patches for now? Your > >> > >> chipid driver is good and useful on its own. The preferred solution > >> IMHO would be to just revert "soc: samsung: Convert exynos-chipid > >> driver to use the regmap API" commit. > > > > I queued the chipid as a dependency for ASV but ASV requires the > > regmap. What would be left after reverting the regmap part? Simple > > unused printk driver? No need for such. If reverting, then let's drop > > entire driver and rework it offline. > > In fact there is now no dependency between the chipid and the ASV > driver (patch 3/9), the regmap is provided by the syscon driver/API. > I should have added "depends on REGMAP && MFD_SYSCON" to Kconfig. > Both drivers (chipid, ASV) share the registers region so the regmap > API seemed appropriate here. Indeed, ASV needs only the header + DT change... Then actually we do not need chipid driver at all. Just to print the SoC and provide sysfs entry? If this is the only purpose, then it should be a driver. > Converting the chipid code to platform driver wouldn't make sense as > it wouldn't be useful early in arch/arm/mach-exynos and we can't have > two drivers for same device (the ASV driver matches on the chipid > compatible now). There is no use case for arm/mach-exynos. This code was not resubmitted and I doubt it will be (unless now someone wants to prove I am wrong and sends it again :) ). The two-device case is indeed a problem but it is possible. Clocks are doing it with PMU driver. See CLK_OF_DECLARE_DRIVER(), although I do not remember whether it is maybe obsolete pattern (discouraged). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API 2019-08-21 12:16 ` Krzysztof Kozlowski 2019-08-21 12:41 ` Sylwester Nawrocki @ 2019-08-21 13:31 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 27+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-08-21 13:31 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sylwester Nawrocki, Jon Hunter, Sylwester Nawrocki, robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Marek Szyprowski, linux-tegra, Arnd Bergmann On 8/21/19 2:16 PM, Krzysztof Kozlowski wrote: > On Wed, 21 Aug 2019 at 13:51, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >>>>> Following this change, I am now seeing the above error on our Tegra >>>>> boards where this driver is enabled. This is triggering a kernel >>>>> warnings test we have to fail. Hence, I don't think that you can remove >>>>> the compatible node test here, unless you have a better way to determine >>>>> if this is a samsung device. >>>> >>>> Right, this is really wrong... I missed that it is not a probe but >>>> early init. And this init will be called on every board... Probably it >>>> should be converted to a regular driver. >> >> Early initialization is needed for SoC driver to be used from within >> arch/arm/mach-exynos/ and _initcall() usage is the usual way for SoC >> drivers to be initialized: >> >> drivers/soc/amlogic/meson-gx-socinfo.c >> drivers/soc/amlogic/meson-mx-socinfo.c >> drivers/soc/atmel/soc.c >> drivers/soc/bcm/brcmstb/common.c >> drivers/soc/imx/soc-imx-scu.c >> drivers/soc/imx/soc-imx8.c >> drivers/soc/renesas/renesas-soc.c >> drivers/soc/tegra/fuse/fuse-tegra.c >> drivers/soc/ux500/ux500-soc-id.c >> drivers/soc/versatile/soc-integrator.c >> drivers/soc/versatile/soc-integrator.c >> >> The only SoC drivers that are regular drivers are: >> >> drivers/soc/fsl/guts.c >> drivers/soc/versatile/soc-realview.c > > Thanks for pointing it out. > > Indeed, the initcall was needed in your set of patches here: > https://patchwork.kernel.org/project/linux-samsung-soc/list/?series=43565&state=* > but this work was not continued here. Maybe it will be later > resubmitted... maybe not... who knows? Therefore I would prefer proper The work got delayed mainly because of the request for the formal audit of each usage vs cache coherency. Since it is rather small cleanup and such audit is time consuming it became a low priority. > solution for current case (driver), unless patches for mach are being > brought back to life now. > >>> I'm also inclined to have it converted to a regular driver. We already >>> have "exynos-asv" driver matching on the chipid node (patch 3/9). >>> The ASV patches will not be merged soon anyway, all this needs some more >>> thought. Krzysztof, can we abandon the chipid patches for now? Your >> >> chipid driver is good and useful on its own. The preferred solution >> IMHO would be to just revert "soc: samsung: Convert exynos-chipid >> driver to use the regmap API" commit. Or just fix it by re-adding removed Exynos chipid compatible checking: diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index 006a95feb618..d9912bd52479 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -55,6 +55,11 @@ int __init exynos_chipid_early_init(void) u32 revision; int ret; + /* look up for chipid node */ + np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); + if (!np) + return -ENODEV; + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); if (IS_ERR(regmap)) { pr_err("Failed to get CHIPID regmap\n"); > I queued the chipid as a dependency for ASV but ASV requires the > regmap. What would be left after reverting the regmap part? Simple > unused printk driver? No need for such. If reverting, then let's drop It provides sysfs information about SoC/platform and is useful on its own (for debugging, reporting etc. purposes). Maybe not terrible useful but on OTOH the driver is only ~100 LOC. > entire driver and rework it offline. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki 2019-08-13 15:08 ` [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support Sylwester Nawrocki 2019-08-13 15:08 ` [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-14 12:58 ` Krzysztof Kozlowski 2019-08-13 15:08 ` [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Sylwester Nawrocki ` (6 subsequent siblings) 9 siblings, 1 reply; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki The Adaptive Supply Voltage (ASV) driver adjusts CPU cluster operating points depending on exact revision of an SoC retrieved from the CHIPID block or the OTP memory. This allows for some power saving as for some CPU clock frequencies we can lower CPU cluster supply voltage comparing to safe values common to the all chip revisions. This patch adds support for Exynos5422/5800 SoC, it is partially based on code from https://github.com/hardkernel/linux repository, branch odroidxu4-4.14.y, files: arch/arm/mach-exynos/exynos5422-asv.[ch]. Tested on Odroid XU3, XU4, XU3 Lite. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - Use devm_kzalloc() in probe() to avoid memory leak, - removed leading spaces in exynos-chipid.h, - removed unneeded <linux/init.h> header inclusion, - dropped parentheses from exynos542_asv_parse_sg(), - updated Kconfig entry, - added const attribute to struct exynos_asv_susbsys::cpu_dt_compat. Changes since v1 (RFC): - removed code for parsing the ASV OPP tables from DT, the ASV OPP tables moved to the driver; - converted to use the regmap API; - converted to normal platform driver. --- drivers/soc/samsung/Kconfig | 10 + drivers/soc/samsung/Makefile | 3 + drivers/soc/samsung/exynos-asv.c | 184 ++++++++++ drivers/soc/samsung/exynos-asv.h | 82 +++++ drivers/soc/samsung/exynos5422-asv.c | 498 +++++++++++++++++++++++++++ drivers/soc/samsung/exynos5422-asv.h | 25 ++ 6 files changed, 802 insertions(+) create mode 100644 drivers/soc/samsung/exynos-asv.c create mode 100644 drivers/soc/samsung/exynos-asv.h create mode 100644 drivers/soc/samsung/exynos5422-asv.c create mode 100644 drivers/soc/samsung/exynos5422-asv.h diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig index 2905f5262197..73ccf59676a1 100644 --- a/drivers/soc/samsung/Kconfig +++ b/drivers/soc/samsung/Kconfig @@ -7,6 +7,16 @@ menuconfig SOC_SAMSUNG if SOC_SAMSUNG +config EXYNOS_ASV + bool "Exynos Adaptive Supply Voltage support" if COMPILE_TEST + depends on (ARCH_EXYNOS && EXYNOS_CHIPID) || COMPILE_TEST + select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS + +# There is no need to enable these drivers for ARMv8 +config EXYNOS_ASV_ARM + bool "Exynos ASV ARMv7-specific driver extensions" if COMPILE_TEST + depends on EXYNOS_ASV + config EXYNOS_CHIPID bool "Exynos Chipid controller driver" if COMPILE_TEST depends on ARCH_EXYNOS || COMPILE_TEST diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile index 3b6a8797416c..edd1d6ea064d 100644 --- a/drivers/soc/samsung/Makefile +++ b/drivers/soc/samsung/Makefile @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_EXYNOS_ASV) += exynos-asv.o +obj-$(CONFIG_EXYNOS_ASV_ARM) += exynos5422-asv.o + obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c new file mode 100644 index 000000000000..481deb600afc --- /dev/null +++ b/drivers/soc/samsung/exynos-asv.c @@ -0,0 +1,184 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com> + * + * Samsung Exynos SoC Adaptive Supply Voltage support + */ + +#include <linux/cpu.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/errno.h> +#include <linux/init.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_device.h> +#include <linux/platform_device.h> +#include <linux/pm_opp.h> +#include <linux/regmap.h> +#include <linux/soc/samsung/exynos-chipid.h> + +#include "exynos-asv.h" +#include "exynos5422-asv.h" + +#define MHZ 1000000U + +static int exynos_asv_update_cpu_opps(struct exynos_asv *asv, + struct device *cpu) +{ + struct exynos_asv_subsys *subsys = NULL; + struct dev_pm_opp *opp; + unsigned int opp_freq; + int i; + + for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) { + if (of_device_is_compatible(cpu->of_node, + asv->subsys[i].cpu_dt_compat)) { + subsys = &asv->subsys[i]; + break; + } + } + if (!subsys) + return -EINVAL; + + for (i = 0; i < subsys->table.num_rows; i++) { + unsigned int new_voltage; + unsigned int voltage; + int timeout = 1000; + int err; + + opp_freq = exynos_asv_opp_get_frequency(subsys, i); + + opp = dev_pm_opp_find_freq_exact(cpu, opp_freq * MHZ, true); + if (IS_ERR(opp)) { + dev_info(asv->dev, "cpu%d opp%d, freq: %u missing\n", + cpu->id, i, opp_freq); + + continue; + } + + voltage = dev_pm_opp_get_voltage(opp); + new_voltage = asv->opp_get_voltage(subsys, i, voltage); + dev_pm_opp_put(opp); + + opp_freq *= MHZ; + dev_pm_opp_remove(cpu, opp_freq); + + while (--timeout) { + opp = dev_pm_opp_find_freq_exact(cpu, opp_freq, true); + if (IS_ERR(opp)) + break; + dev_pm_opp_put(opp); + msleep(1); + } + + err = dev_pm_opp_add(cpu, opp_freq, new_voltage); + if (err < 0) + dev_err(asv->dev, + "Failed to add OPP %u Hz/%u uV for cpu%d\n", + opp_freq, new_voltage, cpu->id); + } + + return 0; +} + +static int exynos_asv_update_opps(struct exynos_asv *asv) +{ + struct opp_table *last_opp_table = NULL; + struct device *cpu; + int ret, cpuid; + + for_each_possible_cpu(cpuid) { + struct opp_table *opp_table; + + cpu = get_cpu_device(cpuid); + if (!cpu) + continue; + + opp_table = dev_pm_opp_get_opp_table(cpu); + if (IS_ERR(opp_table)) + continue; + + if (!last_opp_table || opp_table != last_opp_table) { + last_opp_table = opp_table; + + ret = exynos_asv_update_cpu_opps(asv, cpu); + if (ret < 0) + dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n", + cpuid); + } + + dev_pm_opp_put_opp_table(opp_table); + } + + return 0; +} + +static int exynos_asv_probe(struct platform_device *pdev) +{ + int (*probe_func)(struct exynos_asv *asv); + struct exynos_asv *asv; + struct device *cpu_dev; + u32 product_id = 0; + int ret, i; + + cpu_dev = get_cpu_device(0); + ret = dev_pm_opp_get_opp_count(cpu_dev); + if (ret < 0) + return -EPROBE_DEFER; + + asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL); + if (!asv) + return -ENOMEM; + + asv->chipid_regmap = syscon_node_to_regmap(pdev->dev.of_node); + if (IS_ERR(asv->chipid_regmap)) { + dev_err(&pdev->dev, "Could not find syscon regmap\n"); + return PTR_ERR(asv->chipid_regmap); + } + + regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id); + + switch (product_id & EXYNOS_MASK) { + case 0xE5422000: + probe_func = exynos5422_asv_init; + break; + default: + dev_err(&pdev->dev, "Unsupported product ID: %#x", product_id); + return -ENODEV; + } + + ret = of_property_read_u32(pdev->dev.of_node, "samsung,asv-bin", + &asv->of_bin); + if (ret < 0) + asv->of_bin = -EINVAL; + + asv->dev = &pdev->dev; + dev_set_drvdata(&pdev->dev, asv); + + for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) + asv->subsys[i].asv = asv; + + ret = probe_func(asv); + if (ret < 0) + return ret; + + return exynos_asv_update_opps(asv); +} + +static const struct of_device_id exynos_asv_of_device_ids[] = { + { .compatible = "samsung,exynos4210-chipid" }, + {} +}; + +static struct platform_driver exynos_asv_driver = { + .driver = { + .name = "exynos-asv", + .of_match_table = exynos_asv_of_device_ids, + }, + .probe = exynos_asv_probe, +}; +module_platform_driver(exynos_asv_driver); diff --git a/drivers/soc/samsung/exynos-asv.h b/drivers/soc/samsung/exynos-asv.h new file mode 100644 index 000000000000..14b4fedf2ddd --- /dev/null +++ b/drivers/soc/samsung/exynos-asv.h @@ -0,0 +1,82 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com> + * + * Samsung Exynos SoC Adaptive Supply Voltage support + */ +#ifndef __LINUX_SOC_EXYNOS_ASV_H +#define __LINUX_SOC_EXYNOS_ASV_H + +enum { + EXYNOS_ASV_SUBSYS_ID_ARM, + EXYNOS_ASV_SUBSYS_ID_EGL = EXYNOS_ASV_SUBSYS_ID_ARM, + EXYNOS_ASV_SUBSYS_ID_KFC, + EXYNOS_ASV_SUBSYS_ID_INT, + EXYNOS_ASV_SUBSYS_ID_MIF, + EXYNOS_ASV_SUBSYS_ID_G3D, + EXYNOS_ASV_SUBSYS_ID_CAM, + EXYNOS_ASV_SUBSYS_ID_MAX +}; + +struct regmap; + +/* HPM, IDS values to select target group */ +struct asv_limit_entry { + unsigned int hpm; + unsigned int ids; +}; + +struct exynos_asv_table { + unsigned int num_rows; + unsigned int num_cols; + u32 *buf; +}; + +struct exynos_asv_subsys { + struct exynos_asv *asv; + const char *cpu_dt_compat; + int id; + struct exynos_asv_table table; + + unsigned int base_volt; + unsigned int offset_volt_h; + unsigned int offset_volt_l; +}; + +struct exynos_asv { + struct device *dev; + struct regmap *chipid_regmap; + struct exynos_asv_subsys subsys[2]; + + int (*opp_get_voltage)(struct exynos_asv_subsys *subs, int level, + unsigned int voltage); + unsigned int group; + unsigned int table; + + /* True if SG fields from PKG_ID register should be used */ + bool use_sg; + /* ASV bin read from DT */ + int of_bin; +}; + +static inline u32 __asv_get_table_entry(struct exynos_asv_table *table, + unsigned int row, unsigned int col) +{ + return table->buf[row * (table->num_cols) + col]; +} + +static inline u32 exynos_asv_opp_get_voltage(struct exynos_asv_subsys *subsys, + unsigned int level, unsigned int group) +{ + return __asv_get_table_entry(&subsys->table, level, group + 1); +} + +static inline u32 exynos_asv_opp_get_frequency(struct exynos_asv_subsys *subsys, + unsigned int level) +{ + return __asv_get_table_entry(&subsys->table, level, 0); +} + +#endif /* __LINUX_SOC_EXYNOS_ASV_H */ diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c new file mode 100644 index 000000000000..8a56d62fc282 --- /dev/null +++ b/drivers/soc/samsung/exynos5422-asv.c @@ -0,0 +1,498 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * + * Samsung Exynos 5422 SoC Adaptive Supply Voltage support + */ + +#include <linux/bitrev.h> +#include <linux/device.h> +#include <linux/errno.h> +#include <linux/of.h> +#include <linux/regmap.h> +#include <linux/soc/samsung/exynos-chipid.h> +#include <linux/slab.h> + +#include "exynos-asv.h" + +#define ASV_GROUPS_NUM 14 +#define ASV_ARM_DVFS_NUM 20 +#define ASV_ARM_BIN2_DVFS_NUM 17 +#define ASV_KFC_DVFS_NUM 14 +#define ASV_KFC_BIN2_DVFS_NUM 12 + +static const u32 asv_arm_table[][ASV_ARM_DVFS_NUM][ASV_GROUPS_NUM + 1] = { +{ + /* ARM 0, 1 */ + { 2100, 1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000, + 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 }, + { 2000, 1312500, 1312500, 1300000, 1287500, 1275000, 1262500, 1250000, + 1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 }, + { 1900, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000, + 1162500, 1150000, 1162500, 1150000, 1137500, 1125000, 1112500 }, + { 1800, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000, + 1112500, 1100000, 1112500, 1100000, 1087500, 1075000, 1062500 }, + { 1700, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500, + 1075000, 1062500, 1075000, 1062500, 1050000, 1037500, 1025000 }, + { 1600, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000, + 1037500, 1025000, 1037500, 1025000, 1012500, 1000000, 987500 }, + { 1500, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500, + 1000000, 987500, 1000000, 987500, 975000, 962500, 950000 }, + { 1400, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, + 975000, 962500, 975000, 962500, 950000, 937500, 925000 }, + { 1300, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000, + 962500, 950000, 962500, 950000, 937500, 925000, 912500 }, + { 1200, 1025000, 1012500, 1000000, 987500, 975000, 962500, 950000, + 937500, 925000, 937500, 925000, 912500, 900000, 900000 }, + { 1100, 1000000, 987500, 975000, 962500, 950000, 937500, 925000, + 912500, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 1000, 975000, 962500, 950000, 937500, 925000, 912500, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 900, 950000, 937500, 925000, 912500, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 800, 925000, 912500, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 700, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +}, { + /* ARM 2 */ + { 2100, 1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000, + 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 }, + { 2000, 1312500, 1312500, 1312500, 1300000, 1275000, 1262500, 1250000, + 1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 }, + { 1900, 1262500, 1250000, 1250000, 1237500, 1212500, 1200000, 1187500, + 1175000, 1162500, 1175000, 1162500, 1150000, 1137500, 1125000 }, + { 1800, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500, + 1125000, 1112500, 1125000, 1112500, 1100000, 1087500, 1075000 }, + { 1700, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, + 1087500, 1075000, 1087500, 1075000, 1062500, 1050000, 1037500 }, + { 1600, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, + 1050000, 1037500, 1050000, 1037500, 1025000, 1012500, 1000000 }, + { 1500, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, + 1012500, 1000000, 1012500, 1000000, 987500, 975000, 962500 }, + { 1400, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, + 987500, 975000, 987500, 975000, 962500, 950000, 937500 }, + { 1300, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000, + 962500, 950000, 962500, 950000, 937500, 925000, 912500 }, + { 1200, 1025000, 1012500, 1000000, 987500, 975000, 962500, 950000, + 937500, 925000, 937500, 925000, 912500, 900000, 900000 }, + { 1100, 1000000, 987500, 975000, 962500, 950000, 937500, 925000, + 912500, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 1000, 975000, 962500, 950000, 937500, 925000, 912500, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 900, 950000, 937500, 925000, 912500, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 800, 925000, 912500, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 700, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +}, { + /* ARM 3 */ + { 2100, 1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000, + 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 }, + { 2000, 1312500, 1312500, 1300000, 1287500, 1275000, 1262500, 1250000, + 1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 }, + { 1900, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500, + 1175000, 1162500, 1175000, 1162500, 1150000, 1137500, 1125000 }, + { 1800, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500, + 1125000, 1112500, 1125000, 1112500, 1100000, 1087500, 1075000 }, + { 1700, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, + 1087500, 1075000, 1087500, 1075000, 1062500, 1050000, 1037500 }, + { 1600, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, + 1050000, 1037500, 1050000, 1037500, 1025000, 1012500, 1000000 }, + { 1500, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, + 1012500, 1000000, 1012500, 1000000, 987500, 975000, 962500 }, + { 1400, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, + 987500, 975000, 987500, 975000, 962500, 950000, 937500 }, + { 1300, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000, + 962500, 950000, 962500, 950000, 937500, 925000, 912500 }, + { 1200, 1025000, 1012500, 1000000, 987500, 975000, 962500, 950000, + 937500, 925000, 937500, 925000, 912500, 900000, 900000 }, + { 1100, 1000000, 987500, 975000, 962500, 950000, 937500, 925000, + 912500, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 1000, 975000, 962500, 950000, 937500, 925000, 912500, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 900, 950000, 937500, 925000, 912500, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 800, 925000, 912500, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 700, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +}, { + /* ARM bin 2 */ + { 1800, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500, + 1150000, 1137500, 1150000, 1137500, 1125000, 1112500, 1100000 }, + { 1700, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000, + 1112500, 1100000, 1112500, 1100000, 1087500, 1075000, 1062500 }, + { 1600, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500, + 1075000, 1062500, 1075000, 1062500, 1050000, 1037500, 1025000 }, + { 1500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000, + 1037500, 1025000, 1037500, 1025000, 1012500, 1000000, 987500 }, + { 1400, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, + 1012500, 1000000, 1012500, 1000000, 987500, 975000, 962500 }, + { 1300, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500, + 1000000, 987500, 1000000, 987500, 975000, 962500, 950000 }, + { 1200, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, + 975000, 962500, 975000, 962500, 950000, 937500, 925000 }, + { 1100, 1037500, 1025000, 1012500, 1000000, 987500, 975000, 962500, + 950000, 937500, 950000, 937500, 925000, 912500, 900000 }, + { 1000, 1012500, 1000000, 987500, 975000, 962500, 950000, 937500, + 925000, 912500, 925000, 912500, 900000, 900000, 900000 }, + { 900, 987500, 975000, 962500, 950000, 937500, 925000, 912500, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 800, 962500, 950000, 937500, 925000, 912500, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 700, 937500, 925000, 912500, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +} +}; + +static const u32 asv_kfc_table[][ASV_KFC_DVFS_NUM][ASV_GROUPS_NUM + 1] = { +{ + /* KFC 0, 1 */ + { 1500000, 1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000, + 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 }, + { 1400000, 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, + 1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 }, + { 1300000, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000, + 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 }, + { 1200000, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, + 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 }, + { 1100000, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, + 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000 }, + { 1000000, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, + 1012500, 1000000, 987500, 975000, 962500, 950000, 937500 }, + { 900000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, + 975000, 962500, 950000, 937500, 925000, 912500, 900000 }, + { 800000, 1025000, 1012500, 1000000, 987500, 975000, 962500, 950000, + 937500, 925000, 912500, 900000, 900000, 900000, 900000 }, + { 700000, 987500, 975000, 962500, 950000, 937500, 925000, 912500, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600000, 950000, 937500, 925000, 912500, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500000, 912500, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400000, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300000, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200000, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +}, { + /* KFC 2 */ + { 1500, 1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000, + 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 }, + { 1400, 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, + 1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 }, + { 1300, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000, + 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 }, + { 1200, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, + 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 }, + { 1100, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, + 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000 }, + { 1000, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, + 1012500, 1000000, 987500, 975000, 962500, 950000, 937500 }, + { 900, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, + 975000, 962500, 950000, 937500, 925000, 912500, 900000 }, + { 800, 1025000, 1012500, 1000000, 987500, 975000, 962500, 950000, + 937500, 925000, 912500, 900000, 900000, 900000, 900000 }, + { 700, 987500, 975000, 962500, 950000, 937500, 925000, 912500, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600, 950000, 937500, 925000, 912500, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 912500, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +}, { + /* KFC 3 */ + { 1500, 1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000, + 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 }, + { 1400, 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000, + 1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 }, + { 1300, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000, + 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 }, + { 1200, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, + 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 }, + { 1100, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, + 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000 }, + { 1000, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, + 1012500, 1000000, 987500, 975000, 962500, 950000, 937500 }, + { 900, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, + 975000, 962500, 950000, 937500, 925000, 912500, 900000 }, + { 800, 1025000, 1012500, 1000000, 987500, 975000, 962500, 950000, + 937500, 925000, 912500, 900000, 900000, 900000, 900000 }, + { 700, 987500, 975000, 962500, 950000, 937500, 925000, 912500, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 600, 950000, 937500, 925000, 912500, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 912500, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +}, { + /* KFC bin 2 */ + { 1300, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000, + 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500 }, + { 1200, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000, + 1112500, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500 }, + { 1100, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500, + 1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000 }, + { 1000, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000, + 1037500, 1025000, 1012500, 1000000, 987500, 975000, 962500 }, + { 900, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500, + 1000000, 987500, 975000, 962500, 950000, 937500, 925000 }, + { 800, 1050000, 1037500, 1025000, 1012500, 1000000, 987500, 975000, + 962500, 950000, 937500, 925000, 912500, 900000, 900000 }, + { 700, 1012500, 1000000, 987500, 975000, 962500, 950000, 937500, + 925000, 912500, 900000, 900000, 900000, 900000, 900000 }, + { 600, 975000, 962500, 950000, 937500, 925000, 912500, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 500, 937500, 925000, 912500, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 400, 925000, 912500, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 300, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, + { 200, 900000, 900000, 900000, 900000, 900000, 900000, 900000, + 900000, 900000, 900000, 900000, 900000, 900000, 900000 }, +} +}; + +static const struct asv_limit_entry __asv_limits[ASV_GROUPS_NUM] = { + { 13, 55 }, + { 21, 65 }, + { 25, 69 }, + { 30, 72 }, + { 36, 74 }, + { 43, 76 }, + { 51, 78 }, + { 65, 80 }, + { 81, 82 }, + { 98, 84 }, + { 119, 87 }, + { 135, 89 }, + { 150, 92 }, + { 999, 999 }, +}; + +static int exynos5422_asv_get_group(struct exynos_asv *asv) +{ + unsigned int pkgid_reg, auxi_reg; + int hpm, ids, i; + + regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkgid_reg); + regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_AUX_INFO, &auxi_reg); + + if (asv->use_sg) { + u32 sga = (pkgid_reg >> EXYNOS5422_SG_A_OFFSET) & + EXYNOS5422_SG_A_MASK; + + u32 sgb = (pkgid_reg >> EXYNOS5422_SG_B_OFFSET) & + EXYNOS5422_SG_B_MASK; + + if ((pkgid_reg >> EXYNOS5422_SG_BSIGN_OFFSET) & + EXYNOS5422_SG_BSIGN_MASK) + return sga + sgb; + else + return sga - sgb; + } + + hpm = (auxi_reg >> EXYNOS5422_TMCB_OFFSET) & EXYNOS5422_TMCB_MASK; + ids = (pkgid_reg >> EXYNOS5422_IDS_OFFSET) & EXYNOS5422_IDS_MASK; + + for (i = 0; i < ASV_GROUPS_NUM; i++) { + if (ids <= __asv_limits[i].ids) + break; + if (hpm <= __asv_limits[i].hpm) + break; + } + if (i < ASV_GROUPS_NUM) + return i; + + return 0; +} + +static int __asv_offset_voltage(unsigned int index) +{ + switch (index) { + case 1: + return 12500; + case 2: + return 50000; + case 3: + return 25000; + default: + return 0; + }; +} + +static void exynos5422_asv_offset_voltage_setup(struct exynos_asv *asv) +{ + struct exynos_asv_subsys *subsys; + unsigned int reg, value; + + regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_AUX_INFO, ®); + + /* ARM offset voltage setup */ + subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_ARM]; + + subsys->base_volt = 1000000; + + value = (reg >> EXYNOS5422_ARM_UP_OFFSET) & EXYNOS5422_ARM_UP_MASK; + subsys->offset_volt_h = __asv_offset_voltage(value); + + value = (reg >> EXYNOS5422_ARM_DN_OFFSET) & EXYNOS5422_ARM_DN_MASK; + subsys->offset_volt_l = __asv_offset_voltage(value); + + /* KFC offset voltage setup */ + subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_KFC]; + + subsys->base_volt = 1000000; + + value = (reg >> EXYNOS5422_KFC_UP_OFFSET) & EXYNOS5422_KFC_UP_MASK; + subsys->offset_volt_h = __asv_offset_voltage(value); + + value = (reg >> EXYNOS5422_KFC_DN_OFFSET) & EXYNOS5422_KFC_DN_MASK; + subsys->offset_volt_l = __asv_offset_voltage(value); +} + +static int exynos5422_asv_opp_get_voltage(struct exynos_asv_subsys *subsys, + int level, unsigned int volt) +{ + unsigned int asv_volt; + + if (level >= subsys->table.num_rows) + return volt; + + asv_volt = exynos_asv_opp_get_voltage(subsys, level, + subsys->asv->group); + + if (volt > subsys->base_volt) + asv_volt += subsys->offset_volt_h; + else + asv_volt += subsys->offset_volt_l; + + return asv_volt; +} + +static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv, + unsigned int pkg_id) +{ + return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK; +} + +static bool exynos5422_asv_parse_bin2(struct exynos_asv *asv, + unsigned int pkg_id) +{ + return (pkg_id >> EXYNOS5422_BIN2_OFFSET) & EXYNOS5422_BIN2_MASK; +} + +static bool exynos5422_asv_parse_sg(struct exynos_asv *asv, + unsigned int pkg_id) +{ + return (pkg_id >> EXYNOS5422_USESG_OFFSET) & EXYNOS5422_USESG_MASK; +} + +int exynos5422_asv_init(struct exynos_asv *asv) +{ + struct exynos_asv_subsys *subsys; + unsigned int table_index; + unsigned int pkg_id; + bool bin2; + + regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkg_id); + + if (asv->of_bin == 2) { + bin2 = true; + asv->use_sg = false; + } else { + asv->use_sg = exynos5422_asv_parse_sg(asv, pkg_id); + bin2 = exynos5422_asv_parse_bin2(asv, pkg_id); + } + + asv->group = exynos5422_asv_get_group(asv); + asv->table = exynos5422_asv_parse_table(asv, pkg_id); + + exynos5422_asv_offset_voltage_setup(asv); + + if (bin2) { + table_index = 3; + } else { + if (asv->table == 2 || asv->table == 3) + table_index = asv->table - 1; + else + table_index = 0; + } + + subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_ARM]; + subsys->cpu_dt_compat = "arm,cortex-a15"; + if (bin2) + subsys->table.num_rows = ASV_ARM_BIN2_DVFS_NUM; + else + subsys->table.num_rows = ASV_ARM_DVFS_NUM; + subsys->table.num_cols = ASV_GROUPS_NUM + 1; + subsys->table.buf = (u32 *)asv_arm_table[table_index]; + + subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_KFC]; + subsys->cpu_dt_compat = "arm,cortex-a7"; + if (bin2) + subsys->table.num_rows = ASV_KFC_BIN2_DVFS_NUM; + else + subsys->table.num_rows = ASV_KFC_DVFS_NUM; + subsys->table.num_cols = ASV_GROUPS_NUM + 1; + subsys->table.buf = (u32 *)asv_kfc_table[table_index]; + + asv->opp_get_voltage = exynos5422_asv_opp_get_voltage; + + return 0; +} diff --git a/drivers/soc/samsung/exynos5422-asv.h b/drivers/soc/samsung/exynos5422-asv.h new file mode 100644 index 000000000000..d8f108fcc39b --- /dev/null +++ b/drivers/soc/samsung/exynos5422-asv.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2019 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * + * Samsung Exynos 5422 SoC Adaptive Supply Voltage support + */ + +#ifndef __EXYNOS5422_ASV_H +#define __EXYNOS5422_ASV_H + +#include <linux/errno.h> + +struct exynos_asv; + +#ifdef CONFIG_EXYNOS_ASV_ARM +int exynos5422_asv_init(struct exynos_asv *asv); +#else +static inline int exynos5422_asv_init(struct exynos_asv *asv) +{ + return -ENOTSUPP; +} +#endif + +#endif /* __EXYNOS5422_ASV_H */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver 2019-08-13 15:08 ` [PATCH v3 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki @ 2019-08-14 12:58 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-14 12:58 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Bartłomiej Żołnierkiewicz, Marek Szyprowski On Tue, 13 Aug 2019 at 17:08, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > The Adaptive Supply Voltage (ASV) driver adjusts CPU cluster operating > points depending on exact revision of an SoC retrieved from the CHIPID > block or the OTP memory. This allows for some power saving as for some > CPU clock frequencies we can lower CPU cluster supply voltage comparing > to safe values common to the all chip revisions. > > This patch adds support for Exynos5422/5800 SoC, it is partially based > on code from https://github.com/hardkernel/linux repository, > branch odroidxu4-4.14.y, files: arch/arm/mach-exynos/exynos5422-asv.[ch]. > > Tested on Odroid XU3, XU4, XU3 Lite. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - Use devm_kzalloc() in probe() to avoid memory leak, > - removed leading spaces in exynos-chipid.h, > - removed unneeded <linux/init.h> header inclusion, > - dropped parentheses from exynos542_asv_parse_sg(), > - updated Kconfig entry, > - added const attribute to struct exynos_asv_susbsys::cpu_dt_compat. > > Changes since v1 (RFC): > - removed code for parsing the ASV OPP tables from DT, the ASV OPP tables > moved to the driver; > - converted to use the regmap API; > - converted to normal platform driver. > --- > drivers/soc/samsung/Kconfig | 10 + > drivers/soc/samsung/Makefile | 3 + > drivers/soc/samsung/exynos-asv.c | 184 ++++++++++ > drivers/soc/samsung/exynos-asv.h | 82 +++++ > drivers/soc/samsung/exynos5422-asv.c | 498 +++++++++++++++++++++++++++ > drivers/soc/samsung/exynos5422-asv.h | 25 ++ > 6 files changed, 802 insertions(+) > create mode 100644 drivers/soc/samsung/exynos-asv.c > create mode 100644 drivers/soc/samsung/exynos-asv.h > create mode 100644 drivers/soc/samsung/exynos5422-asv.c > create mode 100644 drivers/soc/samsung/exynos5422-asv.h > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 2905f5262197..73ccf59676a1 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -7,6 +7,16 @@ menuconfig SOC_SAMSUNG > > if SOC_SAMSUNG > > +config EXYNOS_ASV > + bool "Exynos Adaptive Supply Voltage support" if COMPILE_TEST > + depends on (ARCH_EXYNOS && EXYNOS_CHIPID) || COMPILE_TEST > + select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS > + > +# There is no need to enable these drivers for ARMv8 > +config EXYNOS_ASV_ARM > + bool "Exynos ASV ARMv7-specific driver extensions" if COMPILE_TEST > + depends on EXYNOS_ASV > + > config EXYNOS_CHIPID > bool "Exynos Chipid controller driver" if COMPILE_TEST > depends on ARCH_EXYNOS || COMPILE_TEST > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 3b6a8797416c..edd1d6ea064d 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,5 +1,8 @@ > # SPDX-License-Identifier: GPL-2.0 > > +obj-$(CONFIG_EXYNOS_ASV) += exynos-asv.o > +obj-$(CONFIG_EXYNOS_ASV_ARM) += exynos5422-asv.o > + > obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o > > diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c > new file mode 100644 > index 000000000000..481deb600afc > --- /dev/null > +++ b/drivers/soc/samsung/exynos-asv.c > @@ -0,0 +1,184 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019 Samsung Electronics Co., Ltd. > + * http://www.samsung.com/ > + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com> > + * > + * Samsung Exynos SoC Adaptive Supply Voltage support > + */ > + > +#include <linux/cpu.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/errno.h> > +#include <linux/init.h> > +#include <linux/mfd/syscon.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/platform_device.h> > +#include <linux/pm_opp.h> > +#include <linux/regmap.h> > +#include <linux/soc/samsung/exynos-chipid.h> > + > +#include "exynos-asv.h" > +#include "exynos5422-asv.h" > + > +#define MHZ 1000000U > + > +static int exynos_asv_update_cpu_opps(struct exynos_asv *asv, > + struct device *cpu) > +{ > + struct exynos_asv_subsys *subsys = NULL; > + struct dev_pm_opp *opp; > + unsigned int opp_freq; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) { > + if (of_device_is_compatible(cpu->of_node, > + asv->subsys[i].cpu_dt_compat)) { > + subsys = &asv->subsys[i]; > + break; > + } > + } > + if (!subsys) > + return -EINVAL; > + > + for (i = 0; i < subsys->table.num_rows; i++) { > + unsigned int new_voltage; > + unsigned int voltage; > + int timeout = 1000; > + int err; > + > + opp_freq = exynos_asv_opp_get_frequency(subsys, i); > + > + opp = dev_pm_opp_find_freq_exact(cpu, opp_freq * MHZ, true); > + if (IS_ERR(opp)) { > + dev_info(asv->dev, "cpu%d opp%d, freq: %u missing\n", > + cpu->id, i, opp_freq); > + > + continue; > + } > + > + voltage = dev_pm_opp_get_voltage(opp); > + new_voltage = asv->opp_get_voltage(subsys, i, voltage); > + dev_pm_opp_put(opp); > + > + opp_freq *= MHZ; > + dev_pm_opp_remove(cpu, opp_freq); > + > + while (--timeout) { > + opp = dev_pm_opp_find_freq_exact(cpu, opp_freq, true); > + if (IS_ERR(opp)) > + break; > + dev_pm_opp_put(opp); > + msleep(1); > + } > + > + err = dev_pm_opp_add(cpu, opp_freq, new_voltage); > + if (err < 0) > + dev_err(asv->dev, > + "Failed to add OPP %u Hz/%u uV for cpu%d\n", > + opp_freq, new_voltage, cpu->id); > + } > + > + return 0; > +} > + > +static int exynos_asv_update_opps(struct exynos_asv *asv) > +{ > + struct opp_table *last_opp_table = NULL; > + struct device *cpu; > + int ret, cpuid; > + > + for_each_possible_cpu(cpuid) { > + struct opp_table *opp_table; > + > + cpu = get_cpu_device(cpuid); > + if (!cpu) > + continue; > + > + opp_table = dev_pm_opp_get_opp_table(cpu); > + if (IS_ERR(opp_table)) > + continue; > + > + if (!last_opp_table || opp_table != last_opp_table) { > + last_opp_table = opp_table; > + > + ret = exynos_asv_update_cpu_opps(asv, cpu); > + if (ret < 0) > + dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n", > + cpuid); > + } > + > + dev_pm_opp_put_opp_table(opp_table); > + } > + > + return 0; > +} > + > +static int exynos_asv_probe(struct platform_device *pdev) > +{ > + int (*probe_func)(struct exynos_asv *asv); > + struct exynos_asv *asv; > + struct device *cpu_dev; > + u32 product_id = 0; > + int ret, i; > + > + cpu_dev = get_cpu_device(0); > + ret = dev_pm_opp_get_opp_count(cpu_dev); > + if (ret < 0) > + return -EPROBE_DEFER; > + > + asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL); > + if (!asv) > + return -ENOMEM; > + > + asv->chipid_regmap = syscon_node_to_regmap(pdev->dev.of_node); > + if (IS_ERR(asv->chipid_regmap)) { > + dev_err(&pdev->dev, "Could not find syscon regmap\n"); > + return PTR_ERR(asv->chipid_regmap); > + } > + > + regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id); > + > + switch (product_id & EXYNOS_MASK) { > + case 0xE5422000: > + probe_func = exynos5422_asv_init; > + break; > + default: > + dev_err(&pdev->dev, "Unsupported product ID: %#x", product_id); > + return -ENODEV; > + } > + > + ret = of_property_read_u32(pdev->dev.of_node, "samsung,asv-bin", > + &asv->of_bin); > + if (ret < 0) > + asv->of_bin = -EINVAL; > + > + asv->dev = &pdev->dev; > + dev_set_drvdata(&pdev->dev, asv); > + > + for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) > + asv->subsys[i].asv = asv; > + > + ret = probe_func(asv); > + if (ret < 0) > + return ret; > + > + return exynos_asv_update_opps(asv); > +} > + > +static const struct of_device_id exynos_asv_of_device_ids[] = { > + { .compatible = "samsung,exynos4210-chipid" }, > + {} > +}; > + > +static struct platform_driver exynos_asv_driver = { > + .driver = { > + .name = "exynos-asv", > + .of_match_table = exynos_asv_of_device_ids, > + }, > + .probe = exynos_asv_probe, > +}; > +module_platform_driver(exynos_asv_driver); > diff --git a/drivers/soc/samsung/exynos-asv.h b/drivers/soc/samsung/exynos-asv.h > new file mode 100644 > index 000000000000..14b4fedf2ddd > --- /dev/null > +++ b/drivers/soc/samsung/exynos-asv.h > @@ -0,0 +1,82 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2019 Samsung Electronics Co., Ltd. > + * http://www.samsung.com/ > + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com> > + * > + * Samsung Exynos SoC Adaptive Supply Voltage support > + */ > +#ifndef __LINUX_SOC_EXYNOS_ASV_H > +#define __LINUX_SOC_EXYNOS_ASV_H Yikes, that was my mistake. The file is in drivers/soc, not include, so this could stay as previous one. Or make more path dependend - __DRIVERS_SOC... Now it is inconsistent with drivers/soc/samsung/exynos5422-asv.h. I can fixup these two files while applying but if there is going to be a resend, then change both to __DRIVERS_SOC_..._H. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (2 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-15 18:29 ` Krzysztof Kozlowski 2019-08-13 15:08 ` [PATCH v3 5/9] ARM64: " Sylwester Nawrocki ` (5 subsequent siblings) 9 siblings, 1 reply; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki From: Pankaj Dubey <pankaj.dubey@samsung.com> As now we have chipid driver to initialize SoC related information let's include it in build by default. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v1 (RFC): - none --- arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index d7422233a130..f83786640f94 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -13,6 +13,7 @@ menuconfig ARCH_EXYNOS select ARM_AMBA select ARM_GIC select COMMON_CLK_SAMSUNG + select EXYNOS_CHIPID select EXYNOS_THERMAL select EXYNOS_PMU select EXYNOS_SROM -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS 2019-08-13 15:08 ` [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Sylwester Nawrocki @ 2019-08-15 18:29 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-15 18:29 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski On Tue, Aug 13, 2019 at 05:08:22PM +0200, Sylwester Nawrocki wrote: > From: Pankaj Dubey <pankaj.dubey@samsung.com> > > As now we have chipid driver to initialize SoC related information > let's include it in build by default. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1 (RFC): Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 5/9] ARM64: EXYNOS: enable exynos_chipid for ARCH_EXYNOS 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (3 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-15 18:29 ` Krzysztof Kozlowski 2019-08-13 15:08 ` [PATCH v3 6/9] ARM: EXYNOS: Enable exynos-asv driver " Sylwester Nawrocki ` (4 subsequent siblings) 9 siblings, 1 reply; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki From: Pankaj Dubey <pankaj.dubey@samsung.com> This patch enables exynos_chipid driver for ARCH_EXYNOS based SoC. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v1 (RFC): - none --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 4778c775de1b..8a098fb4f04c 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -77,6 +77,7 @@ config ARCH_BRCMSTB config ARCH_EXYNOS bool "ARMv8 based Samsung Exynos SoC family" select COMMON_CLK_SAMSUNG + select EXYNOS_CHIPID select EXYNOS_PM_DOMAINS if PM_GENERIC_DOMAINS select EXYNOS_PMU select HAVE_S3C2410_WATCHDOG if WATCHDOG -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 5/9] ARM64: EXYNOS: enable exynos_chipid for ARCH_EXYNOS 2019-08-13 15:08 ` [PATCH v3 5/9] ARM64: " Sylwester Nawrocki @ 2019-08-15 18:29 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-15 18:29 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski On Tue, Aug 13, 2019 at 05:08:23PM +0200, Sylwester Nawrocki wrote: > From: Pankaj Dubey <pankaj.dubey@samsung.com> > > This patch enables exynos_chipid driver for ARCH_EXYNOS > based SoC. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1 (RFC): > - none > --- > arch/arm64/Kconfig.platforms | 1 + Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 6/9] ARM: EXYNOS: Enable exynos-asv driver for ARCH_EXYNOS 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (4 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 5/9] ARM64: " Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-13 15:08 ` [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation Sylwester Nawrocki ` (3 subsequent siblings) 9 siblings, 0 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki Enable exynos-asv driver for Exynos 32-bit SoCs. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v1 (RFC): - none --- arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index f83786640f94..bba61354c340 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -13,6 +13,7 @@ menuconfig ARCH_EXYNOS select ARM_AMBA select ARM_GIC select COMMON_CLK_SAMSUNG + select EXYNOS_ASV select EXYNOS_CHIPID select EXYNOS_THERMAL select EXYNOS_PMU -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (5 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 6/9] ARM: EXYNOS: Enable exynos-asv driver " Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-14 13:00 ` Krzysztof Kozlowski 2019-08-15 18:24 ` Krzysztof Kozlowski 2019-08-13 15:08 ` [PATCH v3 8/9] ARM: dts: Add "syscon" compatible string to chipid node Sylwester Nawrocki ` (2 subsequent siblings) 9 siblings, 2 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki This patch adds documentation of a new optional "samsung,asv-bin" property in the chipid device node and documents requirement of "syscon" compatible string. These additions are needed to support Exynos ASV (Adaptive Supply Voltage) feature. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - none Changes since v1 (RFC): - new patch --- .../devicetree/bindings/arm/samsung/exynos-chipid.txt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt index 85c5dfd4a720..be3657e6c00c 100644 --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt @@ -1,12 +1,18 @@ -SAMSUNG Exynos SoCs Chipid driver. +SAMSUNG Exynos SoC series CHIPID subsystem Required properties: -- compatible : Should at least contain "samsung,exynos4210-chipid". +- compatible : Should at least contain "samsung,exynos4210-chipid", "syscon". - reg: offset and length of the register set +Optional properties: + - samsung,asv-bin : Adaptive Supply Voltage bin selection. This can be used + to determine the ASV bin of an SoC if respective information is missing + in the CHIPID registers or in the OTP memory. Possible values: 0...3. + Example: chipid@10000000 { compatible = "samsung,exynos4210-chipid"; reg = <0x10000000 0x100>; + samsung,asv-bin = <2>; }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation 2019-08-13 15:08 ` [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation Sylwester Nawrocki @ 2019-08-14 13:00 ` Krzysztof Kozlowski 2019-08-15 18:24 ` Krzysztof Kozlowski 1 sibling, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-14 13:00 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Bartłomiej Żołnierkiewicz, Marek Szyprowski On Tue, 13 Aug 2019 at 17:09, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > This patch adds documentation of a new optional "samsung,asv-bin" > property in the chipid device node and documents requirement of > "syscon" compatible string. These additions are needed to support > Exynos ASV (Adaptive Supply Voltage) feature. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - none > > Changes since v1 (RFC): > - new patch > --- > .../devicetree/bindings/arm/samsung/exynos-chipid.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt > index 85c5dfd4a720..be3657e6c00c 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.txt > @@ -1,12 +1,18 @@ > -SAMSUNG Exynos SoCs Chipid driver. > +SAMSUNG Exynos SoC series CHIPID subsystem > > Required properties: > -- compatible : Should at least contain "samsung,exynos4210-chipid". > +- compatible : Should at least contain "samsung,exynos4210-chipid", "syscon". > > - reg: offset and length of the register set > > +Optional properties: > + - samsung,asv-bin : Adaptive Supply Voltage bin selection. This can be used > + to determine the ASV bin of an SoC if respective information is missing > + in the CHIPID registers or in the OTP memory. Possible values: 0...3. > + > Example: > chipid@10000000 { > compatible = "samsung,exynos4210-chipid"; Please update the example with new required compatible. Best regards, Krzysztof > reg = <0x10000000 0x100>; > + samsung,asv-bin = <2>; > }; > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation 2019-08-13 15:08 ` [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation Sylwester Nawrocki 2019-08-14 13:00 ` Krzysztof Kozlowski @ 2019-08-15 18:24 ` Krzysztof Kozlowski 1 sibling, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-15 18:24 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski On Tue, Aug 13, 2019 at 05:08:25PM +0200, Sylwester Nawrocki wrote: > This patch adds documentation of a new optional "samsung,asv-bin" > property in the chipid device node and documents requirement of > "syscon" compatible string. These additions are needed to support > Exynos ASV (Adaptive Supply Voltage) feature. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > - none > > Changes since v1 (RFC): Title should match bindings, so: dt-bindings: samsung: Also please put it before the driver change using these bindings. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v3 8/9] ARM: dts: Add "syscon" compatible string to chipid node 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (6 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-13 15:08 ` [PATCH v3 9/9] ARM: dts: Add samsung,asv-bin property for odroidxu3-lite Sylwester Nawrocki 2019-08-14 13:03 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Krzysztof Kozlowski 9 siblings, 0 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki The CHIP ID block in addition to exact chip revision information contains data and control registers for ASV (Adaptive Supply Voltage) and ABB (Adaptive Body Bias). Add "syscon" compatible so the CHIPID block can be shared by respective drivers. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - none Changes since v1 (RFC): - new patch --- arch/arm/boot/dts/exynos5.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index 67f9b4504a42..4801ca759feb 100644 --- a/arch/arm/boot/dts/exynos5.dtsi +++ b/arch/arm/boot/dts/exynos5.dtsi @@ -35,8 +35,8 @@ #size-cells = <1>; ranges; - chipid@10000000 { - compatible = "samsung,exynos4210-chipid"; + chipid: chipid@10000000 { + compatible = "samsung,exynos4210-chipid", "syscon"; reg = <0x10000000 0x100>; }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v3 9/9] ARM: dts: Add samsung,asv-bin property for odroidxu3-lite 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (7 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 8/9] ARM: dts: Add "syscon" compatible string to chipid node Sylwester Nawrocki @ 2019-08-13 15:08 ` Sylwester Nawrocki 2019-08-14 13:03 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Krzysztof Kozlowski 9 siblings, 0 replies; 27+ messages in thread From: Sylwester Nawrocki @ 2019-08-13 15:08 UTC (permalink / raw) To: krzk Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc, linux-arm-kernel, linux-kernel, linux-pm, b.zolnierkie, m.szyprowski, Sylwester Nawrocki The Exynos5422 SoC used on Odroid XU3 Lite boards belongs to a special ASV bin but this information cannot be read from the CHIPID block registers. Add samsung,asv-bin property for XU3 Lite to ensure the ASV bin is properly determined. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - none Changes since v1 (RFC): - new patch --- arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts index c19b5a51ca44..a31ca2ef750f 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts @@ -26,6 +26,10 @@ status = "disabled"; }; +&chipid { + samsung,asv-bin = <2>; +}; + &pwm { /* * PWM 0 -- fan -- 2.17.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v3 0/9] Exynos Adaptive Supply Voltage support 2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki ` (8 preceding siblings ...) 2019-08-13 15:08 ` [PATCH v3 9/9] ARM: dts: Add samsung,asv-bin property for odroidxu3-lite Sylwester Nawrocki @ 2019-08-14 13:03 ` Krzysztof Kozlowski 9 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2019-08-14 13:03 UTC (permalink / raw) To: Sylwester Nawrocki Cc: robh+dt, vireshk, devicetree, kgene, pankaj.dubey, linux-samsung-soc@vger.kernel.org, linux-arm-kernel, linux-kernel@vger.kernel.org, linux-pm, Bartłomiej Żołnierkiewicz, Marek Szyprowski On Tue, 13 Aug 2019 at 17:08, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > This is third iteration of my patch series adding ASV (Adaptive Supply > Voltage) support for Exynos SoCs. The previous one can be found at: > https://lore.kernel.org/lkml/20190718143044.25066-1-s.nawrocki@samsung.com > > There is no major changes in this series comparing to v2, only minor > corrections addressing review comments. > > I was not sure it was a good idea to try to extend the OPP binding > so as to include the ASV data tables in DT, so the tables are left > in the driver. > > This patch set includes Exynos CHIPID driver posted by Pankaj Dubey and > futher improved by Bartłomiej Żołnierkiewicz [1]. > > Tested on Odroid XU3, XU3 Lite, XU4. > > One of the things on TODO list is support for the Adaptive Body Bias. > This will require modifications on the cpufreq driver side in order to > support multiple voltage regulators and changes in the OPP framework > to support adding OPPs with multiple voltages. > > [1] https://lkml.org/lkml/2018/11/15/908 > > Pankaj Dubey (3): > soc: samsung: Add exynos chipid driver support > ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS > ARM64: EXYNOS: enable exynos_chipid for ARCH_EXYNOS > > Sylwester Nawrocki (6): > soc: samsung: Convert exynos-chipid driver to use the regmap API > soc: samsung: Add Exynos Adaptive Supply Voltage driver > ARM: EXYNOS: Enable exynos-asv driver for ARCH_EXYNOS > soc: samsung: Update the CHIP ID DT binding documentation > ARM: dts: Add "syscon" compatible string to chipid node > ARM: dts: Add samsung,asv-bin property for odroidxu3-lite All look good to me but I need acks for bindings before applying. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2019-08-21 13:31 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20190813150842eucas1p2c248537d9cd593073e12abeac2cacab5@eucas1p2.samsung.com>
2019-08-13 15:08 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki
2019-08-13 15:08 ` [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support Sylwester Nawrocki
2019-08-15 18:18 ` Krzysztof Kozlowski
2019-08-13 15:08 ` [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API Sylwester Nawrocki
2019-08-15 18:22 ` Krzysztof Kozlowski
2019-08-20 19:24 ` Jon Hunter
2019-08-20 19:37 ` Krzysztof Kozlowski
2019-08-20 21:38 ` Sylwester Nawrocki
2019-08-21 7:49 ` Krzysztof Kozlowski
2019-08-21 11:51 ` Bartlomiej Zolnierkiewicz
2019-08-21 12:16 ` Krzysztof Kozlowski
2019-08-21 12:41 ` Sylwester Nawrocki
2019-08-21 13:10 ` Krzysztof Kozlowski
2019-08-21 13:31 ` Bartlomiej Zolnierkiewicz
2019-08-13 15:08 ` [PATCH v3 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki
2019-08-14 12:58 ` Krzysztof Kozlowski
2019-08-13 15:08 ` [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Sylwester Nawrocki
2019-08-15 18:29 ` Krzysztof Kozlowski
2019-08-13 15:08 ` [PATCH v3 5/9] ARM64: " Sylwester Nawrocki
2019-08-15 18:29 ` Krzysztof Kozlowski
2019-08-13 15:08 ` [PATCH v3 6/9] ARM: EXYNOS: Enable exynos-asv driver " Sylwester Nawrocki
2019-08-13 15:08 ` [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation Sylwester Nawrocki
2019-08-14 13:00 ` Krzysztof Kozlowski
2019-08-15 18:24 ` Krzysztof Kozlowski
2019-08-13 15:08 ` [PATCH v3 8/9] ARM: dts: Add "syscon" compatible string to chipid node Sylwester Nawrocki
2019-08-13 15:08 ` [PATCH v3 9/9] ARM: dts: Add samsung,asv-bin property for odroidxu3-lite Sylwester Nawrocki
2019-08-14 13:03 ` [PATCH v3 0/9] Exynos Adaptive Supply Voltage support Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).